----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128074/#review96138 -----------------------------------------------------------
Ship it! I've gone over the handlers for backendReady, and none of them is actually used to request a config then (that's encapsulated in backendmanager), so requesting a config before the backend is announced ready makes sense. - Sebastian Kügler On June 1, 2016, 1:30 p.m., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128074/ > ----------------------------------------------------------- > > (Updated June 1, 2016, 1:30 p.m.) > > > Review request for Plasma, Daniel Vrátil and Sebastian Kügler. > > > Repository: libkscreen > > > Description > ------- > > Without a valid config in the BackendManager, KScreen::Config::canBeApplied > always returns false causing KScreen to ignore any stored config on startup > sometimes. Wait until we have a config before telling that the backend is > ready. > > > Diffs > ----- > > src/backendmanager.cpp 570f575 > > Diff: https://git.reviewboard.kde.org/r/128074/diff/ > > > Testing > ------- > > I can now start kded5 from console without it falling back to an "ideal" > config. > > Didn't do much testing, though. Might have unwanted side-effects. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
