hein updated this revision to Diff 4123.
hein added a comment.
Don't open taskmanagerrulesrc every time, keep KConfig around and call
reparseConfiguration when a KDirWatch calls for it.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1
hein marked an inline comment as done.
hein added inline comments.
INLINE COMMENTS
> hein wrote in xwindowtasksmodel.cpp:434
> I've added a FIXME to optimize this at a later time. It's not worse than the
> old lib (it did this too).
Done.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISIO
bshah accepted this revision.
bshah added a reviewer: bshah.
bshah added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> graesslin wrote in idle_test.cpp:79
> that would be the wrong layer for such a test. It should be in whoever
> doesn't pass it along. That
graesslin added inline comments.
INLINE COMMENTS
> bshah wrote in idle_test.cpp:79
> In the past we've seen that touch events didn't resume from idle or
> something... perhaps add testcase for that?
that would be the wrong layer for such a test. It should be in whoever doesn't
pass it along. T
bshah accepted this revision.
bshah added a comment.
This revision is now accepted and ready to land.
Looks good.
REPOSITORY
rKWAYLAND KWayland
BRANCH
test-server
REVISION DETAIL
https://phabricator.kde.org/D1726
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
bshah added inline comments.
INLINE COMMENTS
> idle_test.cpp:79
> +QCOMPARE(spy.count(), 0);
> +m_fakeInput->requestPointerMove(QSizeF(1, 2));
> +QVERIFY(spy.wait());
In the past we've seen that touch events didn't resume from idle or
something... perhaps add testcase for that?
REP
hein updated this revision to Diff 4122.
hein added a comment.
Fix connect to private slot.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1722?vs=4121&id=4122
BRANCH
importlibtmng
REVISION DETAIL
https://phabricator.kde.org/D1722
hein updated this revision to Diff 4121.
hein marked 2 inline comments as done.
hein added a comment.
Fix build (mixed up dirs); more requested changes.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1722?vs=4118&id=4121
BRANCH
impor
hein marked 18 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> broulik wrote in launchertasksmodel.cpp:125
> coding style: foreach (...)
I don't understand this. You're complaining about the white space or ...? I
changed it assuming that was it.
> broulik wrote in taskgr
graesslin updated this revision to Diff 4120.
graesslin added a comment.
- Fixed the build error (accidentially introduced a Qt 5.7 functionality)
- Fixed the CMake path generation
- Pass arguments around. For this I removed QCommandLineParser as it doesn't
really make sense.
REPOSITORY
graesslin marked 5 inline comments as done.
REPOSITORY
rKWAYLAND KWayland
REVISION DETAIL
https://phabricator.kde.org/D1726
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, sebas, Plasma, bshah
Cc: sebas, bshah, plasma-devel
___
hein marked 21 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> hein wrote in abstracttasksmodel.h:63
> It means what the comment says: If it's true, the task is not subject to
> grouping. That means it will never be grouped. It's used by the applet's
> Don't allow/Allow T
hein updated this revision to Diff 4119.
hein added a comment.
Adapt to changed prop name in update to https://phabricator.kde.org/D1722.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1724?vs=4109&id=4119
BRANCH
importtmng
REVISION DET
hein updated this revision to Diff 4118.
hein added a comment.
Refresh activity count prop on activity state changes; more explicit prop
name.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1722?vs=4117&id=4118
BRANCH
importlibtmng
hein updated this revision to Diff 4117.
hein marked an inline comment as done.
hein added a comment.
Fix window info cache leak.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1722?vs=4110&id=4117
BRANCH
importlibtmng
REVISION DETA
graesslin added inline comments.
INLINE COMMENTS
> TODO.txt:1
> +Larger outstanding tasks:
> +- Implement missing kwayland bits (e.g. transient handling, virtual desktop
> logic).
do you really want to add a TODO.txt? My suggestion would be to add tasks to
maniphest here
> abstracttasksmodel.
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND7250773cf15d: [server] Don't destroy SlideInterface
when parent SurfaceInterface is destroyed (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricat
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDc7bf5dd0: [server] Properly handle destructor in
SlideInterface (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1713?vs=4062&i
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLANDd2f6665ce355: [server] Don't destroy BlurInterface
when parent SurfaceInterface is destroyed (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricato
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND4971be582ce7: [server] Don't destroy ShadowInterface
when SurfaceInterface gets destroyed (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.k
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND73e89530e69e: [server] Don't destroy
ServerSideDecorationInterface when parent… (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND6354bff902a4: [server] Don't destroy
ContrastInterface when parent SurfaceInterface is… (authored by graesslin).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde
hein marked an inline comment as done.
hein added inline comments.
INLINE COMMENTS
> hein wrote in tasksmodel.cpp:1220
> Quite possibly, I'll give it a try. I originally had everything in
> filterAcceptsRow() and the code then evolved more, and this was kind of left
> on the table along the way
hein updated this revision to Diff 4110.
hein added a comment.
- Move refilter-launcher-on-window insertion out of filterAcceptsRow() to
make it lighter.
- Move launcher refilter triggers to after grouping to ignore irrelevant
sub-level window insertions/removals.
- Remove a redundant Ski
hein updated this revision to Diff 4109.
hein marked an inline comment as done.
hein added a comment.
Adapt to *FullScreen* API change in update to
https://phabricator.kde.org/D1722.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1724?vs=4
hein updated this revision to Diff 4108.
hein added a comment.
Fullscreen -> FullScreen for consistency with Qt.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1722?vs=4107&id=4108
BRANCH
importlibtmng
REVISION DETAIL
https://phab
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128070/
---
Review request for Documentation and Plasma.
Repository: plasma-desktop
hein updated this revision to Diff 4107.
hein marked 2 inline comments as done.
hein added a comment.
Addressed most of David's and Martin's minor requests.
Outstanding bigger request:
- The ActivityInfo fix
- The TasksModel::filterAcceptsRow comment
REPOSITORY
rPLASMAWORKSPACE P
hein marked 2 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in taskfilterproxymodel.cpp:34
> Not that it will make a real difference, but shouldn't this technically
> default to 0?
>
> virtual desktops start at 1 with 0 being invalid.
Makes sense -
hein marked 6 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> hein wrote in xwindowtasksmodel.cpp:756
> Done.
Actually not done -- I'll ask you later about this.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1722
EMAIL PRE
hein marked 7 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> graesslin wrote in CMakeLists.txt:18-23
> do we want to have X11 conditional? Other areas of Plasma use X11
> unconditionally.
Personally as maintainer I do :). From my POV X11 is a legacy windowing system
for
hein updated this revision to Diff 4106.
hein marked 12 inline comments as done.
hein added a comment.
Make grouping toggle action actually a toggle action; requested code cleanup.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1724?vs=4105
hein marked 2 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> broulik wrote in ContextMenu.qml:123
> can be simplified to
> return menu.visualParent && menu.visualParent.virtualDesktop !=
> virtualDesktopInfo.currentDesktop
> same in tons of places below
Ok.
REPOSITORY
hein marked 13 inline comments as done.
hein added inline comments.
INLINE COMMENTS
> broulik wrote in CMakeLists.txt:7
> Why is icon tasks now in plasma-desktop instead of kdeplasma-addons?
It's not a case of "now": Icontasks has been in plasma-desktop for a long time
now. Please keep in mind
hein updated this revision to Diff 4105.
hein added a comment.
Addressed the comments relevant to the purpose of the review,
in particular the incorrect install names.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1724?vs=4091&id=4105
B
bshah requested changes to this revision.
bshah added a reviewer: bshah.
bshah added a comment.
This revision now requires changes to proceed.
While looking at cmake, I realized one issue.. and to verify this I tried to
build it and it didn't even build.. :\
INLINE COMMENTS
> KF5WaylandConfi
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added a comment.
This revision is now accepted and ready to land.
Aside from @bshah 's request, it looks good to me.
INLINE COMMENTS
> graesslin wrote in main.cpp:30-33
> right, but then more needs to be changed. All positiona
On Tuesday 31 May 2016 14:29:06 Sebastian Kügler wrote:
> Discussed with mgraesslin on IRC, preliminary conclusion below...
>
> On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote:
> > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after
> > reboot
> >
> > This bugrepor
On Wednesday 01 June 2016 00:05:10 Mark Gaiser wrote:
> Perhaps blockSignals can help you out [1]?
>
> object->blockSignals(true);
> // ...
> Write your changes
> // ...
> object->blockSignals(false);
>
> Object should be the object that currently receives the notification that
> the config file
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128069/
---
Review request for Plasma, Aleix Pol Gonzalez, Dominik Haumann, and Sebasti
sebas created this revision.
sebas added a reviewer: graesslin.
sebas added a subscriber: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Use a timer to avoid catching configChanged signals after we set
changes.
On 31.05.2016 22:38, Ivan Čukić wrote:
Hi all,
There are two main reasons why I'm against this (regardless of what
ends up being plasma logo, and regardless of whether it will be pretty
or not - the KDE logo would not win any beauty pageants :) ):
- (as previously mentioned) the gear-logo is
On Tue, May 31, 2016 at 2:29 PM, Sebastian Kügler wrote:
> Discussed with mgraesslin on IRC, preliminary conclusion below...
>
> On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote:
> > https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after
> > reboot
> >
> > This bugrepo
Kanedias updated this revision to Diff 4100.
Kanedias added a comment.
Updated against last M.Graesslin review.
Sorry, couldn't find a way to get rid of GbmBuffer struct (removed some
redundant fields though).
Re-checked with latest KWin and KRfb.
REPOSITORY
rKWAYLAND KWayland
CHAN
On Tue, May 31, 2016 at 10:38 PM, Ivan Čukić wrote:
> Microsoft is not Windows (they share the logo)
Not that I feel we need to discuss this further, but they do not share
the logo. The actual windows logo changes between iterations and has
since forever been the four tiles representing a window.
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
rKWAYLAND KWayland
BRANCH
shadow-destroy-surface
REVISION DETAIL
https://phabricator.kde.org/D1711
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailp
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
rKWAYLAND KWayland
BRANCH
slide-destroy-callback
REVISION DETAIL
https://phabricator.kde.org/D1713
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailp
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
rKWAYLAND KWayland
BRANCH
ssd-destroy-surface
REVISION DETAIL
https://phabricator.kde.org/D1710
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpref
sebas accepted this revision.
sebas added a reviewer: sebas.
This revision is now accepted and ready to land.
REPOSITORY
rKWAYLAND KWayland
BRANCH
blur-destroy-surface
REVISION DETAIL
https://phabricator.kde.org/D1708
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpre
Hi all,
There are two main reasons why I'm against this (regardless of what
ends up being plasma logo, and regardless of whether it will be pretty
or not - the KDE logo would not win any beauty pageants :) ):
- (as previously mentioned) the gear-logo is a recognizable brand
(easy to spot on on T
On 03.02.2016 18:31, Marco Martin wrote:
On Wednesday 03 February 2016 09:10:06 Dirk Hohndel wrote:
http://4.bp.blogspot.com/-jwBzU1YZWLI/U8U2E1nDM8I/mfY/jDbBMq9GkP4/
s1600/plasma-5-banner.png
As someone with a more "outside" perspective... boy that one is ugly. And
really doesn't prov
broulik added inline comments.
INLINE COMMENTS
> xuetianweng wrote in main_wayland.cpp:449
> Ah, ok, I misunderstood that this will inherit by session since I thought
> kwin start the script exit-with-session.
>
> But then I still have one minor concern, for any window that actually inside
> k
xuetianweng added inline comments.
INLINE COMMENTS
> graesslin wrote in main_wayland.cpp:449
> I don't understand the concern. The QT_IM_MODULE env variable set here in the
> code only affects KWin. It is not passed to any other process.
>
> Setting QT_IM_MODULE env variables will still overwri
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128038/#review96104
---
Ping, Eike, what you prefer?
- Anthony Fieroni
On Май 28,
graesslin added a comment.
Totally stupid question: why import at all into plasma-workspace? We could
also make it a standalone repository or does it depend on something else in
plasma-workspace?
INLINE COMMENTS
> CMakeLists.txt:18-23
> +if (X11_FOUND)
> +set(taskmanager_LIB_SRCS
> +
graesslin added inline comments.
INLINE COMMENTS
> bshah wrote in main.cpp:30-33
> It might be possible that one want to use executable with command line
> option... lets not restrict it to 1? and have >= 1?
right, but then more needs to be changed. All positional arguments need to be
passed t
davidedmundson edited subscribers, added: plasma-devel; removed: Plasma.
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D1698
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, Plasma
Cc: plasma-devel
_
davidedmundson edited subscribers, added: plasma-devel; removed: Plasma.
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D1699
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, Plasma
Cc: plasma-devel
_
bshah added a subscriber: plasma-devel.
REPOSITORY
rKIRIGAMI Kirigami
REVISION DETAIL
https://phabricator.kde.org/D1697
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, Plasma
Cc: plasma-devel, Plasma
__
bshah added inline comments.
INLINE COMMENTS
> main.cpp:30-33
> +const auto arguments = parser.positionalArguments();
> +if (arguments.size() != 1) {
> +return 1;
> +}
It might be possible that one want to use executable with command line
option... lets not restrict it to 1?
graesslin added a dependent revision: D1727: Add a test case for KIdleTime.
REPOSITORY
rKWAYLAND KWayland
REVISION DETAIL
https://phabricator.kde.org/D1726
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, Plasma
Cc: plasma-devel, sebas
graesslin added a dependency: D1726: Introduce a test server.
REPOSITORY
rKWAYLANDINTEGRATION Frameworks integration plugin using KWayland
REVISION DETAIL
https://phabricator.kde.org/D1727
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: graesslin, Plasma
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The test uses the new Wayland test server to run the test app.
REPOSITORY
rKWAYLANDINTEGRATION Framewo
graesslin created this revision.
graesslin added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
The idea of shipping a test server is to have something like Xvfb for
Wayland. To be able to run a test
Discussed with mgraesslin on IRC, preliminary conclusion below...
On dinsdag 31 mei 2016 14:05:06 CEST Sebastian Kügler wrote:
> https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after
> reboot
>
> This bugreport seems to be a common problem, and it's a good example for
> what's
Hey,
I've been looking into the bug 358011, that is:
https://bugs.kde.org/show_bug.cgi?id=358011 dual screen not setup after reboot
This bugreport seems to be a common problem, and it's a good example for
what's wrong with the screen configuration on startup.
TL;DR: We have a race condition wh
Heya people,
On Tue, May 31, 2016 at 4:40 PM, wrote:
>
> BUILD FAILURE
> Build URL:
> https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
> Project: PLATFORM=Linux,compiler=gcc
> Date of build: Tue, 31 May 2016 11:07:31 +
> Build duration: 1 min 56 se
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:36:28 +
Build duration: 7 min 25 sec
CHANGE SET
Revision 30ec050fdbab82218dea9fe2ba4c0554
GENERAL INFO
BUILD SUCCESS
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:36:28 +
Build duration: 7 min 25 sec
CHANGE SET
Revision 30ec050fdbab82218dea9fe2ba4c0554
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/108/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:07:47 +
Build duration: 28 min
CHANGE SET
Revision f5546cb5e61f13b67b340de597a63af25f
This revision was automatically updated to reflect the committed changes.
Closed by commit rKWAYLAND7d460ed00254: Add support for touch events in
fakeinput protocol and interface. (authored by bdhruve).
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1672
bdhruve added a comment.
Thank you @graesslin and @bshah
REPOSITORY
rKWAYLAND KWayland
BRANCH
fake-input-touch
REVISION DETAIL
https://phabricator.kde.org/D1672
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, Plasma, bshah, graesslin
Cc:
hein updated this revision to Diff 4092.
hein added a comment.
Addressed:
- Most of kbroulik's comments, including API comments
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1722?vs=4090&id=4092
BRANCH
importlibtmng
REVISION D
GENERAL INFO
BUILD FAILURE
Build URL:
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 11:07:31 +
Build duration: 1 min 56 sec
CHANGE SET
Revision 0f07e8bc237e77447d4767cb68414c73
graesslin accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
rKWAYLAND KWayland
BRANCH
fake-input-touch
REVISION DETAIL
https://phabricator.kde.org/D1672
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, Plasma,
hein added inline comments.
INLINE COMMENTS
> broulik wrote in launchertasksmodel.h:86
> "will fail" sounds like it's dangerous, "will do nothing"?
It means it will return false, for failure.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1722
EM
hein added inline comments.
INLINE COMMENTS
> broulik wrote in taskmanagerplugin.h:32
> Indentation is off
No, it's not ...?
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1722
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailp
bdhruve added a comment.
In https://phabricator.kde.org/D1672#31870, @bshah wrote:
> Looks good.
Output of arc land fake-input-touch:
TARGET Landing onto "master", the default target under git.
REMOTE Using remote "origin", the default remote under git.
FETCH Fetching o
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in abstracttasksmodel.cpp:41-42
> traditionally these are called "display" and "decoration"
> lowercase and without the word "Role"
>
> Also you should be able to do
>
> roles = QAbstractItemModel::roles() to get them.
This w
bshah accepted this revision.
bshah added a comment.
Looks good.
REPOSITORY
rKWAYLAND KWayland
REVISION DETAIL
https://phabricator.kde.org/D1672
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: bdhruve, graesslin, Plasma, bshah
Cc: bshah, graesslin, p
hein updated this revision to Diff 4091.
hein added a comment.
Switch to changed data role names in update to
https://phabricator.kde.org/D1722.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1724?vs=4085&id=4091
BRANCH
importtmng
REVI
hein updated this revision to Diff 4090.
hein added a comment.
Addressed:
- Data role names
- Nulling pointers
- Removed Messages.sh
- Saved lookup in startups model
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1722?vs=4083
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/107/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 09:59:36 +
Build duration: 9 min 18 sec
CHANGE SET
Revision fad800879265d3fe790ffeee11db
bdhruve updated this revision to Diff 4089.
bdhruve added a comment.
Fixed the coding style issue.
REPOSITORY
rKWAYLAND KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1672?vs=4063&id=4089
BRANCH
fake-input-touch
REVISION DETAIL
https://phabricator.kde.org/D1672
AFF
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in activityinfo.cpp:69
> If I have 4 activities. 2 running, 2 not.
>
> numberOfActivities returns 2
>
> I set one to running:
>
> the property changes
> this signal is not emitted.
Good catch. I think the old lib had this issu
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in concatenatetasksproxymodel.cpp:61
> we could add one?
>
> sourceModelForIndex() would make sense for a few cases.
It's on my todo, the comments are partly so I don't forget :). It's not a vital
issue at this moment, and also
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/106/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Tue, 31 May 2016 09:25:56 +
Build duration: 17 min
CHANGE SET
Revision e26f4ee4757cfcda06bb7ad57ba7e8aeb6
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Messages.sh:3
> The legacy version is also called this.
>
> That will cause a breakage on the i18n side.
>
> Either:
> two .pot files
> OR
> one Messages.sh
I'll pick option 3: Remove Messages.sh :-)
The new lib doesn't
davidedmundson added a comment.
Reviewed up to "libtaskmanager/taskfilterproxymodel.h"
Will submit this now, in case phabricator doesn't save it.
INLINE COMMENTS
> CMakeLists.txt:86
> +endif()
> +
> +write_basic_config_version_file(${CMAKE_CURRENT_BINARY_DIR}/LibTaskManagerConfigVersion.cma
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Looks good, but please fix the coding style.
INLINE COMMENTS
> fakeinput_interface.cpp:201-202
> +}
> +if(touchIds.contains(id))
> +{
> +return;
please
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEcc47d2bfca93: [System Tray] Don't iterate
keys() (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D1705?vs=4038&
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127975/
---
(Updated May 31, 2016, 2:26 a.m.)
Status
--
This change has been mar
This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEe26f4ee4757c: [PanelView] Check whether we're
X11 before calling QX11Info::connection() (authored by broulik).
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
CHANGES SINCE LAST UPDATE
htt
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127975/
---
(Updated May 31, 2016, 9:13 a.m.)
Review request for Plasma.
Repository
hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added dependencies: D1723: Rename Task Manager applets out of the way of
rewrites., D1721: Rename libtaskmanager to liblegacytaskmanager to make way for
rewrite..
Restricted Application added a
hein added a dependent revision: D1724: Import Task Manager widgets ports to
the new library..
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1721
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To
hein added a dependent revision: D1723: Rename Task Manager applets out of the
way of rewrites..
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1721
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added a dependency: D1721: Rename libtaskmanager to liblegacytaskmanager
to make way for rewrite..
Restricted Application added a project: Plasma.
REVISION SUMMARY
Also ports Pager to renamed
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1721
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailprefe
hein created this revision.
hein added a reviewer: Plasma.
hein added a subscriber: plasma-devel.
hein added a dependency: D1721: Rename libtaskmanager to liblegacytaskmanager
to make way for rewrite..
Restricted Application added a project: Plasma.
REVISION SUMMARY
Depends on https://phabricat
1 - 100 of 104 matches
Mail list logo
