hein added inline comments.

INLINE COMMENTS

> davidedmundson wrote in Messages.sh:3
> The legacy version is also called this.
> 
> That will cause a breakage on the i18n side.
> 
> Either: 
>  two .pot files
> OR
>  one Messages.sh

I'll pick option 3: Remove Messages.sh :-)

The new lib doesn't contain any strings, that the Messages.sh is there is an 
oversight. Thanks for catching!

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D1722

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: hein, Plasma
Cc: davidedmundson, plasma-devel, sebas
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Reply via email to