Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Martin Gräßlin
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 127944: KDE Platform Theme: set file dialog overwrite option appropriately for saving

2016-05-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127944/#review95639 --- autotests/kfiledialog_unittest.cpp (lines 220 - 223)

[Differential] [Closed] D1641: Don't update decoration when ServerSideDecoration gets destroyed and ShellClient is unmapped

2016-05-19 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN3c4619893c0d: Don't update decoration when ServerSideDecoration gets destroyed and… (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1641?vs=38

[Differential] [Accepted] D1646: Drop KDElibs4Support dependency from time engine

2016-05-19 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1646 EMAIL PREFERENCES https://phabricator.kde.org/settings/p

[Differential] [Accepted] D1643: Rename project from FrameworkIntegration to PlasmaIntegration

2016-05-19 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1643 EMAIL PREFERENCES https://phabricator.kde.org/

[Differential] [Updated] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-19 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1631 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: broulik, plasma-devel, sebas ___

[Differential] [Updated, 5,715 lines] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-19 Thread Martin Gräßlin
graesslin updated this revision to Diff 3899. graesslin added a comment. Multiline -> MultiLine REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1631?vs=3873&id=3899 BRANCH graesslin/text-input REVISION DETAIL https://phabricator.kde.org/D1631 AF

[Differential] [Request, 10 lines] D1646: Drop KDElibs4Support dependency from time engine

2016-05-19 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It was only used to connect to a DBus signal from powerdevil so we can just connect directly.

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/ --- (Updated Mai 19, 2016, 9:37 nachm.) Review request for KDE Frameworks and

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/ --- (Updated Mai 19, 2016, 9:35 nachm.) Review request for KDE Frameworks and

Re: status of kde/plasma kiosk framework in kf5

2016-05-19 Thread Albert Astals Cid
El dijous, 19 de maig de 2016, a les 10:39:48 CEST, Kai Uwe Broulik va escriure: > Hi, > > > i tried the toolbars action restriction but... > > ...i still could hide toolbars in dolphin and gwenview for example.. > > what did i do wrong? > > You're referring to right clicking the menu bar? > >

Re: Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/#review95628 --- +1 src/ktoolbar.cpp (line 815)

Review Request 127971: [KToolBar] Disable toggleViewAction() when actions/options_show_toolbar is restricted

2016-05-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127971/ --- Review request for KDE Frameworks and Plasma. Repository: kxmlgui Descr

[Differential] [Abandoned] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik abandoned this revision. broulik added a comment. Was a fancy little thing but patching KToolBar is significantly less invasive and will work for most of our apps. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/

[Differential] [Commented On] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

2016-05-19 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. > How can I simulate the KAuthorized stuff for an autotest? Is there a KConfig kdeglobals test mode or something like that? You don't need it in kdeglobals. See what I did in https://git.reviewboard.kde.org/r/127948/ Note that if you have it immutabl

[Differential] [Commented On] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

2016-05-19 Thread davidedmundson (David Edmundson)
davidedmundson added a comment. Seems messy when we we can just do: toggleViewAction()->setEnabled(KAuthorized...) in the KToolBar constructor It'd fix all the cases which we're trying to fix as KIOSK only affects KDE apps. REPOSITORY rPLASMAINTEGRATION Integration for Qt appl

[Differential] [Accepted] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

2016-05-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1644 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/

[Differential] [Updated, 125 lines] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 3894. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1644?vs=3893&id=3894 REVISION DETAIL https://phabricator.kde.org/D1644 AFFECTED FILES autotests/CMakeLists.txt src

[Differential] [Commented On] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik added a comment. F130087: toolbartoggle.png REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1644 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferen

[Differential] [Request, 125 lines] D1644: Enforce options_show_toolbar for QToolBar toggleViewAction

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY

[Differential] [Request, 2 lines] D1643: Rename project from FrameworkIntegration to PlasmaIntegration

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAINTEGRATION Integration for Qt applications in Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLA

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin
> On May 19, 2016, 3:22 p.m., Martin Gräßlin wrote: > > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have > > files which don't match that we need to either change copyright or remove > > the files. > > Martin Gräßlin wrote: > A check shows that examples/kpart and

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Martin Gräßlin
> On May 19, 2016, 5:22 p.m., Martin Gräßlin wrote: > > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have > > files which don't match that we need to either change copyright or remove > > the files. > > Martin Gräßlin wrote: > A check shows that examples/kpart and

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Martin Gräßlin
> On May 19, 2016, 5:22 p.m., Martin Gräßlin wrote: > > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have > > files which don't match that we need to either change copyright or remove > > the files. A check shows that examples/kpart and src/kpart are not built at all.

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin
> On May 19, 2016, 3:25 p.m., Marco Martin wrote: > > ok, let's actually fix this properly > > Marco Martin wrote: > package/packagestructure/servicejob are the ones that should be > relicensed (i would argue they already are, as their corresponding .cpp file > is lgpl 2+ already all the

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin
> On May 19, 2016, 3:25 p.m., Marco Martin wrote: > > ok, let's actually fix this properly package/packagestructure/servicejob are the ones that should be relicensed (i would argue they already are, as their corresponding .cpp file is lgpl 2+ already - Marco ---

[Differential] [Closed] D1609: RFC: Make Kickoff read-only when SystemImmutable

2016-05-19 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP4d92b8669d0c: Make Kickoff read-only when SystemImmutable (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1609?vs=3813&id=3889#toc REPOSITORY rPLASMADESKTOP Pl

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/#review95616 --- ok, let's actually fix this properly - Marco Martin On May

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/#review95615 --- I think the approach here is wrong. Our frameworks are LGPLv2

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 96 - Still unstable!

2016-05-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/96/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 May 2016 15:06:13 + Build duration: 13 min CHANGE SET Revision c1e5dfbefeaf0e1544d6fad79512afcc0bb

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 69 - Fixed!

2016-05-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 May 2016 15:05:48 + Build duration: 9 min 12 sec CHANGE SET Revision b0a96e9c1a6df38982c535eb59f5592d

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 69 - Fixed!

2016-05-19 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/69/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 May 2016 15:05:48 + Build duration: 9 min 12 sec CHANGE SET Revision b0a96e9c1a6df38982c535eb59f5592d

Re: Review Request 127909: [AppletInterface] Expose immutability

2016-05-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127909/ --- (Updated May 19, 2016, 6:13 p.m.) Status -- This change has been mar

[Differential] [Accepted] D1641: Don't update decoration when ServerSideDecoration gets destroyed and ShellClient is unmapped

2016-05-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH deco-destroy-shell-cleint REVISION DETAIL https://phabricator.kde.org/D1641 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Updated, 7 lines] D1641: Don't update decoration when ServerSideDecoration gets destroyed and ShellClient is unmapped

2016-05-19 Thread Martin Gräßlin
graesslin updated this revision to Diff 3888. graesslin added a comment. Also protect the other way around if first ShellSurface, then ServerSideDeco is destroyed REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1641?vs=3887&id=3888 BRANCH deco-destroy-shel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 68 - Failure!

2016-05-19 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/68/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 May 2016 14:45:13 + Build duration: 6 min 35 sec CHANGE SET Revision 2f610574a438d8af4fcc7c93811055ec

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 95 - Failure!

2016-05-19 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/95/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 May 2016 14:46:31 + Build duration: 45 sec CHANGE SET Revision 5a35926c14db54bec510495570fc98a4af12

[Differential] [Updated, 28 lines] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik updated this revision to Diff 3885. broulik added a comment. Also adjust microphone OSD REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1635?vs=3868&id=3885 REVISION DETAIL https://phabricator.kde.org/D1635 AFFECTED FILES s

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread mart (Marco Martin)
mart added a comment. +1 REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: mart, broulik, plasma-devel, sebas ___

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 94 - Still Unstable!

2016-05-19 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/94/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 19 May 2016 14:33:24 + Build duration: 13 min CHANGE SET Revision dc453c5bf07be617bb731442d75c5cd75b8

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/ --- (Updated May 19, 2016, 2:37 p.m.) Status -- This change has been mar

[Differential] [Request, 5 lines] D1641: Don't update decoration when ServerSideDecoration gets destroyed and ShellClient is unmapped

2016-05-19 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Most likely the window is in the process of getting destroyed. In that case the following destroy of th

[Differential] [Closed] D1633: [Kickoff/Trash] Offer KCM access only if allowed

2016-05-19 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPeb193d0eb0ca: [Kickoff/Trash] Offer KCM access only if allowed (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1633?

[Differential] [Closed] D1632: [Battery/Clock] Offer KCM access only if allowed

2016-05-19 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEdc453c5bf07b: [Battery/Clock] Offer KCM access only if allowed (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

[Differential] [Accepted] D1632: [Battery/Clock] Offer KCM access only if allowed

2016-05-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1632 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1635: [OSD] Make volume OSD thresholds consistent with Volume Applet

2016-05-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1635 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1633: [Kickoff/Trash] Offer KCM access only if allowed

2016-05-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1633 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-19 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/#review95613 --- src/scriptengines/qml/plasmoid/appletinterface.h (line 279)

Re: Review Request 127870: plasma-framework: AppletInterface::downloadPath()

2016-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127870/#review95612 --- Ship it! Ship It! - Marco Martin On May 8, 2016, 4:15 p

Re: Review Request 127909: [AppletInterface] Expose immutability

2016-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127909/#review95611 --- Fix it, then Ship it! src/scriptengines/qml/plasmoid/appl

Re: Review Request 127963: Adding missing license

2016-05-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/#review95607 --- Ship it! Ship It! - Marco Martin On May 19, 2016, 1:51

Review Request 127963: Adding missing license

2016-05-19 Thread Maximiliano Curia
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread René J . V . Bertin
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

[Differential] [Changed Subscribers] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > textinput_interface.h:158 > + */ > +Multiline = 1 << 9 > +}; MultiLine? Makes it consistent with Qt API REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1631 EMAIL PREFERENCES https://phabrica

[Differential] [Updated] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: broulik, plasma-devel, sebas ___

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Elvis Angelaccio
> On May 17, 2016, 2:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS > broulik wrote in virtualkeyboard.cpp:291 > Perhaps set ImhSensitiveData | ImhHiddenText ? No those are already part of the contentHints() and already mapped. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PR

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread René J . V . Bertin
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

[Differential] [Changed Subscribers] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > main.qml:25 > +id: window > +color: "transparent" > +InputPanel { Instead of making a transparent Rectangle, just use Item instead > virtualkeyboard.cpp:291 > +case TextInputInterface::ContentPurpose::Password: > +

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread Boudhayan Gupta
> On May 17, 2016, 8:07 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

Re: Review Request 126198: [OS X] adaptations for the KdePlatformTheme

2016-05-19 Thread René J . V . Bertin
> On May 17, 2016, 4:37 p.m., Martin Gräßlin wrote: > > given that Plasma integration got removed I suggest to create a dedicated > > osx-integration repository for it as well. > > René J.V. Bertin wrote: > I quite like the way things are, but yes, I've played with that idea. > >

[Differential] [Commented On] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread Martin Gräßlin
graesslin added a comment. F129735: Spectacle.lx1761.png Virtual keyboard with some test input in the various supported layouts REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Updated] D1631: Implement wl_text_input and zwp_text_input_v2 interfaces

2016-05-19 Thread Martin Gräßlin
graesslin added a dependent revision: D1638: Integrate QtVirtualKeyboard into KWin/Wayland. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1631 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-deve

[Differential] [Updated] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread Martin Gräßlin
graesslin added a dependency: D1631: Implement wl_text_input and zwp_text_input_v2 interfaces. REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D1638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: plasma-devel, se

[Differential] [Request, 585 lines] D1638: Integrate QtVirtualKeyboard into KWin/Wayland

2016-05-19 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The idea is to have KWin provide a virtual keyboard. To support this KWin uses the QT_IM_MODULE qtvirtu

Re: status of kde/plasma kiosk framework in kf5

2016-05-19 Thread Martin Graesslin
On Wednesday, May 18, 2016 10:50:36 PM CEST Mag. Weissel Thomas wrote: > first of all... thank you all so much for your engagement.. i can't say > it in other words than.. you rock! As a Plasma dev just following the work going in, I need to agree: they rock! I'm really impressed with which vigo

[Differential] [Accepted] D1582: Move the OpenGL unsafe check into the Platform

2016-05-19 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH opengl-safe-check-through-platform REVISION DETAIL https://phabricator.kde.org/D1582 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/email

[Differential] [Request, 53 lines] D1622: [client] Ensure PlasmaWindowModel removes deleted windows

2016-05-19 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There is a possibility that a PlasmaWindow is unmapped when the PlasmaWindowModel gets created. In

Re: Review Request 126953: Remove Theme Details KCM

2016-05-19 Thread Thomas Zeman
Thomas Zeman Wien, am 17.05.2016 Austria,Wien An Sie und alle KDE Entwickler bei allem Respekt, seid ihr Euch bewußt, dass Ihr aus KDE unter Vorwand die besten Funktionen und Feineinstellungen herausnehmt. Das Ihr beginnt die gleichen Fehler wie

[Differential] [Accepted] D1622: [client] Ensure PlasmaWindowModel removes deleted windows

2016-05-19 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH window-model-remove-deleted-windows REVISION DETAIL https://phabricator.kde.org/D1622 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: gr

Problem running Plasma with Wayland in Arch Linux

2016-05-19 Thread Alfonso Hernandez
in the construction of Astian OS for desktop we have encountered an error executing the command startplasmacompositor send the screenshot. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Accepted] D1575: Move requiresCompositing from Application to Platform

2016-05-19 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH platform-requires-compositing REVISION DETAIL https://phabricator.kde.org/D1575 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Accepted] D1624: [client] Add context pointer to connects in PlasmaWindowModel

2016-05-19 Thread hein (Eike Hein)
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH context-property-connect REVISION DETAIL https://phabricator.kde.org/D1624 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Pl

[Differential] [Request, 137 lines] D1624: [client] Add context pointer to connects in PlasmaWindowModel

2016-05-19 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: Plasma, hein. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When the model gets destroyed the lambda connections were still invoked and could cause crashers.

Re: status of kde/plasma kiosk framework in kf5

2016-05-19 Thread Kai Uwe Broulik
Hi, > i tried the toolbars action restriction but... > ...i still could hide toolbars in dolphin and gwenview for example.. > what did i do wrong? You're referring to right clicking the menu bar? Turns out this menu is added automatically by Qt, ie. it's one layer down in the stack, and it know

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

2016-05-19 Thread sitter (Harald Sitter)
sitter added a comment. Neon presently only integrates source changes once a day. You should be able to poke rebuilds yourself btw as login is driven through phabricator http://build.neon.kde.org/job/xenial_unstable_frameworks_kservice/ http://build.neon.kde.org/job/xenial_unstable_plas