> On May 19, 2016, 3:22 p.m., Martin Gräßlin wrote: > > I think the approach here is wrong. Our frameworks are LGPLv2+. If we have > > files which don't match that we need to either change copyright or remove > > the files. > > Martin Gräßlin wrote: > A check shows that examples/kpart and src/kpart are not built at all. > They are dead code and could just be removed. src/plasma/private/packageFOO > could easily be wrapped by implementing through the newer KPackage framework. > servicejob_p.h might just be incorrectly licensed, history needs to be > checked as all other files around it are properly or later. > > Martin Gräßlin wrote: > I just verified for servicejob_p.h, was split out from servicejob.cpp in > 89b71cd9f195da51993533f7fc2329ddc08a7de4 of kdelibs
relicensed what i could, and removed the kpart-specific stuff as wasn't built anyways - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127963/#review95615 ----------------------------------------------------------- On May 19, 2016, 2:37 p.m., Maximiliano Curia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127963/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 2:37 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > We are currently shipping an LGPL-2.1 copy in the COPYING.LIB file, but > some parts of the code are under a LGPL-2 only license and the LGPL > license requires shipping the full text with the source code. > > The list of LGPL-2 only files is: > examples/kpart/containmentshell.cpp > examples/kpart/containmentshell.h > examples/kpart/main.cpp > examples/kpart/testshellpluginloader.cpp > examples/kpart/testshellpluginloader.h > src/kpart/plasmakpartview.cpp > src/kpart/scripting/rect.cpp > src/plasma/private/package_p.h > src/plasma/private/packagestructure_p.h > src/plasma/private/servicejob_p.h > > > Diffs > ----- > > COPYING.LGPL-2 PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/127963/diff/ > > > Testing > ------- > > > Thanks, > > Maximiliano Curia > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
