Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/#review95471 --- kcms/componentchooser/componentchooserbrowser.cpp (line 86)

Re: Kirigami popup

2016-05-14 Thread Marco Martin
On Saturday 14 May 2016, Martin Klapetek wrote: > Perhaps it's something in the Page then, this is how the > ButtonGallery looks like when changed from ScrollablePage > to simple Page and opening the OverlayDrawer > > http://paste.opensuse.org/a0c63072 should work now in master -- Marco Martin

Re: Kirigami popup

2016-05-14 Thread Marco Martin
On Saturday 14 May 2016, Martin Klapetek wrote: > > in the current master it should be usable everywhere as any other item > > just have to pay attention that is something anchored to a root item > > enough that it takes the full visible area, so shouldn't be inside > > row/column layouts > > Per

Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-14 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127918/ --- Review request for Plasma and David Faure. Repository: plasma-desktop D

Re: Review Request 123281: Avoid triggering bug 340691

2016-05-14 Thread Hrvoje Senjan
> On May 13, 2016, 8:43 p.m., David Faure wrote: > > kcms/migrationlib/kdelibs4config.h, line 28 > > > > > > I just noticed a compiler warning in this method: the "mode" argument > > isn't used. This part of the

Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)

2016-05-14 Thread Hrvoje Senjan
> On May 13, 2016, 8:59 p.m., David Faure wrote: > > kcms/componentchooser/componentchooserbrowser.cpp, line 86 > > > > > > This change makes it impossible for me to choose another browser than > > firefox on Ope

[Differential] [Accepted] D1609: RFC: Make Kickoff read-only when SystemImmutable

2016-05-14 Thread hein (Eike Hein)
hein accepted this revision. hein added a reviewer: hein. hein added a comment. This revision is now accepted and ready to land. I'd prefer if the code comments were properly capitalized and had punctuation marks, but that minor nitpick aside, sure why not ... REPOSITORY rPLASMADESKTOP Plas

Re: Kirigami popup

2016-05-14 Thread Martin Klapetek
On Thu, May 12, 2016 at 7:34 AM, Marco Martin wrote: > On Wednesday 11 May 2016 22:36:37 Martin Klapetek wrote: > > > > > > I would say OverlaySheet > > > > Is ScrollabePage a requirement for that? I can see that the Gallery > > uses it but if I switch it to Page, the OverlaySheet just breaks. >

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-05-14 Thread Martin Klapetek
On Sat, May 14, 2016 at 9:14 AM, kdea wrote: > I have uploaded the component to the "Qt Components" section of > http://qt-apps.org , as you propose. It is available here: > > http://qt-apps.org/content/show.php?content=176013 > > I think it is better than nothing. But I would prefer a dedica

Re: Proposal: kde-libs.org, a repository of contributed libraries

2016-05-14 Thread kdea
I have uploaded the component to the "Qt Components" section of http://qt-apps.org , as you propose. It is available here: http://qt-apps.org/content/show.php?content=176013 I think it is better than nothing. But I would prefer a dedicated web, a repository of contributed libraries, classifi

[kio-extras] [Bug 363048] File conflicts with kio_activities

2016-05-14 Thread Ivan Čukić via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363048 Ivan Čukić changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED Resolution|---

[Differential] [Commented On] D1610: [Powermanagement Dataengine] Expose "Logout" as Sleep State

2016-05-14 Thread broulik (Kai Uwe Broulik)
broulik added a comment. What else should it be? Leave has logout, reboot, shutdown, all of which are options to quit the session which the user is forbidden in this case. It makes no sense to disallow logging out but then allowing turning off the computer altogether. REPOSITORY rPLASMAWO

[kio-extras] [Bug 363048] File conflicts with kio_activities

2016-05-14 Thread Christoph Feck via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363048 Christoph Feck changed: What|Removed |Added CC||ivan.cu...@kde.org Summary|transact