Re: Review Request 127753: [taskmanager] Fixing typos

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127753/#review95444 --- Ping. They generate warnings. - Anthony Fieroni On Май 6,

[Differential] [Accepted] D1601: [KRunner] Honor KAuthorized lineedit_text_completion

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1601 EMAIL PREFERENCES https://phabricator.kde.org/settings/pan

[Differential] [Request, 4 lines] D1601: [KRunner] Honor KAuthorized lineedit_text_completion

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This key is supposed to disable auto com

[Differential] [Commented On] D1600: Check user is allowed to run krunner when forwarding key events

broulik added inline comments. INLINE COMMENTS krunner/main.cpp:59 Maybe print something on console REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1600 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Commented On] D1600: Check user is allowed to run krunner when forwarding key events

broulik added a comment. That accept was for the first revision of the patch, please split the KRunner stuff into a separate commit REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1600 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Accepted] D1600: Check user is allowed to run krunner when forwarding key events

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D1600 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Updated, 36 lines] D1600: Check user is allowed to run krunner when forwarding key events

davidedmundson updated this revision to Diff 3792. davidedmundson added a comment. - Don't run krunner if the user isn't allowed to use it REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1600?vs=3791&id=3792 BRANCH master REVISION DE

[Differential] [Request, 4 lines] D1600: Check user is allowed to run krunner when forwarding key events

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16

Re: status of kde/plasma kiosk framework in kf5

David Edmundson ha scritto: > ​Here's my list I spent the evening on from searching the code. When you are done with all the discoveries, could you please update the pages on wikis, like for example: https://userbase.kde.org/KDE_System_Administration#User_.26_Group_Profiles (and related subpages)

Re: status of kde/plasma kiosk framework in kf5

cool... i missed that.. plasma/containment_actions=false #works(1/2) - disables the contextmenu on the desktop so the last one "acitivities" is also gone.. nothing else changed.. systray, applicationlauncher, konsole(starter), still open a context menu.. activities are still configurable via

Re: status of kde/plasma kiosk framework in kf5

Where are you finding those key values? ​Here's my list I spent the evening on from searching the code. action/bookmarks | ???. FIXME 0 action/kdesktop_rmb | Whether the user can right click on a file icon on the desktop action/kwin_rmb | Whether the user can show the context menu on window t

Re: status of kde/plasma kiosk framework in kf5

hello everybody! i found some time to test several options.. here is what i have so far and i think i found one or two bugs. please comment to the #works(1/2) and #not-working parts.. especially activities and (RE)movable toolbars need a "fix" [KDE Action Restrictions][$i] action/run_command=

Re: Basic QPushButton keyboard shortcut test fails under KDE session

As with most bugs it's two people doing something a slightly wrong that makes something actually wrong. The documentation explitcitly says: >shortcut : QKeySequence >This property holds the _*mnemonic*_ associated with the button. (emphasis mine) http://doc.qt.io/qt-5/qabstractbutton.html#short

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/ --- (Updated Mai 12, 2016, 4:03 nachm.) Status -- This change has been d

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

> On Mai 12, 2016, 3:59 nachm., David Edmundson wrote: > > kcmshell/main.cpp, line 95 > > > > > > this line is already doing it. > > > > bool KService::noDisplay() const > > ... > > if (!KAuth

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/#review95426 --- Ship it! Ship It! - David Edmundson On May 12, 2016, 9:

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

> On May 12, 2016, 3:59 p.m., David Edmundson wrote: > > kcmshell/main.cpp, line 95 > > > > > > this line is already doing it. > > > > bool KService::noDisplay() const > > ... > > if (!KAuthor

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/#review95424 --- -2 kcmshell/main.cpp (line 95)

[Differential] [Closed] D1596: Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN14d12c05855a: Do not limit mouse actions to titleBarArea but allow on complete… (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1596?vs=3776&i

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/#review95423 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 12, 2016,

[Differential] [Closed] D1586: Delay maximize button click to next event cycle

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN6cd0d5a54acf: Delay maximize button click to next event cycle (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1586?vs=3758&id=3787 REVISION D

Re: Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/#review95422 --- +1 - Marco Martin On May 12, 2016, 1:59 p.m., Kai Uwe Brou

Review Request 127899: [KCMShell] Honor KAuthorized restrictions

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127899/ --- Review request for KDE Frameworks and Plasma. Repository: kde-cli-tools

Re: status of kde/plasma kiosk framework in kf5

On Thursday 12 May 2016 13:57:31 David Edmundson wrote: > > same reason i disabled all title bar actions in kwin and all > > keyboardshortcuts.. i don't want anyone to accidentally do something > > unintended.. > > OK, I think that might have got lost in the port. > containment_context_menu doesn

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 84 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 May 2016 12:50:21 + Build duration: 17 min CHANGE SET Revision a19fcfaf90db8ebc6e704917448ccfde7ae

[Differential] [Accepted] D1596: Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH titlebar-position-actions REVISION DETAIL https://phabricator.kde.org/D1596 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Accepted] D1594: Improve the deconstruction of PlasmaWindows

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH improved-resource-cleanup-plasma-window REVISION DETAIL https://phabricator.kde.org/D1594 EMAIL PREFERENCES https://phabricator.kde.org/setting

[Differential] [Accepted] D1595: Unmap PlasmaWindowInterface instead of deleting directly

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH plasma-window-management-destroy REVISION DETAIL https://phabricator.kde.org/D1595 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpr

Re: status of kde/plasma kiosk framework in kf5

>That last one should be >plasma/plasmashell/unlockedDesktop=false thank you for spotting that :-) >Maybe, but the documentation is the main part missing, and the tool is only as good as the documentation it's showing. Sorting that should be our first priority. definitely.. we ( probably i ) ne

[Differential] [Request, 156 lines] D1594: Improve the deconstruction of PlasmaWindows

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The protocol is extended by a dedicated destructor request. When a PlasmaWindow is umapped we no longer

[Differential] [Updated, 98 lines] D1595: Unmap PlasmaWindowInterface instead of deleting directly

graesslin updated this revision to Diff 3775. graesslin added a comment. - Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1595?vs=3774&id=3775 BRANCH titlebar-position-actio

[Differential] [Accepted] D1544: [lbinput] Support setting pointer acceleration

broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH libinput-pointer-acceleration REVISION DETAIL https://phabricator.kde.org/D1544 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

Re: Feedback on xdg-shell v5

On Mon, May 9, 2016 at 8:18 PM, Jonas Ådahl wrote: > On Fri, Apr 29, 2016 at 12:37:22PM +0300, Pekka Paalanen wrote: > > On Fri, 29 Apr 2016 15:31:28 +0800 > > Jonas Ådahl wrote: > > > > > On Thu, Apr 28, 2016 at 02:08:07PM +0300, Pekka Paalanen wrote: > > > > On Thu, 28 Apr 2016 17:36:58 +0800

[Differential] [Request, 90 lines] D1596: Do not limit mouse actions to titleBarArea but allow on complete titleBarPosition

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Mouse actions like wheel and double click were restricted to the titleBar area. This made the top most

[Differential] [Updated, 174 lines] D1594: Improve the deconstruction of PlasmaWindows

graesslin updated this revision to Diff 3778. graesslin added a comment. use removeOne + Q_ASSERT, also reorder cleanup to have client destroy before server, otherwise crash possible REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1594?vs=3773&id=3778

[Differential] [Request, 1 line] D1571: [kcms/touchpad] Disable kded module on platforms != x11

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The only supported backend is x11. Also on Wayland the kded module doesn't make any sense. The function

[Differential] [Updated, 8 lines] D1595: Unmap PlasmaWindowInterface instead of deleting directly

graesslin updated this revision to Diff 3777. graesslin added a comment. Restore to correct version. Sorry for the noise - arc failed me REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1595?vs=3775&id=3777 BRANCH plasma-window-management-destroy REVISION D

[Differential] [Request, 8 lines] D1595: Unmap PlasmaWindowInterface instead of deleting directly

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The window will be cleaned up automatically once all bound resources are destroyed. A manual delete tho

[Differential] [Accepted] D1571: [kcms/touchpad] Disable kded module on platforms != x11

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH touchpad-kded-disable-wayland REVISION DETAIL https://phabricator.kde.org/D1571 EMAIL PREFERENCES https://phabricator.kde.org/set

Contribution to plasma

Hi !! I am looking forward to contribute to Plasma again ! ( I know its a long gap, but better late than never ;) ) It would be great if I could get some suggestions on the on going projects where I could contribute too during weekends. Also, suggestions are welcome on the upcoming projects/progra

[Differential] [Updated, 38 lines] D1544: [lbinput] Support setting pointer acceleration

graesslin updated this revision to Diff 3719. graesslin added a comment. Only emit changed signal if value changed REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1544?vs=3660&id=3719 BRANCH libinput-pointer-acceleration REVISION DETAIL https://phabricat

[Differential] [Updated, 36 lines] D1544: [lbinput] Support setting pointer acceleration

graesslin updated this revision to Diff 3660. graesslin added a comment. Correct the mapping for values from [0.1,1.0] to [-1.0,0.0] REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1544?vs=3659&id=3660 BRANCH libinput-pointer-acceleration REVISION DETAIL

[Differential] [Request, 36 lines] D1544: [lbinput] Support setting pointer acceleration

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKWIN KWin BRANCH libinput-pointer-acceleration REVISION DETAIL https://phabricator.kde.org/D1544 AFFECT

Re: status of kde/plasma kiosk framework in kf5

On Thu, May 12, 2016 at 1:44 PM, Thomas Weissel wrote: > thank you david for your answer and thx to thomas for inviting me to this > mailinglist and also for linking to plasma-devel :-) > > so instead of /etc/kde4/kdeglobals my "action restrictions" go to > /etc/kde5rc from now on !? > > Yes. >

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 83 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/83/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 May 2016 12:34:56 + Build duration: 9 min 19 sec CHANGE SET Revision 40e35e025746f8cc0297cc51c7a93

[Differential] [Closed] D1591: [Shell Runner] Add "Run in Terminal" option

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb619b1322570: [Shell Runner] Add "Run in Terminal" option (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1591?vs=3769&id=3786#toc REPOSITORY rPLASMAWORKSPAC

[Differential] [Closed] D1590: [Places Runner] Add mimeDataForMatch

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE40e35e025746: [Places Runner] Add mimeDataForMatch (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1590?vs=376

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 82 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/82/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 May 2016 12:05:33 + Build duration: 13 min CHANGE SET Revision aee6bfe310d9e10726ac778363e14b0de7f

[Differential] [Closed] D1593: Remove superfluous KAuthorised check with new name

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEaee6bfe310d9: Remove superfluous KAuthorised check with new name (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator

Re: KWin in docker container for Plasma Mobile Emulator

On Thu, May 12, 2016 at 10:00 AM, Martin Graesslin wrote: > That's your error: XDG_RUNTIME_DIR is not set. Without that specified the > Wayland socket cannot be created and cannot be found by clients. > Yes, XDG_RUNTIME_DIR was indeed the issue, which is fixed now. Thank you for your help Marti

Re: Review Request 127850: Let Plasma::Corona load the layout on all cases.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127850/#review95419 --- Fix it, then Ship it! logic is fine, but should not add pu

Re: status of kde/plasma kiosk framework in kf5

Hi Thomas, thank you for your detailed email! I have added the Plasma mailing list, hoping that somebody on that list can provide feedback, which is probably relevant for others on the enterprise list as well (so please make sure you reply to all, dear Plasma devs :) ). Thanks, Thomas On Mittwoc

[Differential] [Commented On] D1593: Remove superfluous KAuthorised check with new name

davidedmundson added a comment. ShellCorona:390 which then calls Corona::setImmutability(Plasma::Types::SystemImmutable) which is basically Plasma's own custom KAuthorized system REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.or

Re: Kirigami popup

On Wednesday 11 May 2016 22:36:37 Martin Klapetek wrote: > > > > I would say OverlaySheet > > Is ScrollabePage a requirement for that? I can see that the Gallery > uses it but if I switch it to Page, the OverlaySheet just breaks. in the current master it should be usable everywhere as any other

[Differential] [Accepted] D1586: Delay maximize button click to next event cycle

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH fix-aurorae-maximize-5.6 REVISION DETAIL https://phabricator.kde.org/D1586 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Commented On] D1583: fix sycoca init to pass in isolated testbeds without pre-existing sycoca

mart added a comment. +1 REPOSITORY rKDECLITOOLS KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D1583 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sitter, dfaure Cc: mart, plasma-devel, sebas

[Differential] [Accepted] D1590: [Places Runner] Add mimeDataForMatch

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1590 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: brou

[Differential] [Accepted] D1591: [Shell Runner] Add "Run in Terminal" option

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. INLINE COMMENTS runners/places/placesrunner.h:53 this seems an unrelated change? runners/shell/shellrunner.h:50 cleanup of this maybe in separate commit? REPOSITORY rPLASMAWORKSPACE Pl

[Differential] [Accepted] D1592: [Device Notifier] Add option to disable popup on new device

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. not completely sold on the need for the option, but yeah, go ahead REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D159

Review Request 127898: use selected icon when menu items are configured to be of highlight color

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127898/ --- Review request for Plasma. Repository: oxygen Description --- even

[Differential] [Request, 2 lines] D1597: Bind sending frameRendered to whether we have a Wayland Server not to operation mode

graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures that frameRendered is also sent if we start a Wayland Server on X11. REPOSITORY rKWIN K

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 81 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/81/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 May 2016 09:52:56 + Build duration: 10 min CHANGE SET Revision 153393a62b7a40f5199ce9eca42aff38c18

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127878/ --- (Updated May 12, 2016, 9:53 a.m.) Review request for KDE Frameworks and P

[Differential] [Closed] D1589: [Location Runner] Cleanup

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE153393a62b7a: [Location Runner] Cleanup (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1589?vs=3767&id=3781

Re: Review Request 127878: use the "selected" icon mode in file open dialog sidebar

> On May 11, 2016, 11:03 a.m., David Edmundson wrote: > > src/widgets/kfileitemdelegate.cpp, line 1220 > > > > > > QCommonStyle when rendering CE_ItemViewItem checks for disabled first > > > > QIcon::Mo

[Differential] [Closed] D1595: Unmap PlasmaWindowInterface instead of deleting directly

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN0be773262e01: Unmap PlasmaWindowInterface instead of deleting directly (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1595?vs=3777&id=3780 R

[Differential] [Closed] D1594: Improve the deconstruction of PlasmaWindows

This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND866aea1a93db: Improve the deconstruction of PlasmaWindows (authored by graesslin). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1594?vs=3778&id=3779 RE

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 80 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/80/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 12 May 2016 08:39:29 + Build duration: 13 min CHANGE SET Revision f839e1a7d39fc29f04521f13ab5088dcbb1

[Differential] [Commented On] D1594: Improve the deconstruction of PlasmaWindows

graesslin added inline comments. INLINE COMMENTS src/server/plasmawindowmanagement_interface.cpp:252 No windows cannot be in it multiple times. It's only insert from one place where a new object is created and added. So, one could use removeOne and then a Q_ASSERT for contains. REPOSITOR