[Differential] [Accepted] D1535: add some tests for corrupt configs

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rKSCREEN KScreen BRANCH sebas/corruptautotests REVISION DETAIL https://phabricator.kde.org/D1535 EMAIL PREFERENCES https://phabricator.kde.org/settings/pa

[Differential] [Commented On] D1534: make the serializer a bit more robust

graesslin added a comment. would it be possible to have test cases for these issues? REPOSITORY rKSCREEN KScreen REVISION DETAIL https://phabricator.kde.org/D1534 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, Plasma Cc: graesslin, plasma-dev

[Differential] [Commented On] D1532: validate the config before checking if it can be applied

graesslin added a comment. what about a test case for it? REPOSITORY rLIBKSCREEN KScreen Library REVISION DETAIL https://phabricator.kde.org/D1532 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: sebas, Plasma Cc: graesslin, plasma-devel, sebas __

[Differential] [Updated, 107 lines] D1535: add some tests for corrupt configs

sebas updated this revision to Diff 3635. sebas added a comment. more realistic corrupt config file This simulates the config half-written, which it seems could happen if we end up reading mid-write. REPOSITORY rKSCREEN KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org

[Differential] [Request, 72 lines] D1535: add some tests for corrupt configs

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This allows us to make sure that when a config file is borked, we're not suddenly creating invalid configs. TE

[Differential] [Request, 7 lines] D1534: make the serializer a bit more robust

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The daemon has some valid code pathes involving null configs. I've not seen this particular part crashing, but

[Differential] [Request, 4 lines] D1533: guard access to unsafe config pointer

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes a crashing race condition in the kscreen kded module when the config cannot be deserialized from the

[Differential] [Request, 4 lines] D1532: validate the config before checking if it can be applied

sebas created this revision. sebas added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY canBeApplied is public API, it shouldn't blow up when passed an invalid config, but indicate (correctly!) that

Review Request 127826: [IconThumbnail] Request for icon, don't let kwindow::icon to decide

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127826/ --- Review request for Plasma, David Edmundson and Martin Gräßlin. Repository

[Differential] [Closed] D1509: Honor input mask set on internal windows

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd19690ce984a: Honor input mask set on internal windows (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1509?vs=3619&id=3622 REVISION DETAIL

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated May 3, 2016, 1:21 p.m.) Review request for Plasma. Changes ---

[Differential] [Updated, 934 lines] D1231: Add Krfb interface to KWayland

Kanedias updated this revision to Diff 3620. Kanedias added a comment. Remade protocol to be able to pass multiple buffers to client. Sent buffers are tracked inside interface object. REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1231?vs=2970&id=36

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 71 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/71/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 03 May 2016 11:02:01 + Build duration: 11 min CHANGE SET Revision 903cbfd7e267a4812a6ec222eb7e1b5dd77

Re: Review Request 125648: Add method to run a script from DBus directly

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125648/ --- (Updated May 3, 2016, 11:01 a.m.) Status -- This change has been mar

[Differential] [Accepted] D1509: Honor input mask set on internal windows

bshah accepted this revision. bshah added a reviewer: bshah. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH input-mask-internal-window REVISION DETAIL https://phabricator.kde.org/D1509 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

Today's Plasma Test Days prep meeting cancelled

Hi, just a short notice for those looking for notes and logs: Today's Plasma Test Days prep meeting was cancelled due to a schedule conflict with the Kirigami meeting. We'll reconvene next week. By next week you might want to review https://community.kde.org/Plasma/TestDays to give input on t

[Differential] [Updated, 15 lines] D1509: Honor input mask set on internal windows

graesslin updated this revision to Diff 3619. graesslin added a comment. Extended the tests to cover the new condition and also fixed a regression found by the test. REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1509?vs=3559&id=3619 BRANCH input-mask-int

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review95128 --- autotests/configmodeltest.cpp (line 26)

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated May 3, 2016, 7:04 a.m.) Review request for Plasma. Changes ---