----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ -----------------------------------------------------------
(Updated May 3, 2016, 1:21 p.m.) Review request for Plasma. Changes ------- Test also creating ConfigModel from package QML ConfigView needs containment and corona and ConfigCategory is not exported, soo I've included cpp file ... Repository: plasma-framework Description ------- ConfigModel may contain ConfigCategory for both QML pages and KCM pages. The source property will be empty for KCM pages. This fixes correctly returning empty source for KCM pages. Also return the same value from get(). Diffs (updated) ----- autotests/CMakeLists.txt 747e8e0 autotests/configmodeltest.h PRE-CREATION autotests/configmodeltest.cpp PRE-CREATION autotests/data/testconfigpackage/contents/config/config.qml PRE-CREATION autotests/data/testconfigpackage/contents/config/main.xml PRE-CREATION autotests/data/testconfigpackage/contents/ui/ConfigGeneral.qml PRE-CREATION autotests/data/testconfigpackage/contents/ui/main.qml PRE-CREATION autotests/data/testconfigpackage/metadata.desktop PRE-CREATION src/plasmaquick/configmodel.cpp 3f69073 Diff: https://git.reviewboard.kde.org/r/127702/diff/ Testing ------- Added qml config page to plasma-pa, KCM page now works fine. Thanks, David Rosca
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
