Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
On Tue, Mar 8, 2016 at 6:55 PM, kainz.a wrote: > > No, what I mean was that what Kai was suggesting can be fabricated >> super easily, making things look like they got VDG approval even if >> they did not. >> > > As the VDG approval stuff comes from the icon theme and I'm the > maintainer, it's n

Re: VDG approved widgets

2016-03-08 Thread kainz.a
> No, what I mean was that what Kai was suggesting can be fabricated > super easily, making things look like they got VDG approval even if > they did not. > As the VDG approval stuff comes from the icon theme and I'm the maintainer, it's not that easy. (I work at an company something like TÜV) ___

Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
On Tue, Mar 8, 2016 at 6:41 PM, kainz.a wrote: > On the other hand, that does not really prevent /all/ the widgets to >> be VDG approved without the VDG approval :) >> >> > > yes if you like it's something like an Usability and Design review at

Re: VDG approved widgets

2016-03-08 Thread kainz.a
> > On the other hand, that does not really prevent /all/ the widgets to > be VDG approved without the VDG approval :) > > yes if you like it's something like an Usability and Design review at the widget with an brand and hopefully some external

Re: Review Request 127309: [DeclarativeDragArea] Don't override text of mime data

2016-03-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127309/#review93318 --- +1, I don't recall where this is coming from. - Aleix Pol Go

Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
On Tue, Mar 8, 2016 at 4:55 PM, Kai Uwe Broulik wrote: > Hi, > > I like that! > > X-Plasma-VDG-Approved=true :) > On the other hand, that does not really prevent /all/ the widgets to be VDG approved without the VDG approval :) Cheers -- Martin Klapetek | KDE Developer _

Re: VDG approved widgets

2016-03-08 Thread Kai Uwe Broulik
Hi, I like that! X-Plasma-VDG-Approved=true :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: VDG approved widgets

2016-03-08 Thread kainz.a
it is added to the applet icon so the VDG can do it themself without any additional stuff. 2016-03-08 22:33 GMT+01:00 Martin Klapetek : > On Tue, Mar 8, 2016 at 3:48 PM, kainz.a wrote: > >> Hi, >> >> Some of the plasmoids are really awesome in style and usability. This >> hard work from the deve

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/#review93314 --- kcms/touchpad/src/backends/x11/synapticstouchpad.h

Re: VDG approved widgets

2016-03-08 Thread Martin Klapetek
On Tue, Mar 8, 2016 at 3:48 PM, kainz.a wrote: > Hi, > > Some of the plasmoids are really awesome in style and usability. This hard > work from the developers would we support with an VDG approved "sticker" > to the widget explorer icons so the user know which plasmoids are > aweseome. In additi

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-08 Thread Rajeesh K V
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/ --- (Updated March 8, 2016, 9:11 p.m.) Review request for Plasma, David Edmun

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Luigi Toscano
Sebastian Kügler ha scritto: > On Tuesday, March 08, 2016 21:20:22 Luigi Toscano wrote: >> Alexander Potashev ha scritto: >>> 2016-03-08 23:04 GMT+03:00 Ivan Čukić : We have had System Settings since ages, this patch just streamlines other similar components to that naming scheme. >>> >>>

VDG approved widgets

2016-03-08 Thread kainz.a
Hi, Some of the plasmoids are really awesome in style and usability. This hard work from the developers would we support with an VDG approved "sticker" to the widget explorer icons so the user know which plasmoids are aweseome. In addition the not VDG approved widget developers want to have also

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Sebastian Kügler
On Tuesday, March 08, 2016 18:14:02 Sebastian Kügler wrote: > (please CC: me, I'm not subscribed) > > We have a smallish number of string changes post-freeze. > > One fixes usage of the KDE brand in kinfocenter, patches are in master, but > I'd like to see this fixed in the upcoming 5.6 already.

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Sebastian Kügler
On Tuesday, March 08, 2016 21:20:22 Luigi Toscano wrote: > Alexander Potashev ha scritto: > > 2016-03-08 23:04 GMT+03:00 Ivan Čukić : > >> We have had System Settings since ages, this patch just streamlines > >> other similar components to that naming scheme. > > > > OK then. Sorry for the noise. >

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Luigi Toscano
Alexander Potashev ha scritto: > 2016-03-08 23:04 GMT+03:00 Ivan Čukić : >> We have had System Settings since ages, this patch just streamlines >> other similar components to that naming scheme. > > OK then. Sorry for the noise. > Well, couldn't this be the right time to move away from the ambig

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Alexander Potashev
2016-03-08 23:04 GMT+03:00 Ivan Čukić : > We have had System Settings since ages, this patch just streamlines > other similar components to that naming scheme. OK then. Sorry for the noise. -- Alexander Potashev ___ Plasma-devel mailing list Plasma-dev

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Sebastian Kügler
On Tuesday, March 08, 2016 21:13:00 Alexander Potashev wrote: > 2016-03-08 20:14 GMT+03:00 Sebastian Kügler : > > Esteemed translators, > > > > (please CC: me, I'm not subscribed) > > > > We have a smallish number of string changes post-freeze. > > > > One fixes usage of the KDE brand in kinfoce

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 13 - Still Failing!

2016-03-08 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/13/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 08 Mar 2016 20:03:31 + Build duration: 2 min 4 sec CHANGE SET Revision cd0d29d0309f4ce0a926dd

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Ivan Čukić
Hi Alexander, We have had System Settings since ages, this patch just streamlines other similar components to that naming scheme. Cheers, Ivan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Differential] [Commented On] D1088: [krunner] Don't call KWindowSystem::setState on every event

2016-03-08 Thread broulik (Kai Uwe Broulik)
broulik added a comment. and suddenly I can no longer type faster than KRunner can process. Nice finding! +1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences

[Differential] [Updated] D1088: [krunner] Don't call KWindowSystem::setState on every event

2016-03-08 Thread Martin Gräßlin
graesslin marked an inline comment as done. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma Cc: broulik, plasma-devel, Plasma ___

Review Request 127309: [DeclarativeDragArea] Don't override text of mime data

2016-03-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127309/ --- Review request for Plasma. Repository: kdeclarative Description ---

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Alexander Potashev
Hi Sebastian, 2016-03-08 20:14 GMT+03:00 Sebastian Kügler : > Esteemed translators, > > (please CC: me, I'm not subscribed) > > We have a smallish number of string changes post-freeze. > > One fixes usage of the KDE brand in kinfocenter, patches are in master, but > I'd > like to see this fixed i

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Sebastian Kügler
On Tuesday, March 08, 2016 18:58:03 Luigi Toscano wrote: > On Tuesday 08 of March 2016 17:14:05 Sebastian Kügler wrote: > > Then we have a renamed .desktop file for systemsettings, really just a > > filename rename. > > Renaming the .desktop file is more on translator administration (which > these

Re: two exceptions for string freeze in Plasma

2016-03-08 Thread Luigi Toscano
On Tuesday 08 of March 2016 17:14:05 Sebastian Kügler wrote: > Esteemed translators, > > (please CC: me, I'm not subscribed) > > We have a smallish number of string changes post-freeze. > > One fixes usage of the KDE brand in kinfocenter, patches are in master, but > I'd like to see this fixed i

Re: Review Request 127102: Use fixed width for digital clock applet

2016-03-08 Thread Daniel Faust
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127102/ --- (Updated März 8, 2016, 6:53 nachm.) Review request for kde-workspace and

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 12 - Still Failing!

2016-03-08 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 08 Mar 2016 17:38:16 + Build duration: 1 min 38 sec CHANGE SET Revision af861ab88fc545818995d

[Differential] [Commented On] D1090: [krunner] Make it work on Wayland

2016-03-08 Thread Martin Gräßlin
graesslin added inline comments. INLINE COMMENTS krunner/view.cpp:255 The needless null check is dropped locally already REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1090 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Request, 72 lines] D1090: [krunner] Make it work on Wayland

2016-03-08 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. graesslin added a subscriber: Plasma. graesslin set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. graesslin added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Checks whe

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-08 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127308/#review93306 --- Do we want a kconf_update script with that for all hte people

two exceptions for string freeze in Plasma

2016-03-08 Thread Sebastian Kügler
Esteemed translators, (please CC: me, I'm not subscribed) We have a smallish number of string changes post-freeze. One fixes usage of the KDE brand in kinfocenter, patches are in master, but I'd like to see this fixed in the upcoming 5.6 already. Then we have a renamed .desktop file for system

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Failing!

2016-03-08 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 08 Mar 2016 16:51:55 + Build duration: 51 sec CHANGE SET Revision 67633b61575a2d1775e1388ab93

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 5 - Still Failing!

2016-03-08 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/5/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 08 Mar 2016 16:06:50 + Build duration: 1 min 47 sec CHANGE SET Revision d8a796475d2572d276b4

[Differential] [Request, 9 lines] D1088: [krunner] Don't call KWindowSystem::setState on every event

2016-03-08 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. graesslin added a subscriber: Plasma. graesslin set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. graesslin added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY On Wayland

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127308/#review93305 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 8, 2016

Re: Review Request 127302: IconItem: Animate active change even with animations disabled

2016-03-08 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127302/#review93303 --- What about the enabled property where it grays-out the icon i

Re: Review Request 127302: IconItem: Animate active change even with animations disabled

2016-03-08 Thread David Rosca
> On March 8, 2016, 4:19 p.m., Kai Uwe Broulik wrote: > > What about the enabled property where it grays-out the icon if disabled? The same should be done also for enabled property. I'll update the patch. - David --- This is an automati

[Differential] [Closed] D1086: Removing the copy of KAStats from the plasma-desktop

2016-03-08 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP61f8b6093ca3: Removing the copy of KAStats from the plasma-desktop (authored by ivan). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1086

Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-08 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127308/ --- Review request for Plasma. Repository: systemsettings Description -

[Differential] [Request, 6,309 lines] D1086: Removing the copy of KAStats from the plasma-desktop

2016-03-08 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: mart, sebas, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY For the Plasma 5.7, we will be able to use the kactivities-stats framework instead of having our internal copy REPOSITORY rPLAS

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/#review93302 --- Ship it! Okay, thanks for the explanation. - Sebastian Kü

[Differential] [Accepted] D933: Fix minimum size of Applet handle with Folder View

2016-03-08 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. visible only on few applets, those that have the run associated application button as well REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DET

[Differential] [Accepted] D933: Fix minimum size of Applet handle with Folder View

2016-03-08 Thread hein (Eike Hein)
hein accepted this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D933 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, mart, hein Cc: mart, plasma-devel

[Differential] [Accepted] D941: Fix position of new applets added with drag and drop

2016-03-08 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH add-applet-offset (branched from master) REVISION DETAIL https://phabricator.kde.org/D941 EMAIL PREFERENCES https://phabricator.kde.

Re: Review Request 127302: IconItem: Animate active change even with animations disabled

2016-03-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127302/#review93301 --- Ship it! Ship It! - Marco Martin On March 7, 2016, 11:3

[Differential] [Closed] D1082: [kcm] Remove QQuickView for themes

2016-03-08 Thread Martin Gräßlin
This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKER47d3969ef306: [kcm] Remove QQuickView for themes (authored by graesslin). REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1082?vs=2611&id=26

[Differential] [Closed] D1084: Removing SwitcherActivityModel now that it exists in KActivities

2016-03-08 Thread Ivan Čukić
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb5f6bdc7f721: Removing SwitcherActivityModel now that it exists in KActivities (authored by ivan). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.k

[Differential] [Request, 4 lines] D1085: [KSysGuardProcessList] Don't forward keys with modifiers (except shift) to the search field

2016-03-08 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rLIBKSYSGUARD KSysguard Library. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This breaks shortcuts like Ctrl+A to select all. The same a

[Differential] [Request, 803 lines] D1084: Removing SwitcherActivityModel now that it exists in KActivities

2016-03-08 Thread Ivan Čukić
ivan created this revision. ivan added reviewers: mart, sebas. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This code was here only because we haven't been able to depend on kf5.20 in plasma 5.6. This removes it, and uses KActivities::Activ

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-08 Thread Harald Sitter
> On March 8, 2016, 10:15 a.m., Sebastian Kügler wrote: > > CMakeLists.txt, line 14 > > > > > > Pardon my ignrance, but what does this mean? Plugin uses math.h -> needs libm -> doesn't explicitly link libm -> cau

[Differential] [Commented On] D1082: [kcm] Remove QQuickView for themes

2016-03-08 Thread bshah (Bhushan Shah)
bshah added a comment. Accepted given in previous review still stands. REVISION DETAIL https://phabricator.kde.org/D1082 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, bshah, Plasma Cc: bshah, plasma-devel ___

[Differential] [Updated, 377 lines] D1082: [kcm] Remove QQuickView for themes

2016-03-08 Thread Martin Gräßlin
graesslin retitled this revision from "Only require Qt 5.4" to "[kcm] Remove QQuickView for themes". graesslin updated the summary for this revision. graesslin removed rKSCREENLOCKER KScreenLocker as the repository for this revision. graesslin updated this revision to Diff 2611. CHANGES SINCE LA

[Differential] [Accepted] D1082: Only require Qt 5.4

2016-03-08 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. Looks good to me. REPOSITORY rKSCREENLOCKER KScreenLocker BRANCH kcm-remove-themes REVISION DETAIL https://phabricator.kde.org/D1082 EMAIL PREFERENCES

[Differential] [Request, 34 lines] D1082: Only require Qt 5.4

2016-03-08 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY We don't have any code requiring Qt 5.5, so let's go down with the requirement to make it build on CI again. SVN_SILENT made messa

[Plasma Workspace Wallpapers] [Bug 349392] Desktop backgrounds are blurred

2016-03-08 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=349392 Kai Uwe Broulik changed: What|Removed |Added CC||k...@privat.broulik.de Resolution|---

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-08 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/#review93289 --- CMakeLists.txt (line 14)

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-08 Thread Rajeesh K V
> On March 8, 2016, 8:21 a.m., Xuetian Weng wrote: > > kcms/touchpad/src/kcm/ui/scroll.ui, line 138 > > > > > > I just wonder if plasma 5.6 is in string freeze or not. > > Xuetian Weng wrote: > Ok plasma 5.6

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-08 Thread Xuetian Weng
> On March 8, 2016, 8:21 a.m., Xuetian Weng wrote: > > kcms/touchpad/src/kcm/ui/scroll.ui, line 138 > > > > > > I just wonder if plasma 5.6 is in string freeze or not. Ok plasma 5.6 is already string freeze. You

Re: Review Request 127306: Touchpad KCM: Fix synaptics driver issues

2016-03-08 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127306/#review93282 --- Ah, it's actually my fault. Thank you for fixing this. kcms