> On March 8, 2016, 10:15 a.m., Sebastian Kügler wrote: > > CMakeLists.txt, line 14 > > <https://git.reviewboard.kde.org/r/127296/diff/1/?file=448202#file448202line14> > > > > Pardon my ignrance, but what does this mean?
Plugin uses math.h -> needs libm -> doesn't explicitly link libm -> causes build fail with suitably restrictive enough flags I think(tm). random infomration I found pertaining to this https://cmake.org/Wiki/CMake_2.6_Notes#Linking_to_System_Libraries - Harald ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127296/#review93289 ----------------------------------------------------------- On March 6, 2016, 5:21 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127296/ > ----------------------------------------------------------- > > (Updated March 6, 2016, 5:21 p.m.) > > > Review request for Plasma and Harald Sitter. > > > Repository: breeze-plymouth > > > Description > ------- > > KDECompilerSettings aren't included so this wasn't spotted earlier, but we > pass the flag anyway in openSUSE's %cmake_kf5 macro. > > > Diffs > ----- > > CMakeLists.txt 3a4cd73 > breeze-text/CMakeLists.txt 17501cb > > Diff: https://git.reviewboard.kde.org/r/127296/diff/ > > > Testing > ------- > > Now builds. > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
