Re: Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127269/ --- (Updated March 4, 2016, 12:21 a.m.) Status -- This change has been m

Re: Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127270/ --- (Updated March 4, 2016, 12:21 a.m.) Status -- This change has been m

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/ --- (Updated March 4, 2016, 12:20 a.m.) Status -- This change has been m

[Differential] [Requested Changes To] D1066: Fix saving correct length of panel

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. this is a binding loop. PanelView.cpp has setResizeMode(QuickViewSharedEngine::SizeRootObjectToView);

[Differential] [Commented On] D1066: Fix saving correct length of panel

apol added a comment. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1066 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma Cc: apol, plasma-devel ___

[Differential] [Request, 4 lines] D1066: Fix saving correct length of panel

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY This fixes calculating correct availableScreenRegion as PanelView::length is used in PanelView::geometryByDistance. REPOSITORY rPLASMADESK

Re: Review Request 127263: Add Wireless Energy Saving action

> On March 3, 2016, 1:36 p.m., Kai Uwe Broulik wrote: > > > y) Switching to a profile where the action is enabled too and options are > > > turned off -> will turn on the wifi/wwan/bt > > z) Switching to a profile where the action is disabled -> will recover the > > previous state of the wifi/w

Re: Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

> On March 3, 2016, 6:32 p.m., Aleix Pol Gonzalez wrote: > > Is it being tested from QtQuick as well? Internally this is using QtQuick. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.

Re: Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127270/#review93118 --- Ship it! Ship It! - Marco Martin On March 3, 2016, 6:28

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93117 --- Fix it, then Ship it! src/declarativeimports/core/iconite

Re: Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127269/#review93116 --- Ship it! Is it being tested from QtQuick as well? - Aleix

Review Request 127269: Add unit test for loading QPixmaps and QImages into IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127269/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Review Request 127270: Remove effectively duplicate code path for handling QPixmaps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127270/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 127268: Docs for IconItem

> On März 3, 2016, 6:08 nachm., David Rosca wrote: > > src/declarativeimports/core/iconitem.h, line 69 > > > > > > There is no animation on resize. > > David Edmundson wrote: > Oh, it seems so. I'm sure it us

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/ --- (Updated March 3, 2016, 6:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 127268: Docs for IconItem

> On March 3, 2016, 6:08 p.m., David Rosca wrote: > > src/declarativeimports/core/iconitem.h, line 69 > > > > > > There is no animation on resize. Oh, it seems so. I'm sure it used to so that it didn't do a big j

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93113 --- src/declarativeimports/core/iconitem.h (line 48)

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93110 --- src/declarativeimports/core/iconitem.h (line 69)

Re: Review Request 127268: Docs for IconItem

> On March 3, 2016, 6:06 p.m., Aleix Pol Gonzalez wrote: > > src/declarativeimports/core/iconitem.h, line 42 > > > > > > Needs to start with `/**` for doxygen to pick up. thanks. Weirdly it seems my subconcious r

Re: Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/#review93111 --- src/declarativeimports/core/iconitem.h (line 42)

Review Request 127268: Docs for IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127268/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 127260: Experiment: cache svg icons from icon theme

> On March 3, 2016, 2:09 p.m., Kai Uwe Broulik wrote: > > src/plasma/svg.cpp, line 233 > > > > > > New connect syntax pls themeChanged() is a Q_PRIVATE_SLOT I understood the new synthax can't be used with them?

Re: [PATCH] Allow the program to explicitly hide a notification

On Thursday 03 March 2016 06:19:19 Dirk Hohndel wrote: > AH, right, I forgot to post about that problem. > > So for me the magic notification attached to the action button didn't seem > to work - or more precisely, I couldn't figure out how to access it from a > page that didn't have it's own acti

Re: [PATCH] Allow the program to explicitly hide a notification

> On Mar 3, 2016, at 8:12 AM, Marco Martin wrote: > > On Thursday 03 March 2016 06:19:19 Dirk Hohndel wrote: >> AH, right, I forgot to post about that problem. >> >> So for me the magic notification attached to the action button didn't seem >> to work - or more precisely, I couldn't figure out

Re: [PATCH] Allow the program to explicitly hide a notification

On Thu, Mar 03, 2016 at 11:51:53AM +0100, Marco Martin wrote: > On Wednesday 02 March 2016 14:50:52 Dirk Hohndel wrote: > > If I want to use a PassiveNotification to give some information to the > > user that either hides after a while or gets removed when it's no longer > > valid (i.e.: accessing

Re: Review Request 127260: Experiment: cache svg icons from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review93101 --- src/plasma/svg.cpp (line 194)

Re: Review Request 127263: Add Wireless Energy Saving action

> On März 3, 2016, 1:36 nachm., Kai Uwe Broulik wrote: > > > y) Switching to a profile where the action is enabled too and options are > > > turned off -> will turn on the wifi/wwan/bt > > z) Switching to a profile where the action is disabled -> will recover the > > previous state of the wifi/

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 12:35 odp., Lamarque Souza wrote: > > daemon/actions/bundled/wirelesspowersaving.cpp, line 49 > > > > > > This and the next two if are a bit strange. Shouldn't this be: > > > > if (m_la

Re: Review Request 127263: Add Wireless Energy Saving action

> On March 3, 2016, 12:35 p.m., Lamarque Souza wrote: > > daemon/actions/bundled/wirelesspowersaving.cpp, line 49 > > > > > > This and the next two if are a bit strange. Shouldn't this be: > > > > if (m_l

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 1:36 odp., Kai Uwe Broulik wrote: > > > y) Switching to a profile where the action is enabled too and options are > > > turned off -> will turn on the wifi/wwan/bt > > z) Switching to a profile where the action is disabled -> will recover the > > previous state of the wifi/ww

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93095 --- > y) Switching to a profile where the action is enabled too a

Re: Review Request 127260: Experiment: cache svg icons from icon theme

> On March 2, 2016, 11:48 p.m., David Edmundson wrote: > > why would someone load an icon as an SVG and not use IconItem? > > Marco Martin wrote: > there is somebody loading icons as SVG and not using IconItem and it is > wait for it... IconItem :p > jokes aside, i think this should be

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 12:35 odp., Lamarque Souza wrote: > > daemon/actions/bundled/wirelesspowersaving.cpp, line 49 > > > > > > This and the next two if are a bit strange. Shouldn't this be: > > > > if (m_la

Re: Review Request 127263: Add Wireless Energy Saving action

> On Bře. 3, 2016, 12:36 odp., Kai Uwe Broulik wrote: > > Please add Usability for this review, too and describe in more detail what > > it does. So, when I plug back in the cable it turns everything back on > > unconditionally? While that's fine with WiFi I don't want eg. Bluetooth to > > tur

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- (Updated Bře. 3, 2016, 1:30 odp.) Review request for Plasma, Solid, KDE U

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93090 --- Please add Usability for this review, too and describe in mor

Re: Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review93088 --- CMakeLists.txt (line 25)

Re: Review Request 127260: Experiment: cache svg icons from icon theme

> On March 2, 2016, 11:48 p.m., David Edmundson wrote: > > why would someone load an icon as an SVG and not use IconItem? > > Marco Martin wrote: > there is somebody loading icons as SVG and not using IconItem and it is > wait for it... IconItem :p > jokes aside, i think this should be

Review Request 127263: Add Wireless Energy Saving action

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/ --- Review request for Plasma, Solid and Kai Uwe Broulik. Repository: powerde

Re: [PATCH] Allow the program to explicitly hide a notification

On Wednesday 02 March 2016 14:50:52 Dirk Hohndel wrote: > If I want to use a PassiveNotification to give some information to the > user that either hides after a while or gets removed when it's no longer > valid (i.e.: accessing some web service), then I need a way to explicitly > hide the notifica

Re: Review Request 127260: Experiment: cache svg icons from icon theme

> On March 2, 2016, 11:48 p.m., David Edmundson wrote: > > why would someone load an icon as an SVG and not use IconItem? there is somebody loading icons as SVG and not using IconItem and it is wait for it... IconItem :p jokes aside, i think this should be done at the lowest level this things