Re: Review Request 127260: Experiment: cache svg icons from icon theme

2016-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/#review93079 --- why would someone load an icon as an SVG and not use IconItem

Re: [breeze] /: Only build the decoration if the KDecoration2 is present

2016-03-02 Thread Aleix Pol
On Wed, Mar 2, 2016 at 11:32 PM, šumski wrote: > On Thursday 25 of February 2016 14:29:22 Aleix Pol wrote: >> Git commit fa748e869ddcd4a75f314bfb2ba85b879a3b7e1d by Aleix Pol. >> Committed on 25/02/2016 at 13:29. >> Pushed by apol into branch 'master'. >> >> Only build the decoration if the KDecor

[PATCH] Allow the program to explicitly hide a notification

2016-03-02 Thread Dirk Hohndel
If I want to use a PassiveNotification to give some information to the user that either hides after a while or gets removed when it's no longer valid (i.e.: accessing some web service), then I need a way to explicitly hide the notification /D From 4f8efa1c0e0a44cdc3e9504fa553d637766c41dc Mon Sep

Re: [breeze] /: Only build the decoration if the KDecoration2 is present

2016-03-02 Thread šumski
On Thursday 25 of February 2016 14:29:22 Aleix Pol wrote: > Git commit fa748e869ddcd4a75f314bfb2ba85b879a3b7e1d by Aleix Pol. > Committed on 25/02/2016 at 13:29. > Pushed by apol into branch 'master'. > > Only build the decoration if the KDecoration2 is present > > REVIEW: 127174 > > M +9-3

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 2 - Still Failing!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 21:10:05 + Build duration: 1 min 37 sec CHANGE SET Revision 09e58f7f33658fec6291

Re: Review Request 126879: [digital-clock] Use iso-codes for country names

2016-03-02 Thread Pino Toscano
> On Mar. 1, 2016, 1:31 p.m., Martin Klapetek wrote: > > Turns out pkg_get_variable is available only in cmake 3.4, while minimum > > requirement is "2.8.12". > > > > Can you perhaps change the cmake module to not use pkg_get_variable for now? Yessir, will change it soon. Thanks for the notic

Jenkins-kde-ci: sddm-kcm Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sddm-kcm%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:37:48 + Build duration: 41 sec CHANGE SET No changes JUNIT RESULTS Name: (

Jenkins-kde-ci: polkit-kde-agent-1 Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/polkit-kde-agent-1%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:37:17 + Build duration: 35 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-workspace Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Failure!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:36:18 + Build duration: 46 sec CHANGE SET No changes

Jenkins-kde-ci: oxygen Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/oxygen%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:34:08 + Build duration: 1 min 28 sec CHANGE SET No changes JUNIT RESULTS Nam

Jenkins-kde-ci: ksshaskpass Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/ksshaskpass%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:31:18 + Build duration: 33 sec CHANGE SET No changes JUNIT RESULTS Name

Jenkins-kde-ci: kmenuedit Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmenuedit%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:30:33 + Build duration: 58 sec CHANGE SET No changes JUNIT RESULTS Name:

Plasma 5.6 beta

2016-03-02 Thread Jonathan Riddell
Plasma 5.6 beta is out https://www.kde.org/announcements/plasma-5.5.95.php Comes with tech previews of +breeze-grub +breeze-plymouth kactivitymanagerd is added, see earlier e-mails from Ivan about the changes in kactivity release bits. plasma-integration is added, the plasma parts of frameworks

Jenkins-kde-ci: kinfocenter Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Failure!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:30:13 + Build duration: 49 sec CHANGE SET No changes _

Jenkins-kde-ci: khotkeys Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:29:58 + Build duration: 1 min 52 sec CHANGE SET No changes JUNIT RESULTS N

Jenkins-kde-ci: kde-gtk-config Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kde-gtk-config%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 18:28:33 + Build duration: 1 min 13 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 1 - Failure!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 16:36:47 + Build duration: 2 min 23 sec CHANGE SET No changes

Jenkins-kde-ci: sddm-kcm master kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sddm-kcm%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 16:00:36 + Build duration: 50 sec CHANGE SET Revision c9f5c6db1f3a8e3952f4cd77abe486d404bddbb3 by

Jenkins-kde-ci: sddm-kcm master kf5-qt5 » Linux,gcc - Build # 21 - Fixed!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/sddm-kcm%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 16:00:36 + Build duration: 50 sec CHANGE SET Revision c9f5c6db1f3a8e3952f4cd77abe486d404bddbb3 by

[Differential] [Closed] D1050: Center contents of desktop toolbox

2016-03-02 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP3df205ea70f8: Center contents of desktop toolbox (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1050?vs=2519&id=2520

Jenkins-kde-ci: oxygen master kf5-qt5 » Linux,gcc - Build # 55 - Failure!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/oxygen%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/55/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 15:56:21 + Build duration: 29 sec CHANGE SET Revision 615f6a7095889e7a9a3b06e098e9e0829c5d63c0 by Jo

Review Request 127260: Experiment: cache svg icons from icon theme

2016-03-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127260/ --- Review request for Plasma. Repository: plasma-framework Description ---

[Differential] [Accepted] D1050: Center contents of desktop toolbox

2016-03-02 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. Good enough for 5.6 imo REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH toolbox-center (branched from master) REVISION DETAIL https://phabricator.kde.org/D10

[Differential] [Request, 31 lines] D1050: Center contents of desktop toolbox

2016-03-02 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Works only with Breeze theme, other themes needs to adjust widgets/translucentbackground to not have any transparent margins. REPOSITORY r

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 466 - Fixed!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/466/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 14:43:56 + Build duration: 7 min 45 sec CHANGE SET Revision 5611b9cf2c09e1cfed03c5c4ec3b5

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 466 - Fixed!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/466/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 14:43:56 + Build duration: 7 min 45 sec CHANGE SET Revision 5611b9cf2c09e1cfed03c5c4ec3b5

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 14:26:26 + Build duration: 2 min 9 sec CHANGE SET Revision b4994c307ce86b52e20c4afb35ff2eaf12bf

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 48 - Fixed!

2016-03-02 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/48/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 14:26:26 + Build duration: 2 min 9 sec CHANGE SET Revision b4994c307ce86b52e20c4afb35ff2eaf12bf

Jenkins-kde-ci: sddm-kcm master kf5-qt5 » Linux,gcc - Build # 20 - Failure!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/sddm-kcm%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/20/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 14:01:10 + Build duration: 4.9 sec CHANGE SET No changes _

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 465 - Still Failing!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/465/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 13:58:25 + Build duration: 9.5 sec CHANGE SET No changes

Re: Review Request 127223: Don't emit destroyedChanged(true) twice

2016-03-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127223/#review93074 --- Ship it! Ship It! - Marco Martin On Feb. 29, 2016, 4:19

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 47 - Still Failing!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/47/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 13:42:15 + Build duration: 1 min 1 sec CHANGE SET Revision 3ef03c7ff118ae738dcdb1c09244947bbbad

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 464 - Still Failing!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/464/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 13:30:30 + Build duration: 6.7 sec CHANGE SET No changes

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 463 - Still Failing!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/463/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 13:24:17 + Build duration: 46 sec CHANGE SET Revision cc5ac26687df8b29e6c8c7f9266b2caa1eb

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 462 - Still Failing!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/462/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 13:17:45 + Build duration: 6 min 22 sec CHANGE SET Revision 4abb289daf5dcc8774affc1c99725

[Differential] [Closed] D904: [Baloo Runner] Allow opening parent folder

2016-03-02 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa18be0a6e61a: [Baloo Runner] Allow opening parent folder (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D904?vs=2199&id=2518#toc REPOSITORY rPLASMAWORKSPACE

[Differential] [Accepted] D904: [Baloo Runner] Allow opening parent folder

2016-03-02 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D904 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broul

Review Request 127259: Immediately close submenus when mouse overing the parent menu

2016-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127259/ --- Review request for Plasma. Repository: breeze Description --- Curr

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 461 - Failure!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/461/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 12:34:30 + Build duration: 11 sec CHANGE SET No changes _

Re: Plasma 5.5.5 tars are up

2016-03-02 Thread Jonathan Riddell
Another update i'm afraid to fix this issue with the systray plasma-workspace;Plasma/5.5;42849c35780577cd9c7bd248b3086ebdfcd965df;plasma-workspace-5.5.5.tar.xz;bed1e65d878b963dbbb85129c206dc70db71461de29c19e95b6053c9c4fe7b26 http://download.kde.org/stable/plasma/5.5.5/plasma-workspace-5.5.5.2.tar

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 46 - Failure!

2016-03-02 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/46/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 02 Mar 2016 12:33:45 + Build duration: 20 sec CHANGE SET Revision 33c455641a3aed14b31023978e898bfdfab85019

Re: Review Request 127258: drkonqi: Fix build with kcoreaddons < 5.20

2016-03-02 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127258/ --- (Updated March 2, 2016, 1:34 p.m.) Status -- This change has been ma

Re: Review Request 127257: about-distro: Fix build with kcoreaddons < 5.20

2016-03-02 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127257/ --- (Updated March 2, 2016, 12:33 p.m.) Status -- This change has been m

Re: Review Request 127257: about-distro: Fix build with kcoreaddons < 5.20

2016-03-02 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127257/#review93070 --- Ship it! Ship It! - Martin Gräßlin On March 2, 2016, 1:

Re: Review Request 127257: about-distro: Fix build with kcoreaddons < 5.20

2016-03-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127257/#review93069 --- Ship it! Ship It! - Marco Martin On March 2, 2016, 12:2

Re: Review Request 127258: drkonqi: Fix build with kcoreaddons < 5.20

2016-03-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127258/#review93068 --- Ship it! Ship It! - Marco Martin On March 2, 2016, 12:2

Review Request 127258: drkonqi: Fix build with kcoreaddons < 5.20

2016-03-02 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127258/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Moving Breeze lookandfeel to breeze repository

2016-03-02 Thread Martin Graesslin
On Wednesday, March 2, 2016 1:01:27 PM CET Aleix Pol wrote: > On Wed, Mar 2, 2016 at 10:14 AM, Marco Martin wrote: > > On Wednesday 02 March 2016 02:06:52 Aleix Pol wrote: > >> It would also solve my little issue with xdg-app, although if you know > >> of another way to fix this, I'll be happy to

Review Request 127257: about-distro: Fix build with kcoreaddons < 5.20

2016-03-02 Thread Heiko Becker
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127257/ --- Review request for Plasma. Repository: kinfocenter Description ---

Re: Moving Breeze lookandfeel to breeze repository

2016-03-02 Thread Aleix Pol
On Wed, Mar 2, 2016 at 10:14 AM, Marco Martin wrote: > On Wednesday 02 March 2016 02:06:52 Aleix Pol wrote: >> >> It would also solve my little issue with xdg-app, although if you know >> of another way to fix this, I'll be happy to know as well. > > I clearly see the rationale, > I'm just a bit w

Re: Review Request 127256: do not install so-symlink

2016-03-02 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127256/ --- (Updated March 2, 2016, 11:55 a.m.) Status -- This change has been m

Re: Review Request 127256: do not install so-symlink

2016-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127256/#review93065 --- Ship it! Ship It! - David Edmundson On March 2, 2016, 1

Review Request 127256: do not install so-symlink

2016-03-02 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127256/ --- Review request for Plasma and Friedrich W. H. Kossebau. Repository: kdepl

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

2016-03-02 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127252/ --- (Updated March 2, 2016, 11:30 a.m.) Status -- This change has been m

[Differential] [Closed] D1049: Fix crash on item move with manual sorting strategy

2016-03-02 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP04fc22dc6e20: Fix crash on item move with manual sorting strategy (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D104

[Differential] [Commented On] D1049: Fix crash on item move with manual sorting strategy

2016-03-02 Thread drosca (David Rosca)
drosca added a comment. To master. 5.6 branching didn't happen yet. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH tm-crash (branched from master) REVISION DETAIL https://phabricator.kde.org/D1049 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Re: Review Request 127254: Fix showing openGL compatability warning to user

2016-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127254/ --- (Updated March 2, 2016, 10:33 a.m.) Status -- This change has been m

Re: Review Request 127254: Fix showing openGL compatability warning to user

2016-03-02 Thread David Edmundson
> On March 2, 2016, 7:03 a.m., Martin Gräßlin wrote: > > shell/shellcorona.cpp, line 1722 > > > > > > qCritical or qCCritical? None of the rest of this class is. I'll try and do that for all the shell as a new

Re: Moving Breeze lookandfeel to breeze repository

2016-03-02 Thread Marco Martin
On Wednesday 02 March 2016 10:45:22 Martin Graesslin wrote: > yep that can be done. Or maybe better: > make breeze a hard dep of plasma-integration and plasma-integration a hard > dep of plasma-workspace. (Reasoning for this chain: plasma-integration sets > the look'n'feel package to breeze for Pla

[Differential] [Accepted] D1049: Fix crash on item move with manual sorting strategy

2016-03-02 Thread hein (Eike Hein)
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. What branch REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH tm-crash (branched from master) REVISION DETAIL https://phabricator.kde.org/D1049 EMAIL PREFERENCES https://phabricator.kde

[Differential] [Updated, 6 lines] D1049: Fix crash on item move with manual sorting strategy

2016-03-02 Thread drosca (David Rosca)
drosca updated this revision to Diff 2516. drosca added a comment. Typo REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1049?vs=2515&id=2516 BRANCH tm-crash (branched from master) REVISION DETAIL https://phabricator.kde.org/D1049 AFFE

[Differential] [Request, 6 lines] D1049: Fix crash on item move with manual sorting strategy

2016-03-02 Thread drosca (David Rosca)
drosca created this revision. drosca added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Add nullptr check for item returned from getMemberById. BUG: 358871 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH tm-crash (b

[Differential] [Closed] D948: Don't show applet handle outside of desktop

2016-03-02 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOPb65ef8797d97: Don't show applet handle outside of desktop (authored by drosca). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D948?vs=2510

Re: Moving Breeze lookandfeel to breeze repository

2016-03-02 Thread Martin Graesslin
On Wednesday, March 2, 2016 10:10:14 AM CET Marco Martin wrote: > On Wednesday 02 March 2016 08:05:51 Martin Graesslin wrote: > > I think we still need some look-n-feel package in plasma-workspace. Some > > fallback for the case that breeze is not installed. Comparable KWin ships > > one window dec

Re: Moving Breeze lookandfeel to breeze repository

2016-03-02 Thread kainz.a
> > > besides we has to guarantee the same maintainership level, breeze would > have > to become an hard dependency of plasma-workspace, otherwise we could ship a > workspace without lockscreen or sddm.. whoops > > the breeze repository works good but there is no full time maintainer as I know. an

Re: Moving Breeze lookandfeel to breeze repository

2016-03-02 Thread Marco Martin
On Wednesday 02 March 2016 02:06:52 Aleix Pol wrote: > > It would also solve my little issue with xdg-app, although if you know > of another way to fix this, I'll be happy to know as well. I clearly see the rationale, I'm just a bit worried that quite important things are in there, like the lock

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

2016-03-02 Thread Marco Martin
> On March 2, 2016, 1:13 a.m., Aleix Pol Gonzalez wrote: > > dataengines/weather/ions/wetter.com/ion_wettercom.cpp, line 718 > > > > > > Shouldn't this be i18n? > > Friedrich W. H. Kossebau wrote: > No, this

Re: Review Request 127252: Port all ion plugins away from KDELibs4Support

2016-03-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127252/#review93060 --- Ship it! Ship It! - Marco Martin On March 2, 2016, 12:5

Re: Moving Breeze lookandfeel to breeze repository

2016-03-02 Thread Marco Martin
On Wednesday 02 March 2016 08:05:51 Martin Graesslin wrote: > I think we still need some look-n-feel package in plasma-workspace. Some > fallback for the case that breeze is not installed. Comparable KWin ships > one window decoration as a fallback for breeze not being installed. in that case bree