----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127252/#review93060 -----------------------------------------------------------
Ship it! Ship It! - Marco Martin On March 2, 2016, 12:54 a.m., Friedrich W. H. Kossebau wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127252/ > ----------------------------------------------------------- > > (Updated March 2, 2016, 12:54 a.m.) > > > Review request for Plasma and Marco Martin. > > > Repository: plasma-workspace > > > Description > ------- > > Porting `KLocalizedDate(date.date()).formatDate(KLocale::DayName, > KLocale::ShortName)` needed some lookup, as `KLocale::DayName` confused me. > But it's still just the number of the day in the month, cmp. > https://code.woboq.org/kde/kdelibs/kdecore/date/kcalendarsystem.cpp.html#2160 > > I hunted that call down to > https://code.woboq.org/kde/kdelibs/kdecore/localization/klocale_kde.cpp.html#1145 > for which I consider `QLocale().toString(qlonglong)` to be an equivalent and > which also seems proper here. > Agreed? > > Other changes should be no-brainers. > > > Diffs > ----- > > dataengines/weather/ions/noaa/CMakeLists.txt 6b76c61 > dataengines/weather/ions/noaa/ion_noaa.h ea74814 > dataengines/weather/ions/noaa/ion_noaa.cpp 809f550 > dataengines/weather/ions/wetter.com/CMakeLists.txt 9b22dd4 > dataengines/weather/ions/wetter.com/ion_wettercom.cpp f4d3dad > > Diff: https://git.reviewboard.kde.org/r/127252/diff/ > > > Testing > ------- > > Tested both noaa & wettercom station, still showed correct day numbers for me. > Could not test with non-arabic number presentation locale (only assume it > should work) > > > Thanks, > > Friedrich W. H. Kossebau > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
