Re: Review Request 126877: [Milou] Expose single runner name and icon

2016-02-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126877/ --- (Updated Feb. 11, 2016, 10:45 p.m.) Status -- This change has been m

Re: ActionButton mouse area issue

2016-02-11 Thread Dirk Hohndel
> On Feb 11, 2016, at 11:57 AM, Marco Martin wrote: >> >> Somewhat unrelated... the issue with the content "behind" the handles and >> the ActionButton. I hate the idea of having a margin at the bottom (that >> basically creates another menu bar that isn't usable for the content of my >> app scr

Re: ActionButton mouse area issue

2016-02-11 Thread Marco Martin
On Thursday 11 February 2016 11:23:34 Dirk Hohndel wrote: > OK, I played with this. I have a few ideas how to make things better and > increase the likelihood that people enjoy this version: > > - make the handles see through so they don't completely obscure what's > behind +1 > - only show the

Re: ActionButton mouse area issue

2016-02-11 Thread Dirk Hohndel
On Thu, Feb 11, 2016 at 12:01:54PM +0100, Marco Martin wrote: > On Tuesday 09 February 2016 10:48:18 Dirk Hohndel wrote: > > > 2) Humans' first reaction to change is always hostility (unless they are > > > disciples of the Cult of Apple, that is). > > > > True. That said, I have now tried to use

Re: Review Request 126878: [KRunner] Show single runner name

2016-02-11 Thread Thomas Pfeiffer
> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh H

Re: Review Request 126878: [KRunner] Show single runner name

2016-02-11 Thread Kai Uwe Broulik
> On Jan. 27, 2016, 9 vorm., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/ --- (Updated Feb. 11, 2016, 5:49 p.m.) Status -- This change has been ma

Re: Review Request 126878: [KRunner] Show single runner name

2016-02-11 Thread Thomas Pfeiffer
> On Jan. 27, 2016, 9 a.m., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh H

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-11 Thread Aleix Pol Gonzalez
> On Feb. 6, 2016, 12:22 a.m., David Edmundson wrote: > > imports/activitymanager/switcherbackend.cpp, line 125 > > > > > > this isn't identical. > > > > old code would match alt+shift+tab, yours doesn't

Re: Review Request 126996: Drop usage of Qt4Support

2016-02-11 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126996/#review92261 --- Ship it! Looks ok - Ivan Čukić On Feb. 8, 2016, 2:03 a.

Re: Review Request 127024: Don't filter names if we have mimetypes

2016-02-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127024/ --- (Updated Feb. 11, 2016, 5:41 p.m.) Review request for KDE Frameworks and

Re: Review Request 126930: sddm theme: Add keyboard layout button

2016-02-11 Thread David Edmundson
> On Feb. 1, 2016, 5:57 p.m., David Edmundson wrote: > > >Btw, there is a comment saying that password input must be first child to > > >get focus (automatically when login screen is shown?), > > > > That comment is valid and it does do something. > > It's about tab order when we enter the butt

Re: ActionButton mouse area issue

2016-02-11 Thread Dirk Hohndel
> On Feb 11, 2016, at 3:01 AM, Marco Martin wrote: > > On Tuesday 09 February 2016 10:48:18 Dirk Hohndel wrote: >>> 2) Humans' first reaction to change is always hostility (unless they are >>> disciples of the Cult of Apple, that is). >> >> True. That said, I have now tried to use this for se

Re: Plasma Wayland ISO updated

2016-02-11 Thread Jonathan Riddell
Right, sorry Jonathan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Plasma Wayland ISO updated

2016-02-11 Thread Scarlett Clark
Rather than bashing us, you could perhaps ping us and let us know something is amiss? Thanks, Scarlett On Thu, Feb 11, 2016 at 5:09 AM, Jonathan Riddell wrote: > I've updated the Plasma Wayland ISO > > http://files.kde.org/snapshots/plasma-wayland-201602101746-amd64.iso > > It's using the latest

Re: Review Request 126878: [KRunner] Show single runner name

2016-02-11 Thread Kai Uwe Broulik
> On Jan. 27, 2016, 9 vorm., Vishesh Handa wrote: > > * A single runner can have multiple categories in its response. > > * I see nothing from a technical point of view in the patch. I find it > > slightly ugly, but if the usability guys (and Plasma) are fine with it, > > ship it! > > Vishesh

Plasma Wayland ISO updated

2016-02-11 Thread Jonathan Riddell
I've updated the Plasma Wayland ISO http://files.kde.org/snapshots/plasma-wayland-201602101746-amd64.iso It's using the latest packages from Kubuntu CI. But Kubuntu CI being poorly maintained many are out of date or incomplete including the rather crucial kwin so I'm not wanting to publicise it.

Re: ActionButton mouse area issue

2016-02-11 Thread Marco Martin
On Tuesday 09 February 2016 10:48:18 Dirk Hohndel wrote: > > 2) Humans' first reaction to change is always hostility (unless they are > > disciples of the Cult of Apple, that is). > > True. That said, I have now tried to use this for several weeks (after our > first conversation about this which

Re: Review Request 126930: sddm theme: Add keyboard layout button

2016-02-11 Thread David Rosca
> On Feb. 1, 2016, 5:57 p.m., David Edmundson wrote: > > >Btw, there is a comment saying that password input must be first child to > > >get focus (automatically when login screen is shown?), > > > > That comment is valid and it does do something. > > It's about tab order when we enter the butt

Re: Allow Actions in the Global Drawer to be disabled

2016-02-11 Thread Marco Martin
On Wednesday 10 February 2016 18:10:25 Dirk Hohndel wrote: > This clearly was intentionally not supported - but I'm not sure I > understand why - and I'd argue that this is a mistake. An application can > have different states where some of the menu items should be disabled (for > example, before a

Re: Allow Actions in the Global Drawer to be disabled

2016-02-11 Thread Marco Martin
On Wednesday 10 February 2016 18:10:25 Dirk Hohndel wrote: > This clearly was intentionally not supported - but I'm not sure I > understand why - and I'd argue that this is a mistake. An application can > have different states where some of the menu items should be disabled (for > example, before a

Re: Review Request 126968: Morphingpopups effect, to animate tooltips

2016-02-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126968/ --- (Updated Feb. 11, 2016, 8:52 a.m.) Review request for kwin and Plasma.