> On Feb. 1, 2016, 5:57 p.m., David Edmundson wrote: > > >Btw, there is a comment saying that password input must be first child to > > >get focus (automatically when login screen is shown?), > > > > That comment is valid and it does do something. > > It's about tab order when we enter the buttons area. > > > > I wanted password to always come after the user input bar; so pressing > > shift+tab changes user, tab is back on password. As they are the most > > important elements.
Alright, so remove the button from focus chain with `activeFocusOnTab: false` or manually change the focus order? Also, the same change should be made in lockscreen. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126930/#review91811 ----------------------------------------------------------- On Feb. 1, 2016, 10:17 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126930/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2016, 10:17 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > Show keyboard layout button in sddm theme, same as in lock screen. > > > Diffs > ----- > > lookandfeel/contents/loginmanager/Main.qml 1bbefec > lookandfeel/contents/loginmanager/dummydata/keyboard.qml PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126930/diff/ > > > Testing > ------- > > Looks & works exactly the same as in lock screen. > > Btw, there is a comment saying that password input must be first child to get > focus (automatically when login screen is shown?), but it is not true. It > works fine (in all cases = qmlscene, sddm-greeter --test-mode and in actual > sddm session) even with password input being second child. So, remove the > comment? > > > Thanks, > > David Rosca > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
