Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

> On Nov. 5, 2015, 1:41 a.m., David Edmundson wrote: > > which class is going to get the property where you write the config option, > > eventpluginmanager or daysmodel? eventpluginmanager, it should just un/load them and then tell daysmodel. - Martin ---

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

> On Nov. 5, 2015, 1:41 a.m., David Edmundson wrote: > > src/declarativeimports/calendar/calendarplugin.cpp, line 33 > > > > > > leaks > > > > why are you setting cpp ownership anyway? Yeah so I was wond

Plasma theme caches

We seem to have some showstopper breakages with the cache and the new plasma theme. Can people please try: in plasma-framework git checkout 84fc7672f628e240be4dde1ab386bf44e679cc3f make & install wipe the cache (this gets us back to a user using 5.15 effectively) restart plasmashell then checkou

Re: Review Request 125951: [calendar] Move the plugins handling to a separate class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/#review88031 --- which class is going to get the property where you write the c

Re: Review Request 125817: Add plugin system for Calendar events

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125817/#review88030 --- Ship it! Ship It! - David Edmundson On Nov. 2, 2015, 5:35

Review Request 125951: [calendar] Move the plugins handling to a separate class

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125951/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

On Nov. 4, 2015, 4:15 p.m., Marco Martin wrote: > > sorry for the post review (and in case this has been addressed for the > > ultimate commt) last commit on master should address those comments - Marco --- This is an automatically gen

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/#review88016 --- src/server/plasmawindowmanagement_interface.cpp (line 91)

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then push this if all is good. (Due to

Re: Review Request 125942: KWayland OutputManagement protocol and implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125942/ --- (Updated Nov. 4, 2015, 2:44 p.m.) Status -- This change has been mar

Re: Review Request 125942: KWayland OutputManagement protocol and implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125942/#review88011 --- Ship it! Ship It! - Martin Gräßlin On Nov. 4, 2015, 1:49 p

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then push this if all is good. (Due to

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Nov. 4, 2015, 1:51 p.m.) Status -- This change has been mar

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Oct. 23, 2015, 10:15 p.m., David Edmundson wrote: > > Bump? We have a "no huge merges freeze" on the 5th of November for 5.5 > > Dominik Haumann wrote: > Thanks for the bump, I will have some time next weekend, will go over the > reviews again and then push this if all is good. (Due to

Re: Review Request 125942: KWayland OutputManagement protocol and implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125942/ --- (Updated Nov. 4, 2015, 12:49 p.m.) Review request for kwin, Plasma and Ma

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Nov. 4, 2015, 12:21 p.m.) Status -- This change has been ma

Re: Review Request 125942: KWayland OutputManagement protocol and implementation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125942/ --- (Updated Nov. 4, 2015, 12:09 p.m.) Review request for kwin, Plasma and Ma

Re: Review Request 125942: KWayland OutputManagement protocol and implementation

> On Nov. 4, 2015, 7:55 a.m., Martin Gräßlin wrote: > > src/server/display.h, line 143 > > > > > > why removeOutputDevice? We don't have that for any other Global. We do, for Output. These should be as similar a

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/#review88007 --- Ship it! autotests/client/test_wayland_windowmanagement.cpp

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Nov. 4, 2015, 11:56 a.m.) Review request for kwin and Plasma.

Re: RFC: activity pager in kdeplasma-addons

On Tuesday 03 November 2015 21:03:54 David Edmundson wrote: > Two minor bugs: > - we still need to check which virtual desktop otherwise the previews are > off > - drag and dropping windows doesn't work thta was working, but it was adding the activity you were dropping the thumbnail to instead

Re: Review Request 125811: detect gtk engine

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125811/ --- (Updated Nov. 4, 2015, 10:29 a.m.) Status -- This change has been ma

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

> On Nov. 4, 2015, 9:14 a.m., Martin Gräßlin wrote: > > src/client/plasmawindowmodel.cpp, line 275 > > > > > > why QRectF and then toRect()? > > Marco Martin wrote: > because qml iirc knows qrectf but not qr

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/ --- (Updated Nov. 4, 2015, 9:49 a.m.) Review request for kwin and Plasma. R

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

> On Nov. 4, 2015, 8:14 a.m., Martin Gräßlin wrote: > > src/client/plasmawindowmodel.cpp, line 275 > > > > > > why QRectF and then toRect()? because qml iirc knows qrectf but not qrect - Marco --

Re: Review Request 125871: WIP: task geometries to wayland for minimize effect

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/#review87991 --- autotests/client/test_wayland_windowmanagement.cpp (line 165)