On Nov. 4, 2015, 4:15 p.m., Marco Martin wrote: > > sorry for the post review (and in case this has been addressed for the > > ultimate commt)
last commit on master should address those comments - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125871/#review88016 ----------------------------------------------------------- On Nov. 4, 2015, 12:21 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125871/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2015, 12:21 p.m.) > > > Review request for kwin and Plasma. > > > Repository: kwayland > > > Description > ------- > > this exposes the geometry of taskbar entries in plasma-windowmanagement, in > order to make the minimize effects possible. > unlike on X11, it takes relative positions and it has one geometry per panel, > making possible to have multiple taskbars working. > > however this is still not completely exposed, as internally kwin has still > only one geometry, it will need a change in kwin itself (suggestions welcome) > probably the rotocol will need also a minimizeTo function that takes the > panel as argument. > > another thing completely missing is tests: unfortunately the whole > plasma-windowmanagement doesn't have any autotest yet :/ > > > Diffs > ----- > > src/client/plasmawindowmanagement.cpp 1f9674c > src/client/plasmawindowmanagement.h abd8fa6 > autotests/client/test_wayland_windowmanagement.cpp PRE-CREATION > autotests/client/CMakeLists.txt 1556c47 > src/client/plasmawindowmodel.h 5a6aac4 > src/client/plasmawindowmodel.cpp 355ef53 > src/client/protocols/plasma-window-management.xml ca6a7cc > src/server/plasmawindowmanagement_interface.h 6ccc22e > src/server/plasmawindowmanagement_interface.cpp ad714a5 > > Diff: https://git.reviewboard.kde.org/r/125871/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
