Re: Review Request 125873: preliminar support for task geometries in wayland

2015-11-01 Thread Martin Gräßlin
> On Oct. 30, 2015, 5:52 p.m., Thomas Lübking wrote: > > shell_client.cpp, line 412 > > > > > > should the panel also be tested for being on the same screen (ie. same > > screen takes precedence over closer, but

Re: Review Request 125887: Allow to build ProcessUI without QtWebKitWidgets

2015-11-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125887/#review87844 --- > clicking on Detailed Memory Information from context menu ju

Re: Review Request 125886: drkonqi: Drop KF5::WebKit dependency

2015-11-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125886/#review87843 --- Ship it! Nice work and much less impact than I would have exp

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-11-01 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/ --- (Updated Nov. 2, 2015, 1:14 p.m.) Review request for Plasma, David Edmund

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-11-01 Thread Bhushan Shah
> On Nov. 2, 2015, 1:08 p.m., Martin Gräßlin wrote: > > ksmserver/config-ksmserver.h.cmake, line 2 > > > > > > are you sure that one is not needed by ksmserver? Oops, it is needed by ksmserver but not screenlocker

Re: Review Request 125892: [lockscreen] Make it possible to build kscreenlocker without ksmserver

2015-11-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125892/#review87841 --- ksmserver/config-ksmserver.h.cmake

Re: Review Request 125916: [kcm icons] Take into account device pixel ratio for icon preview

2015-11-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125916/#review87833 --- kcms/icons/iconthemes.cpp (line 440)

Review Request 125916: [kcm icons] Take into account device pixel ratio for icon preview

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125916/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125913/ --- (Updated Nov. 1, 2015, 4:32 nachm.) Status -- This change has been d

Re: Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125913/#review87811 --- This isn't good enough because: - The C++ code calculates per-

Re: Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread Kai Uwe Broulik
> On Nov. 1, 2015, 3:42 nachm., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 319 > > > > > > you're caching, but never calling update() manually when the text > > changes Wh

Re: Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125913/#review87806 --- applets/taskmanager/package/contents/ui/Task.qml (line 319) <

Re: Review Request 125848: [kscreenlocker_greet] Fix QML fallback

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125848/ --- (Updated Nov. 1, 2015, 3:30 p.m.) Status -- This change has been mar

Review Request 125913: [Task Manager] Use QtGraphicalEffects for label fade out

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125913/ --- Review request for Plasma. Bugs: 346050 https://bugs.kde.org/show_bug

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/ --- (Updated Nov. 1, 2015, 2:26 p.m.) Review request for Plasma. Repository

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/#review87801 --- > Remove expression for interactive as it doesn't work with Sc

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/ --- (Updated Nov. 1, 2015, 2:06 p.m.) Review request for Plasma. Changes --

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread David Rosca
> On Nov. 1, 2015, 1:25 p.m., Kai Uwe Broulik wrote: > > > One thing that would be great is to allow vertical wheel scrolling > > > > That should work with PlasmaExtras.ScrollArea, if you can only scroll > > horizontally. It doesn't work (as it is with current diff) - David ---

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/ --- (Updated Nov. 1, 2015, 1:56 p.m.) Review request for Plasma. Changes --

Re: Review Request 125898: [Clipboard plasmoid] Fade out text where buttons are

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125898/ --- (Updated Nov. 1, 2015, 1:35 nachm.) Review request for Plasma, KDE Usabil

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/#review87798 --- > One thing that would be great is to allow vertical wheel scr

Re: Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/#review87797 --- applets/taskmanager/package/contents/ui/ToolTipDelegate.qml (

Re: Review Request 125896: [desktopcontainment] Clip applet container while resizing it

2015-11-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125896/ --- (Updated Nov. 1, 2015, 1:19 p.m.) Status -- This change has been mar

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Rainer Dorsch
On Sunday 01 November 2015 12:35:54 Luca Beltrame wrote: > In data domenica 1 novembre 2015 12:31:07 CET, Rainer Dorsch ha scritto: > > I spent quite some time with the path for the iconsthat was to root > > cause why I started hacking the plasmoid. Any hint there would be helpful. > > I'm not

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Luca Beltrame
In data domenica 1 novembre 2015 12:31:07 CET, Rainer Dorsch ha scritto: > I spent quite some time with the path for the iconsthat was to root > cause why I started hacking the plasmoid. Any hint there would be helpful. I'm not sure unfortunately, it's been so long that my memory is quite haz

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Rainer Dorsch
On Sunday 01 November 2015 12:22:10 Luca Beltrame wrote: > In data domenica 1 novembre 2015 12:08:28 CET, Rainer Dorsch ha scritto: > > I thought providing the full source for reference might be useful: > > http://netcup.bokomoko.de/~rd/steckdose-plasma.tgz > > A few remarks: > > - I don't think

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Luca Beltrame
In data domenica 1 novembre 2015 12:08:28 CET, Rainer Dorsch ha scritto: > I thought providing the full source for reference might be useful: > http://netcup.bokomoko.de/~rd/steckdose-plasma.tgz A few remarks: - I don't think you need to provide the full path to icons, IIRC there's a way to get

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Rainer Dorsch
Hi Luca, On Sunday 01 November 2015 12:05:21 Luca Beltrame wrote: > In data domenica 1 novembre 2015 11:57:54 CET, Rainer Dorsch ha scritto: > > Hello Rainer, > > > http://doc.qt.io/qt-5/qabstractbutton.html#iconSize-prop > > The reason for the exception lies in the Qt version you are referenci

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Rainer Dorsch
On Sunday 01 November 2015 11:57:54 Rainer Dorsch wrote: > Oh, yes. The setIconSize() triggers the exception. That is the main reason, > why I cannot use it. I thought providing the full source for reference might be useful: http://netcup.bokomoko.de/~rd/steckdose-plasma.tgz Rainer -- Rainer

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Luca Beltrame
In data domenica 1 novembre 2015 11:57:54 CET, Rainer Dorsch ha scritto: Hello Rainer, > http://doc.qt.io/qt-5/qabstractbutton.html#iconSize-prop The reason for the exception lies in the Qt version you are referencing: Qt 5. Plasma 4.11.x and the Python bindings you are using are based on Qt 4,

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Rainer Dorsch
Hi Luca, On Sunday 01 November 2015 11:38:43 Luca Beltrame wrote: > In data domenica 1 novembre 2015 11:15:21 CET, Rainer Dorsch ha scritto: > > Hello, > > for the record, you're talking about Python plasmoids for Plasma 4.11.x, > correct? yes, that is correct. > > > AttributeError: 'PushButt

Review Request 125908: taskmanager: Make the windows in tooltip scrollable

2015-11-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125908/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: On/Off-Switch with QPushButton

2015-11-01 Thread Luca Beltrame
In data domenica 1 novembre 2015 11:15:21 CET, Rainer Dorsch ha scritto: Hello, for the record, you're talking about Python plasmoids for Plasma 4.11.x, correct? > AttributeError: 'PushButton' object has no attribute 'setIconSize' > Interesting enough the size issue is then gone... Is setIconS

On/Off-Switch with QPushButton

2015-11-01 Thread Rainer Dorsch
Hello, I wrote a plasmoid a number of QPushButtons with an (svg) QIcon each. Every button controls a switch which has an "on" and an "off" state. The button is used to control and show the state of the switch. Works nicely, my current implementation has two icons which it sets to signal the st