> On Nov. 1, 2015, 3:42 nachm., David Edmundson wrote: > > applets/taskmanager/package/contents/ui/Task.qml, line 319 > > <https://git.reviewboard.kde.org/r/125913/diff/1/?file=414199#file414199line319> > > > > you're caching, but never calling update() manually when the text > > changes
When text changes it updates automatically. The documentation doesn't mention a "update()" at all. >From what I can tell the "cache" property just means "don't calculate it again >on every render pass" rather than "never update it again". - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125913/#review87806 ----------------------------------------------------------- On Nov. 1, 2015, 3:13 nachm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125913/ > ----------------------------------------------------------- > > (Updated Nov. 1, 2015, 3:13 nachm.) > > > Review request for Plasma. > > > Bugs: 346050 > https://bugs.kde.org/show_bug.cgi?id=346050 > > > Repository: plasma-desktop > > > Description > ------- > > This removes the custom TextLabel and uses an OpacityMask to fade out the > label. > > > Diffs > ----- > > applets/taskmanager/CMakeLists.txt 3c94cb7 > applets/taskmanager/package/contents/ui/Task.qml 9350481 > applets/taskmanager/plugin/taskmanagerplugin.cpp 1be1fed > applets/taskmanager/plugin/textlabel.h f5f6de2 > applets/taskmanager/plugin/textlabel.cpp f916384 > > Diff: https://git.reviewboard.kde.org/r/125913/diff/ > > > Testing > ------- > > Label is faded out on regular entries and in popup when gets too wide. When > gets too narrow label is properly hidden, launchers work fine, too. But there > are probably many other usecases and scenarios I didn't know/test. > > Also fixes task manager label with QT_DEVICE_PIXELRATIO > 1 (if we were to > enable that) > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
