Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-12 Thread David Kahles
> On Oct. 13, 2015, 1:08 a.m., David Edmundson wrote: > > src/kcm/package/contents/ui/VolumeSlider.qml, line 86 > > > > > > I don't understand what this line is doing > > > > if we do block wheel events c

Review Request 125618: Fixes to KameraConfigDialog

2015-10-12 Thread Christian Butcher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125618/ --- Review request for KDE Graphics, Plasma and Marcus Meissner. Repository:

Re: Review Request 125089: Fix changing volume with scrolling on high resolution touchpad

2015-10-12 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125089/#review86770 --- I can confirm it works with my touchpad. Thanks for working on

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/#review86769 --- applet/contents/ui/ListItemBase.qml (line 203)

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread Thomas Pfeiffer
On Oct. 12, 2015, 1:36 p.m., Marco Martin wrote: > > could we use if (id==0) rather than introducing new signals in p-f? > > Marco Martin wrote: > looking at it, (and trying a patch that ended up very ugly and not really > working) at the moment on plasma5 layout templates can only work for

Re: HIG and components API

2015-10-12 Thread Thomas Pfeiffer
On Friday 09 October 2015 18:00:18 Marco Martin wrote: > On Thursday 08 October 2015, Aleix Pol wrote: > > > * could some content for the global drawer be there by default? do we > > > leave a blank slate? even the hig examples are very heterogeneous > > > https://techbase.kde.org/Projects/Usabilit

Re: HIG and components API

2015-10-12 Thread Thomas Pfeiffer
On Monday 12 October 2015 11:33:07 Marco Martin wrote: > That's another reason why I think our higs and components shouldn't be that > different from something that could work on Android, because either > developers will use them for one app port that will work on both plasma > mobile and android,

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread Rex Dieter
> On Oct. 12, 2015, 5:11 p.m., Hrvoje Senjan wrote: > > quick search on lxr.kde.org shows there are more uses of that interface, so > > changing the name now won't be easy (or recommended IMO) OK, I'll revoke this request, and got with dropping kuiserver bits from kde-runtime distro/deployment

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125610/ --- (Updated Oct. 12, 2015, 5:24 p.m.) Status -- This change has been di

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125610/#review86735 --- quick search on lxr.kde.org shows there are more uses of that

Re: Review Request 125088: Allow to change volume with mouse wheel in kcm

2015-10-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125088/ --- (Updated Oct. 12, 2015, 5:06 p.m.) Review request for Plasma and Harald S

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread David Edmundson
> On Oct. 12, 2015, 4:58 p.m., David Edmundson wrote: > > won't this mean kdelibs4 progress notifications won't show up in plasma5? > > Rex Dieter wrote: > Definite maybe, like I said, I'm not privy to exactly what this is used > for. I mentioned on irc another approach, to simply drop/omi

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread Rex Dieter
> On Oct. 12, 2015, 4:58 p.m., David Edmundson wrote: > > won't this mean kdelibs4 progress notifications won't show up in plasma5? Definite maybe, like I said, I'm not privy to exactly what this is used for. I mentioned on irc another approach, to simply drop/omit kuiserver bits from kde-run

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125610/#review86731 --- the notification plasmoid used to correctly display job info f

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125610/#review86730 --- won't this mean kdelibs4 progress notifications won't show up

Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread Rex Dieter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125610/ --- Review request for Plasma. Bugs: 351500 https://bugs.kde.org/show_bug

Re: Review Request 125089: Fix changing volume with scrolling on high resolution touchpad

2015-10-12 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125089/ --- (Updated Oct. 12, 2015, 4:27 p.m.) Review request for Plasma, David Kahle

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread Marco Martin
On Oct. 12, 2015, 1:36 p.m., Marco Martin wrote: > > could we use if (id==0) rather than introducing new signals in p-f? > > Marco Martin wrote: > looking at it, (and trying a patch that ended up very ugly and not really > working) at the moment on plasma5 layout templates can only work for

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread Marco Martin
On Oct. 12, 2015, 1:36 p.m., Marco Martin wrote: > > could we use if (id==0) rather than introducing new signals in p-f? looking at it, (and trying a patch that ended up very ugly and not really working) at the moment on plasma5 layout templates can only work for panels, as layout templates fo

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread Marco Martin
> On Oct. 12, 2015, 1:53 p.m., David Edmundson wrote: > > do we want this to work for applets in the system tray ? good question.. ideally yes, and as is now it *may* work, modulo the fact that i'm not sure how to connect the sub-containment of the systray, will just have to be the usual hardc

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!

2015-10-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 12:40:14 + Build duration: 7 min 39 sec CHANGE SET Revision 88af97288c08cc71de99f986e62c5

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 206 - Fixed!

2015-10-12 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/206/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 12:40:14 + Build duration: 7 min 39 sec CHANGE SET Revision 88af97288c08cc71de99f986e62c5

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125562/#review86720 --- do we want this to work for applets in the system tray ? - Da

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread David Edmundson
> On Oct. 12, 2015, 1:36 p.m., David Edmundson wrote: > > shell/shellcorona.cpp, line 1075 > > > > > > we should export activity as a property. > > > > it's not availabe from Applet edit: on reflection

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125562/#review86554 --- +1 (save for two minor comments) shell/shellcorona.cpp (line

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread David Edmundson
> On Oct. 12, 2015, 1:01 p.m., Marco Martin wrote: > > One problem that i think it makes not really possible to use layout > > templates to doing this for containments, is that this assumes that a > > containment gets created and *then* a script is executed on it, while > > layout templates cr

Re: Review Request 125605: Resize lock screen windows if screen size changes

2015-10-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125605/#review86717 --- Ship it! Ship It! - Martin Gräßlin On Oct. 12, 2015, 1:36

Re: Review Request 125562: Default for look and feel of applets, take 2

2015-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125562/#review86714 --- One problem that i think it makes not really possible to use l

Re: Review Request 125605: Resize lock screen windows if screen size changes

2015-10-12 Thread David Edmundson
> On Oct. 12, 2015, 12:26 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 259 > > > > > > can we trust that QScreen or should we use the one of the view? > > Martin Gräßlin wr

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 205 - Unstable!

2015-10-12 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/205/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 12 Oct 2015 10:41:27 + Build duration: 17 min CHANGE SET Revision d3277e8269cee7bff5965f5969a191dd25

Re: Review Request 125605: Resize lock screen windows if screen size changes

2015-10-12 Thread Martin Gräßlin
> On Oct. 12, 2015, 2:26 p.m., Martin Gräßlin wrote: > > ksmserver/screenlocker/greeter/greeterapp.cpp, line 259 > > > > > > can we trust that QScreen or should we use the one of the view? in addition: should we

Re: Review Request 125605: Resize lock screen windows if screen size changes

2015-10-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125605/#review86708 --- ksmserver/screenlocker/greeter/greeterapp.cpp (line 259)

Review Request 125605: Resize lock screen windows if screen size changes

2015-10-12 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125605/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Minutes Monday Plasma Hangout

2015-10-12 Thread Bhushan Shah
On Mon, Oct 12, 2015 at 4:11 PM, Marco Martin wrote: > Present: David, Jens, Martin G, Marco Bhushan - Released IMG9 for mobile with newer frameworks and plasma - Trying out firefox on the plasma mobile : http://i.imgur.com/wcsYQnQ.png - It works very well, have some profile hacks for screen reso

Weekly bug bashing session

2015-10-12 Thread Marco Martin
Hi all, Last week David and me tried a simple experiment, of taking a couple of hours and going together trough a single bugzilla component under plasmashell (systemtray in this case) and look one by one seeing what looks quickly fixable, what may be duplicated, what unconfirmed may be confirmed

Minutes Monday Plasma Hangout

2015-10-12 Thread Marco Martin
Present: David, Jens, Martin G, Marco date: Monday 12 October 2015 David - fixed bugs - windows can cover is back - wednesday afternoon every week debugging session Jens - doing videos of unknown side features Martin G - been at Qt World Summit - kate autocompletion works on wayland - opengl mo

Re: Review Request 124267: Use KWin to lower/raiser panel in windows can cover mode with edge activation

2015-10-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124267/#review86700 --- Looks good to me: +1 - Martin Gräßlin On Oct. 12, 2015, 12:

Re: HIG and components API

2015-10-12 Thread Marco Martin
On Wednesday 07 October 2015, Alex L. wrote: > In data mercoledì 7 ottobre 2015 14:53:32, Marco Martin ha scritto: > > which looks like this, i kindof like > > https://www.youtube.com/watch?v=qHHWG_Qm2ks > > If I understand well, technically the toolbar like that it's OK but > "floating buttons" n

Re: HIG and components API

2015-10-12 Thread Marco Martin
On Friday 09 October 2015, Aleix Pol wrote: > > One thing I really like about the Material ones is that even if they > provide a Button.qml component, they also provide the style for it and > base their button on the one in QtQuick.Controls. This way, one can > have code using QtQuick.Controls and

Re: sddm product in bugzilla?

2015-10-12 Thread Martin Steigerwald
Am Montag, 12. Oktober 2015, 10:10:47 CEST schrieb David Edmundson: > On Mon, Oct 12, 2015 at 8:40 AM, Martin Steigerwald > > wrote: > > Hello! > > > > I know that sddm upstream is not a KDE project, but still I wondered as I > > reported issue #509 and #510¹, which are clearly things where sddm

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125568/#review86696 --- It has been marked as submitted but it's not been pushed in pl

Re: sddm product in bugzilla?

2015-10-12 Thread David Edmundson
On Mon, Oct 12, 2015 at 8:40 AM, Martin Steigerwald wrote: > Hello! > > I know that sddm upstream is not a KDE project, but still I wondered as I > reported issue #509 and #510¹, which are clearly things where sddm > regresses > in terms of features in comparison with the former standard display

Re: KCM's and Plasma-desktop

2015-10-12 Thread Dāvis Mosāns
2015-10-09 14:30 GMT+03:00 Vishesh Handa : > On Mon, Oct 5, 2015 at 5:20 PM, Hannah von Reth wrote: >> Baloo could be useful. > > Baloo is only for linux. Windows has its own search solution far > superior to ours. > What's so superior about Windows search? To me Baloo seems superior :P I've been

Re: HIG and components API

2015-10-12 Thread Alex L.
In data mercoledì 7 ottobre 2015 14:53:32, Marco Martin ha scritto: > which looks like this, i kindof like > https://www.youtube.com/watch?v=qHHWG_Qm2ks If I understand well, technically the toolbar like that it's OK but "floating buttons" not. To be sure we have the same concept of "floating but

Re: Review Request 125433: kcm_kamera: Double calls to load() lead to strange scrollbars after saving a change

2015-10-12 Thread Marcus Meissner
On Thu, Oct 08, 2015 at 07:22:49AM -, Christian Butcher wrote: > > > > On Sept. 28, 2015, 7:02 a.m., Marcus Meissner wrote: > > > according to git blame I added this to help autoload the camera list ... > > > although I have not much recall of this :/ > > > > Christian Butcher wrote: > >

Re: Review Request 125568: Revised Breeze Plasma theme for 5.5.

2015-10-12 Thread Alex L.
In data venerdì 9 ottobre 2015 23:19:51, Uri Herrera ha scritto: > But that's exactly what you should be doing, use icons depending on the > context, just because an icon "works" doesn't mean, like at all, that it > should be used everywhere, regardless of whether is an > action/status/category, th

Re: SoK Plasmoids

2015-10-12 Thread Marco Martin
On Saturday 10 October 2015, kainz.a wrote: > > So long story short, can I open some plasmoid tasks where the existing > plasmoids will get an simple rework and in an second step start with > some new plasmoids. I'm not sure adding new stuff is a good idea, save for the still existing gaping hol

sddm product in bugzilla?

2015-10-12 Thread Martin Steigerwald
Hello! I know that sddm upstream is not a KDE project, but still I wondered as I reported issue #509 and #510¹, which are clearly things where sddm regresses in terms of features in comparison with the former standard display manager for Plasma kdm, at least whether to allow reporting issues wi