[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #14 from Weng Xuetian --- (In reply to Igor Poboiko from comment #11) > BTW, another issue related to animation routine: all keypresses that are > happening during animation are ignored (due to the very same check it didn't > update the cach

[Powerdevil] [Bug 346456] When screen turn off automatically, it will turn black twice.

2015-09-11 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=346456 Weng Xuetian changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In|

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=350676 Weng Xuetian changed: What|Removed |Added Resolution|--- |FIXED Version Fixed In|

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #12 from Weng Xuetian --- (In reply to Kai Uwe Broulik from comment #10) > Could it be that you're using EGL? Does the highlight in eg. Kickoff also > only update every second item? If so, that's a driver issue. So glad to learn that here a

Re: Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-11 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/#review85224 --- Is there any disadvantage to using Icon-only task manager and

Re: Review Request 125019: [kicker] make dashboard icon size scalable

2015-09-11 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125019/ --- (Updated 9月 12, 2015, 9:41 a.m.) Review request for Plasma. Changes ---

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Igor Poboiko
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #11 from Igor Poboiko --- (In reply to Kai Uwe Broulik from comment #10) > Could it be that you're using EGL? Does the highlight in eg. Kickoff also > only update every second item? If so, that's a driver issue. Yeah, same in kickoff. Thank

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #10 from Kai Uwe Broulik --- Could it be that you're using EGL? Does the highlight in eg. Kickoff also only update every second item? If so, that's a driver issue. -- You are receiving this mail because: You are the assignee for the bug. _

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Igor Poboiko
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #9 from Igor Poboiko --- Funny, although after fixing this brightness gets updated correctly, OSD doesn't. It still gets updated each second keypress, but seems like it is another issue somewhere in OSD/QML code. Somehow ProgressBar value (w

Re: Review Request 125178: Don't fade animate icon in plasma tooltips

2015-09-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125178/#review85219 --- heh, I tried to fix that for ages nut couldn't figure that out

Review Request 125178: Don't fade animate icon in plasma tooltips

2015-09-11 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125178/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-11 Thread Takahiro Hashimoto
> On 9月 11, 2015, 8:12 p.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) > > Eike Hein wrote: > Go ahead! > > Takahiro Hashimoto wrote: > Thank you so much!! :

Review Request 125174: Plasma 5 Quicklaunch applet

2015-09-11 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125174/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 125159: Accept proposed drop action in panel and desktop

2015-09-11 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125159/ --- (Updated Sept. 11, 2015, 6:17 p.m.) Status -- This change has been m

Re: Review Request 125118: [Icon widget] support dropping onto folder

2015-09-11 Thread Marco Martin
> On Sept. 10, 2015, 6:54 p.m., Emmanuel Pescosta wrote: > > applets/icon/plugin/icon_p.cpp, line 114 > > > > > > A DeclarativeDropEvent::toQDropEvent() method maybe? is the whole class that is not public, being

Re: Review Request 125159: Accept proposed drop action in panel and desktop

2015-09-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125159/#review85210 --- Ship it! Ship It! - Marco Martin On Sept. 11, 2015, 3:42 p

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/#review85209 --- Ship it! Ship It! - Marco Martin On Sept. 11, 2015, 5:07 p

Re: Review Request 125091: Speedup finding the property change signals

2015-09-11 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125091/ --- (Updated Sept. 11, 2015, 7:12 p.m.) Status -- This change has been m

Re: Review Request 125038: Make SourceModel writeable

2015-09-11 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/ --- (Updated Sept. 11, 2015, 7:11 p.m.) Status -- This change has been m

Re: Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/ --- (Updated Sept. 11, 2015, 7:07 p.m.) Review request for KDE Frameworks and

Review Request 125171: Remove the documentation of the non-existent parameter "desktop"

2015-09-11 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125171/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/ --- (Updated Sept. 11, 2015, 3:59 p.m.) Review request for Plasma and andreas

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125135/ --- (Updated Sept. 11, 2015, 3:57 p.m.) Review request for Plasma and andreas

Re: Review Request 125028: Monitor for the clock changes from the kernel

2015-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125028/ --- (Updated Sept. 11, 2015, 3:54 p.m.) Status -- This change has been m

Review Request 125159: Accept proposed drop action in panel and desktop

2015-09-11 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125159/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread andreas kainz
> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably t

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread Martin Klapetek
> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably to

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread andreas kainz
> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably t

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread Martin Klapetek
> On Sept. 10, 2015, 1:43 p.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably to

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-11 Thread Eike Hein
> On Sept. 11, 2015, 11:12 a.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) > > Eike Hein wrote: > Go ahead! > > Takahiro Hashimoto wrote: > Thank you so much

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread Marco Martin
> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably t

Re: Review Request 125135: show screenshots in the widget explorer

2015-09-11 Thread andreas kainz
> On Sept. 10, 2015, 11:43 a.m., Kai Uwe Broulik wrote: > > First of all, I like the idea. > > > > However, I think we should go with PNG with alpha channel rather than > > having the Breeze default wallpaper there which changes every release. > > Showing a fully working Plasmoid is probably t

Re: Review Request 125111: Change system settings toolbar

2015-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125111/ --- (Updated Sept. 11, 2015, 2:01 p.m.) Status -- This change has been m

Re: Review Request 125111: Change system settings toolbar

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125111/#review85187 --- +1 - Martin Gräßlin On Sept. 9, 2015, 12:59 a.m., David Edm

Re: Review Request 125111: Change system settings toolbar

2015-09-11 Thread andreas kainz
> On Sept. 8, 2015, 11:08 p.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? > > andreas kainz wrote: > Hi the help icon was changed yesterday in master (by me without > reviewboard) so help use the right icon. > > M

Re: Review Request 125111: Change system settings toolbar

2015-09-11 Thread andreas kainz
> On Sept. 8, 2015, 11:08 p.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? > > andreas kainz wrote: > Hi the help icon was changed yesterday in master (by me without > reviewboard) so help use the right icon. > > M

Re: Review Request 125111: Change system settings toolbar

2015-09-11 Thread David Edmundson
> On Sept. 8, 2015, 11:08 p.m., Martin Klapetek wrote: > > +1 for the icon change, but I dunno, "Help" not being the last thing looks > > strange...? > > andreas kainz wrote: > Hi the help icon was changed yesterday in master (by me without > reviewboard) so help use the right icon. > > M

Re: Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

2015-09-11 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124877/ --- (Updated 9月 11, 2015, 10:01 p.m.) Review request for Plasma. Changes --

Re: Review Request 125161: Make the classic module optional and thus the dependencie to khtml.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125161/ --- (Updated Sept. 11, 2015, 12:58 p.m.) Status -- This change has been

Re: Review Request 125161: Make the classic module optional and thus the dependencie to khtml.

2015-09-11 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125161/#review85177 --- Ship it! Looks fine to me. - Ben Cooksley On Sept. 11, 201

Re: Review Request 125161: Make the classic module optional and thus the dependencie to khtml.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125161/#review85176 --- +1 - Martin Gräßlin On Sept. 11, 2015, 2:10 p.m., Patrick v

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-11 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/ --- (Updated Sept. 11, 2015, 12:46 p.m.) Status -- This change has been

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-11 Thread Takahiro Hashimoto
> On 9月 11, 2015, 8:12 p.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) > > Eike Hein wrote: > Go ahead! Thank you so much!! :) - Takahiro ---

Review Request 125161: Make the classic module optional and thus the dependencie to khtml.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125161/ --- Review request for Plasma. Repository: systemsettings Description -

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-11 Thread Eike Hein
> On Sept. 11, 2015, 11:12 a.m., Takahiro Hashimoto wrote: > > I finally have had rights to commit KDE repos. If all are OK (already > > flaged 'Ship it' I understand), I'd like to commit it by myself:) Go ahead! - Eike --- This is an

Re: Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

2015-09-11 Thread Takahiro Hashimoto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125012/#review85170 --- I finally have had rights to commit KDE repos. If all are OK

Re: Review Request 125038: Make SourceModel writeable

2015-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125038/#review85169 --- Ship it! Given no-one else has commented... Ship it - David

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #8 from Weng Xuetian --- https://git.reviewboard.kde.org/r/125156/ -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org htt

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Weng Xuetian
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #7 from Weng Xuetian --- Well, imho, such animation is more or less the standard behavior in real world (Windows, Android, ...). Though from reading our implementation there are definitely some issue here. stop will not reset the progress,

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85164 --- next time please squash the whitespace fix together with the o

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/ --- (Updated Sept. 11, 2015, 9:50 a.m.) Status -- This change has been m

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
> On Sept. 11, 2015, 11:40 a.m., Martin Gräßlin wrote: > > sorry clicked the wrong button. I assume you verified that kdelibs4support > > is only needed in the one sub directory? > > Patrick von Reth wrote: > Which wrong button? The ship it? > Yes I grepped the repo for kdelibs4support

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
> On Sept. 11, 2015, 9:40 vorm., Martin Gräßlin wrote: > > sorry clicked the wrong button. I assume you verified that kdelibs4support > > is only needed in the one sub directory? Which wrong button? The ship it? Yes I grepped the repo for kdelibs4support and Su. - Patrick --

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85161 --- Ship it! sorry clicked the wrong button. I assume you verifie

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85160 --- CMakeLists.txt (line 79)

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/ --- (Updated Sept. 11, 2015, 9:34 vorm.) Review request for Plasma. Reposit

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Igor Poboiko
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #6 from Igor Poboiko --- Created attachment 94505 --> https://bugs.kde.org/attachment.cgi?id=94505&action=edit patch that removes QPropertyAnimation I would prefer removing animation routine at all. I mean, why do we need it? It just make

Re: Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/#review85159 --- CMakeLists.txt (line 44)

Review Request 125155: Update dependencies and fix build on Windows.

2015-09-11 Thread Patrick von Reth
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125155/ --- Review request for Plasma. Repository: kde-cli-tools Description --

[Powerdevil] [Bug 350676] Need to press key twice to decrease brightness

2015-09-11 Thread Igor Poboiko
https://bugs.kde.org/show_bug.cgi?id=350676 --- Comment #5 from Igor Poboiko --- I did some investigation on this problem by adding few debug lines, and I nailed it. What is happening here is following: 1. User presses DecreaseBrightness button first time. - UPower backend starts an QPropertyAni