Re: Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-26 Thread Martin Gräßlin
> On Aug. 26, 2015, 8:51 p.m., Kai Uwe Broulik wrote: > > Just place the > > > > anchors { > > horizontalCenter: parent.horizontalCenter > > bottom: parent.bottom > > } > > > > into the Loader to ensure the OSD is correctly positioned. I think the OSD > > should be

Re: Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/ --- (Updated Aug. 27, 2015, 8:36 a.m.) Review request for Plasma. Changes -

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 147 - Failure!

2015-08-26 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/147/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 27 Aug 2015 05:23:44 + Build duration: 10 min CHANGE SET Revision b5d7f757c86668fb8184c2b4bc38b90adcc59

Re: Review Request 124937: Add comment/description to keyboard kded module

2015-08-26 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 27, 2015, 5:23 a.m.) Status -- This change has been ma

Review Request 124945: [panelconfiguration] Provide press feedback for Edge/SizeHandle

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124945/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 124944: Fix a crash.

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/ --- (Updated Aug. 26, 2015, 11:36 p.m.) Status -- This change has been m

Re: Review Request 124944: Fix a crash.

2015-08-26 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/#review84436 --- Ship it! Ship It! - Martin Klapetek On Aug. 27, 2015, 1:03

Review Request 124944: Fix a crash.

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124944/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 124937: Add comment/description to keyboard kded module

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/#review84430 --- Ship it! Ship It! - David Edmundson On Aug. 26, 2015, 5:41

Review Request 124938: [panelconfiguration] Provide press feedback for Edge/SizeHandle

2015-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124938/ --- Review request for Plasma. Repository: plasma-desktop Description -

[Powerdevil] [Bug 351822] New: [Thinkpad T440] [kubuntu] (False?) notification of the removal of power when the battery has finished charging or has reached the threshold

2015-08-26 Thread ndrgrimm
https://bugs.kde.org/show_bug.cgi?id=351822 Bug ID: 351822 Summary: [Thinkpad T440] [kubuntu] (False?) notification of the removal of power when the battery has finished charging or has reached the threshold Product: Powerde

Re: Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/#review84417 --- Just place the anchors { horizontalCenter: parent

Re: Review Request 124923: Plasma 5 color picker plasmoid

2015-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124923/ --- (Updated Aug. 26, 2015, 6:07 nachm.) Review request for Plasma and KDE Us

Re: Review Request 124923: Plasma 5 color picker plasmoid

2015-08-26 Thread Thomas Pfeiffer
> On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote: > > Great work! > > Two points: > > 1. The two icons in the Plasmoid look like they're two separate Plasmoids, > > which is confusing. They should be more visually connected (we're still > > brainstorming ideas for how to do this in the VDG)

Re: Review Request 124937: Add comment/description to keyboard kded module

2015-08-26 Thread Ragnar Thomsen
> On Aug. 26, 2015, 7:27 p.m., David Edmundson wrote: > > kcms/keyboard/keyboard.desktop, line 76 > > > > > > Yes we definitely need a comment ++ > > > > Not so sure of the text, the kded is needed to han

Re: Review Request 124937: Add comment/description to keyboard kded module

2015-08-26 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 26, 2015, 7:41 p.m.) Review request for Plasma. Changes -

Re: Review Request 124937: Add comment/description to keyboard kded module

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/#review84414 --- kcms/keyboard/keyboard.desktop (line 76)

Re: Review Request 124937: Add comment/description to keyboard kded module

2015-08-26 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- (Updated Aug. 26, 2015, 7:08 p.m.) Review request for Plasma. Changes -

Review Request 124937: Add comment/description to keyboard kded module

2015-08-26 Thread Ragnar Thomsen
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change

2015-08-26 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124785/ --- (Updated Aug. 26, 2015, 4:02 p.m.) Status -- This change has been ma

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-26 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124786/ --- (Updated Aug. 26, 2015, 4:02 p.m.) Status -- This change has been ma

Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-26 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/ --- (Updated Aug. 26, 2015, 4:02 p.m.) Status -- This change has been ma

Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/#review84410 --- Ship it! - David Edmundson On Aug. 26, 2015, 3:52 p.m., Dav

Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124785/#review84409 --- Ship it! Ship It! - David Edmundson On Aug. 17, 2015, 9:31

Re: Review Request 124786: [Panelconfig] Add more / fix constraints in the position/size handles

2015-08-26 Thread David Kahles
> On Aug. 24, 2015, 2:06 a.m., Marco Martin wrote: > > the middle thing was done in order to not cross the handles, but the other > > check you afded should prevent this anyways That was done by `offsetHandle.position + units.gridUnit * 3` in minimumPosition: Math.max(offsetHandle.position

Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-26 Thread David Kahles
> On Aug. 22, 2015, 11:31 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/panelconfiguration/SliderHandle.qml, > > line 48 > > > > > > this doesn't entirely make sense. > > > > >

Re: Review Request 124785: [Panelconfig] Reset the panel offset on alignment change

2015-08-26 Thread David Kahles
> On Aug. 22, 2015, 11:42 p.m., David Edmundson wrote: > > desktoppackage/contents/configuration/panelconfiguration/Ruler.qml, line 48 > > > > > > PanelConfiguration.qml has this > > > > Connections { > >

Re: Review Request 124782: [Panelconfig] Add some comments and rename the max/min value variable

2015-08-26 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124782/ --- (Updated Aug. 26, 2015, 5:52 p.m.) Review request for Plasma. Changes -

5.5 Kickoff meeting minutes

2015-08-26 Thread Jonathan Riddell
Present: mgraesslin, notmart, andreas_k, sebas, bshah, d_ed, jensrout, mck182, kbroulik Schedule: ok final on Thuesday tag -> Tuesday release, beta with tag/tar/release on Thursday 2 weeks before that, repo freeze 2 weeks before that 8 Dec final release date ok I can ad

Review Request 124933: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124933/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Update on screen brightness handling for Wayland

2015-08-26 Thread Sebastian Kügler
On Wednesday, August 26, 2015 09:47:11 Martin Graesslin wrote: > at Akademy we discussed some plans on how to handle screen brightness on > Wayland. Unfortunately I must say that this doesn't work at all as we > imagined > > > I had a look at what Weston is doing for brightness. It uses a forke

Re: Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124931/#review84399 --- lookandfeel/contents/lockscreen/LockScreen.qml (line 165)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 145 - Fixed!

2015-08-26 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 26 Aug 2015 10:22:56 + Build duration: 6 min 42 sec CHANGE SET Revision 1cddd74f14b5f6dd866101c5a337769

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 145 - Fixed!

2015-08-26 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/145/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 26 Aug 2015 10:22:56 + Build duration: 6 min 42 sec CHANGE SET Revision 1cddd74f14b5f6dd866101c5a337769

Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter

2015-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124931/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster

2015-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124930/ --- (Updated Aug. 26, 2015, 12:04 p.m.) Status -- This change has been d

Re: Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster

2015-08-26 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124930/#review84397 --- I can't imagine the component sharing this makes any differenc

Re: [plasma-framework] src/plasma: plasma: Fix applet actions might be nullptr

2015-08-26 Thread Christoph Feck
On Wednesday 26 August 2015 11:27:05 Leslie Zhai wrote: > Git commit 4e9b32d80d6b43ad3d1ddd47c948ad066608b052 by Leslie Zhai. > Committed on 26/08/2015 at 09:24. > Pushed by lesliezhai into branch 'master'. > > plasma: Fix applet actions might be nullptr > BUG:351777 > > M +1-1src/plasm

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-26 Thread Marco Martin
> On Aug. 25, 2015, 2:22 p.m., René J.V. Bertin wrote: > > > When built as SHARED as in the current code, libdraganddropplugin.dylib > > > gets installed to $PREFIX/share/qt5/qml/org/kde/draganddrop, but is given > > > an OS X install_name of $PREFIX/lib/libdraganddropplugin.dylib. This > > >

Review Request 124930: [screenlocker] Try to improve greeter to get it start up a little bit faster

2015-08-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124930/ --- Review request for Plasma and David Edmundson. Repository: plasma-workspa

Re: Review Request 124910: Make model param of clicked signal of var type

2015-08-26 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124910/ --- (Updated Aug. 26, 2015, 8:46 a.m.) Status -- This change has been ma

Re: Review Request 124917: [screenlocker] Start grace time when the greeter is shown

2015-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124917/#review84396 --- Ship it! Ship It! - Marco Martin On Aug. 25, 2015, 10:53 a

Re: Review Request 124910: Make model param of clicked signal of var type

2015-08-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124910/#review84395 --- Ship it! Ship It! - Marco Martin On Aug. 24, 2015, 9:43 p.

Re: Review Request 124923: Plasma 5 color picker plasmoid

2015-08-26 Thread Marco Martin
> On Aug. 25, 2015, 9:22 p.m., Thomas Pfeiffer wrote: > > Great work! > > Two points: > > 1. The two icons in the Plasmoid look like they're two separate Plasmoids, > > which is confusing. They should be more visually connected (we're still > > brainstorming ideas for how to do this in the VDG)

Re: Minutes Monday Plasma Hangout

2015-08-26 Thread Jens Reuterberg
On Monday, August 17, 2015 05:12:00 AM Jeremy Whiting wrote: > On Mon, Aug 17, 2015 at 4:42 AM, Sebastian Kügler wrote: > > Present: Bhushan, David, Jens, Kai Uwe, Martin G, Ozark, Sebastian > > Date: 17 August, 2015 > > > > Bhushan: > > - working on apps, first off comic book reader > > - Looked

Re: [kubuntu-devel] Re: git moves

2015-08-26 Thread Valentin Rusu
* Martin Klapetek [2015-08-12 12:25:27 -0400]: > On Tue, Aug 11, 2015 at 7:30 AM, Jonathan Riddell wrote: > > > On Tue, Aug 11, 2015 at 01:18:20PM +0200, Valentin Rusu wrote: > > > * Jonathan Riddell [2015-08-05 18:11:56 +0200]: > > > > > > > some changes to pkg-kde git today: > > > > > > > >

Update on screen brightness handling for Wayland

2015-08-26 Thread Martin Graesslin
Hi all, at Akademy we discussed some plans on how to handle screen brightness on Wayland. Unfortunately I must say that this doesn't work at all as we imagined :-( I had a look at what Weston is doing for brightness. It uses a forked "libbacklight" which internally interacts with the sysfs bri

Re: Review Request 124892: bug 342962: kdeclarative plugins should be built as a bundle plugin and not a shared library

2015-08-26 Thread David Faure
> On Aug. 25, 2015, 1:41 p.m., David Edmundson wrote: > > I've got both Gentoo and Arch saying this causes a major problem [1]: > > > > libdraganddropplugin.so changes to draganddropplugin.so > > in /usr/lib/qt/qml/org/kde/draganddrop > > > > and then they don't get loaded. > > > > any ideas?