> On Aug. 26, 2015, 7:27 p.m., David Edmundson wrote: > > kcms/keyboard/keyboard.desktop, line 76 > > <https://git.reviewboard.kde.org/r/124937/diff/1/?file=398806#file398806line76> > > > > Yes we definitely need a comment ++ > > > > Not so sure of the text, the kded is needed to handle and act on switch > > shortcut keys regardless of whether the setting "show icon in system tray" > > is set. We don't want people using this to hide the icon. > > > > Maybe: > > "Enables switching keyboard layout through shortcuts or system tray"
Yes, that's much better... - Ragnar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124937/#review84414 ----------------------------------------------------------- On Aug. 26, 2015, 7:41 p.m., Ragnar Thomsen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124937/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2015, 7:41 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > The desktop file for the keyboard kded module was missing the comment field. > This results in a missing description in the kded kcm. > > AFAICT from the code the keyboard kded module enables the system tray for > switching keyboard layout, so I added the comment: > `Enables system tray for changing keyboard layout` > > If the module provides other functionality, we can revise the comment. > > > Diffs > ----- > > kcms/keyboard/keyboard.desktop 43ae1f1 > > Diff: https://git.reviewboard.kde.org/r/124937/diff/ > > > Testing > ------- > > A description is now provided in the kded kcm. > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/8ac33423-4882-449d-8857-aa0ac3ccb168__keyboard-before.png > After > > https://git.reviewboard.kde.org/media/uploaded/files/2015/08/26/f16e0191-ba82-4f3d-afb6-f2f7ee80b2ae__keyboard-after.png > > > Thanks, > > Ragnar Thomsen > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
