Re: Plasma Mobile Vision, intended personas & meeting notes

2015-08-13 Thread Marco Martin
On Thursday, August 13, 2015, Sebastian Kügler wrote: > If it's OK with everybody let's declare it "final for the time being" +1 for it being final for the time being (now i'll get back being in places luckily without any pesky connectivity :p) -- Marco Martin ___

Re: Review Request 124728: Remove unused variable.

2015-08-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124728/#review83793 --- Ship it! Ship It! - David Edmundson On Aug. 13, 2015, 5:25

Re: Review Request 124730: [solid-device-automounter] Port to KF5

2015-08-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124730/#review83792 --- done the KCM. not looked at kded solid-device-automounter/kc

Re: Review Request 124509: Use small button for session combo

2015-08-13 Thread Thomas Pfeiffer
> On Aug. 4, 2015, 12:22 a.m., Thomas Pfeiffer wrote: > > Thanks for taking this up so fast! > > Let me check back with our icon designers regarding whether this is the > > best icon for that button (it always looked more like a settings icon than > > a menu icon to me). Otherwise, the button s

Re: Review Request 124586: Dismiss logout dialog when clicking outside

2015-08-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124586/ --- (Updated Aug. 13, 2015, 8:15 nachm.) Review request for Plasma. Reposit

Re: Review Request 124586: Dismiss logout dialog when clicking outside

2015-08-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124586/ --- (Updated Aug. 13, 2015, 8:15 nachm.) Review request for Plasma. Changes

Re: Review Request 124509: Use small button for session combo

2015-08-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/ --- (Updated Aug. 13, 2015, 8:09 nachm.) Review request for Plasma and KDE Us

Re: Review Request 124509: Use small button for session combo

2015-08-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/ --- (Updated Aug. 13, 2015, 8:08 nachm.) Review request for Plasma and KDE Us

Review Request 124730: [solid-device-automounter] Port to KF5

2015-08-13 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124730/ --- Review request for Plasma, Solid and Torrie Fischer. Repository: plasma-d

Review Request 124728: Remove unused variable.

2015-08-13 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124728/ --- Review request for Plasma. Repository: libksysguard Description ---

Re: Review Request 124727: Documentation for PlasmaComponents Menu

2015-08-13 Thread Leszek Lesner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/ --- (Updated Aug. 13, 2015, 12:44 p.m.) Status -- This change has been m

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-13 Thread Luca Sartorelli
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/ --- (Updated Aug. 13, 2015, 12:38 p.m.) Status -- This change has been m

Re: Review Request 124727: Documentation for PlasmaComponents Menu

2015-08-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/#review83767 --- oh RB lost my comment src/declarativeimports/plasmacomponent

Re: Review Request 124727: Documentation for PlasmaComponents Menu

2015-08-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/#review83766 --- Ship it! Ship It! - David Edmundson On Aug. 13, 2015, 11:3

Jenkins-kde-ci: plasma-workspace Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2015-08-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Aug 2015 11:52:17 + Build duration: 17 min CHANGE SET No changes JUNIT RESULTS

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-13 Thread Bhushan Shah
> On Aug. 13, 2015, 12:38 p.m., Bhushan Shah wrote: > > Do you have commit rights or you want me to commit it for you? > > Luca Sartorelli wrote: > Can you do it please, I don't have commit rigths. Thanks Submitted with http://commits.kde.org/plasma-mediacenter/4c242b2e04dbe6aaba5bd0766f2f

Review Request 124727: Documentation for PlasmaComponents Menu

2015-08-13 Thread Leszek Lesner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124727/ --- Review request for Plasma. Repository: plasma-framework Description ---

Jenkins-kde-ci: plasma-desktop Plasma-5.4 stable-kf5-qt5 » Linux,gcc - Build # 1 - Successful!

2015-08-13 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.4%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/1/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 13 Aug 2015 10:56:47 + Build duration: 15 min CHANGE SET No changes JUNIT RESULTS N

Re: Plasma Mobile Vision, intended personas & meeting notes

2015-08-13 Thread Sebastian Kügler
So it seems the general consensus is that it's good, there were only different opinions about the "unlike Android" bit, so I've removed that now. Thomas is right that this doesn't warrant different versions around, and I'd rather have one clear statement which is generally agreed on than differe

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-13 Thread Luca Sartorelli
> On Aug. 13, 2015, 7:08 a.m., Bhushan Shah wrote: > > Do you have commit rights or you want me to commit it for you? Can you do it please, I don't have commit rigths. Thanks - Luca --- This is an automatically generated e-mail. To repl

Re: Review Request 124647: Cmake fail to parse proper taglib version

2015-08-13 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83759 --- Do you have commit rights or you want me to commit it for you?