> On Aug. 13, 2015, 12:38 p.m., Bhushan Shah wrote: > > Do you have commit rights or you want me to commit it for you? > > Luca Sartorelli wrote: > Can you do it please, I don't have commit rigths. Thanks
Submitted with http://commits.kde.org/plasma-mediacenter/4c242b2e04dbe6aaba5bd0766f2f5c9ebb8b23b3 Forgot to add REVIEW tag in commit message, can you close this review? - Bhushan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124647/#review83759 ----------------------------------------------------------- On Aug. 7, 2015, 2:31 p.m., Luca Sartorelli wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124647/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2015, 2:31 p.m.) > > > Review request for Plasma. > > > Repository: plasma-mediacenter > > > Description > ------- > > taglib 1.4 is requested to build plasma-mediacenter > but taglib 1.10.0 shipped by kde git was parsed as version 1.1 causing the > test failure > > > Diffs > ----- > > cmake/FindTaglib.cmake c23d582 > > Diff: https://git.reviewboard.kde.org/r/124647/diff/ > > > Testing > ------- > > Run cmake with kdesrc-build on debian strecth > taglib version correctly found and parsed > and plasma-mediacenter succesfully build > > > Thanks, > > Luca Sartorelli > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
