Re: Review Request 124580: Use the better implementation of IconDialog

On Sat, Aug 1, 2015 at 8:27 PM, David Edmundson wrote: > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124580/ > Review request for Plasma. > By David Edmundson. > *Repository: * plasma-desktop > Description > > For some reason we have two IconDia

Re: Review Request 124585: Add pretty user switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124585/#review83355 --- I like the idea. Would it be better UI if we moved "New Sessi

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 114 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/114/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 02 Aug 2015 22:33:26 + Build duration: 1 min 34 sec CHANGE SET Revision 7a514de428ef1da5fa14dc004775c21

Re: Review Request 124580: Use the better implementation of IconDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124580/ --- (Updated Aug. 2, 2015, 10:33 p.m.) Status -- This change has been ma

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Aug. 2, 2015, 6:54 nachm., Jens Reuterberg wrote: > > Awesome! From a visual perspective two things, the line width of the icon > > when in systray is kinda off it seems in the screenshots (the line is > > thinner in the other icons, 1px I think) and the icon itself is too big > > taking

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83345 --- Awesome! From a visual perspective two things, the line width

Re: Review Request 124585: Add pretty user switcher

> On Aug. 2, 2015, 6:12 nachm., Heiko Tietze wrote: > > I would rather add a distict button for new session. But anyway please > > check the keyboard access. The current screen needs tab to switch between > > buttons (with tab between) and sessions (and arrow keys there) whereas the > > defaul

Re: Review Request 124585: Add pretty user switcher

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124585/#review83339 --- I would rather add a distict button for new session. But anywa

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review8 --- applets/diskquota/plugin/DiskQuota.cpp (line 161)

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83335 --- +1 LGTM - Kai Uwe Broulik On Aug. 2, 2015, 2:06 nachm., Dom

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 2, 2015, 2:06 p.m.) Review request for Plasma, Kai Uwe Brou

Re: Review Request 124589: Add Disk Quota Plasmoid

> On Aug. 2, 2015, 12:38 p.m., Kai Uwe Broulik wrote: > > applets/diskquota/plugin/DiskQuota.h, lines 111-113 > > > > > > You could initialize these directly in the header file. > > > > bool m_quotaInsta

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 2, 2015, 1:59 p.m.) Review request for Plasma, Kai Uwe Brou

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83321 --- Nice! :) Just being pedantic here, I've seen it work nicely i

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- (Updated Aug. 2, 2015, 12:17 p.m.) Review request for Plasma, Kai Uwe Bro

Re: Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/#review83320 --- applets/diskquota/plugin/DiskQuota.cpp (line 170)

Re: Review Request 124434: [Panel] Delay disappearance of panel configuration bar on focus lost

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124434/ --- (Updated Aug. 2, 2015, 1:29 p.m.) Status -- This change has been dis

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 113 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 02 Aug 2015 10:06:44 + Build duration: 10 min CHANGE SET Revision b7d61145b57e5f749f5c5627d044a47254408

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 113 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/113/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 02 Aug 2015 10:06:44 + Build duration: 10 min CHANGE SET Revision b7d61145b57e5f749f5c5627d044a47254408

Re: Review Request 124296: Update autostart kcm docbook to kf5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124296/ --- (Updated Aug. 2, 2015, 10:06 a.m.) Status -- This change has been ma

Review Request 124589: Add Disk Quota Plasmoid

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124589/ --- Review request for Plasma, Kai Uwe Broulik and Sebastian Kügler. Reposito