On Sat, Aug 1, 2015 at 8:27 PM, David Edmundson <da...@davidedmundson.co.uk> wrote:
> This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124580/ > Review request for Plasma. > By David Edmundson. > *Repository: * plasma-desktop > Description > > For some reason we have two IconDialog's exported to QML. > > One in KDeclarative, one in Plasma-Frameworks/platformcomponents. > > The one in plasmacomponents performs an exec() in the main thread from > QML which is a very bad idea. the one in kdeclarative is good. > > BUG: 350864 > > Testing > > Changed my activity icon. > > Diffs > > - desktoppackage/contents/activitymanager/ActivityCreationDialog.qml > (102926bf57f21f33e2c45ff160ddfc68dd028dde) > > View Diff <https://git.reviewboard.kde.org/r/124580/diff/> > > _______________________________________________ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/listinfo/plasma-devel > > Can we deprecate the one in Plasma Framework? Aleix
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
