Re: Review Request 124355: Set notifications to show on all desktops

2015-07-14 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124355/#review82522 --- >From WM perspective +1 - Martin Gräßlin On July 15, 2015,

Re: Review Request 124355: Set notifications to show on all desktops

2015-07-14 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124355/#review82514 --- What happens with popup notifications now with this patch? -

Re: Review Request 124355: Set notifications to show on all desktops

2015-07-14 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124355/#review82513 --- Ship it! Ship It! - David Edmundson On July 14, 2015, 10:3

Review Request 124355: Set notifications to show on all desktops

2015-07-14 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124355/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 124296: Update autostart kcm docbook to kf5

2015-07-14 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124296/#review82510 --- A quick note about "Use Plasma instead of &kde;?" "but then th

Review Request 124352: Update kwinsceenedges to Plasma 5

2015-07-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124352/ --- Review request for Documentation, Plasma and Martin Gräßlin. Repository:

Review Request 124351: Update kwindecoration kcm docbook to Plama 5

2015-07-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124351/ --- Review request for Documentation, Plasma and Martin Gräßlin. Repository:

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Lamarque Souza
> On July 14, 2015, 8:29 a.m., Kai Uwe Broulik wrote: > > applet/contents/ui/ConnectionItem.qml, line 423 > > > > > > } else { > > connectionView.currentIndexVisibleButton = -1 > > } > > > >

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Lamarque Souza
> On July 14, 2015, 1:11 p.m., Lamarque Souza wrote: > > applet/contents/ui/PopupDialog.qml, line 68 > > > > > > The correct English for this is currentVisibleButtonIndex. > > Jan Grulich wrote: > The meaning

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Jan Grulich
> On Čec. 14, 2015, 8:29 dop., Kai Uwe Broulik wrote: > > applet/contents/ui/ConnectionItem.qml, line 423 > > > > > > } else { > > connectionView.currentIndexVisibleButton = -1 > > } > > > >

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Jan Grulich
> On Čec. 14, 2015, 1:11 odp., Lamarque Souza wrote: > > applet/contents/ui/PopupDialog.qml, line 68 > > > > > > The correct English for this is currentVisibleButtonIndex. The meaning of this is "current index of

Review Request 124347: Update desktopthemedetails kcm docbook to Plasma 5

2015-07-14 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124347/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Kai Uwe Broulik
> On Juli 14, 2015, 8:29 vorm., Kai Uwe Broulik wrote: > > applet/contents/ui/ConnectionItem.qml, line 423 > > > > > > } else { > > connectionView.currentIndexVisibleButton = -1 > > } > > > >

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Lamarque Souza
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124314/#review82494 --- applet/contents/ui/PopupDialog.qml (line 68)

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Lamarque Souza
> On July 14, 2015, 8:29 a.m., Kai Uwe Broulik wrote: > > applet/contents/ui/ConnectionItem.qml, line 423 > > > > > > } else { > > connectionView.currentIndexVisibleButton = -1 > > } > > > >

Re: Review Request 124340: Use plasma icon for update notifier

2015-07-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124340/#review82489 --- notifier/MuonNotifier.cpp (line 113)

Re: Review Request 124342: Show plasmoid / application icon in systray entries config

2015-07-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124342/ --- (Updated July 14, 2015, 10:04 a.m.) Status -- This change has been m

Re: Review Request 124342: Show plasmoid / application icon in systray entries config

2015-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124342/#review82485 --- Ship it! Ship It! - Marco Martin On July 13, 2015, 8:01 p.

Re: Review Request 124340: Use plasma icon for update notifier

2015-07-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124340/#review82484 --- Ship it! the icons are not that explanatory indeed, but bette

Re: Review Request 124314: Workaround for notifications stealing focus of the connect/disconnect button

2015-07-14 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124314/#review82483 --- +1 applet/contents/ui/ConnectionItem.qml (line 423)