Re: [PATCH] [kcms/phonon] Don't overwrite audio profile entries with same priority

2015-06-15 Thread Bernie Innocenti
On 15/06/15 22:01, Sebastian Kügler wrote: Easily: https://identity.kde.org/index.php?r=registration/index > > [...] > Ah, thanks for the note. I've updated the documentation about sending patches on Techbase. Awesome, thanks for getting me started, I posted the review. A few more suggestion

Review Request 124108: [kcms/phonon] Don't overwrite audio profile entries with same priority

2015-06-15 Thread Bernie Innocenti
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124108/ --- Review request for Plasma and Harald Sitter. Repository: plasma-desktop

Re: [PATCH] [kcms/phonon] Don't overwrite audio profile entries with same priority

2015-06-15 Thread Sebastian Kügler
On Monday, June 15, 2015 21:25:56 Bernie Innocenti wrote: > On 15/06/15 13:49, Sebastian Kügler wrote: > > On Monday, June 15, 2015 04:35:50 Bernie Innocenti wrote: > >> This is a bug that's been annoying me for ages. My system has 3 HDMI > >> ports, and HDMI2 would show in pavucontrol, but not sho

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Martin Klapetek
> On June 15, 2015, 9:29 p.m., Lukáš Tinkl wrote: > > A better option would be to call registerService() with > > QDBusConnectionInterface::ReplaceExistingService and > > DBusConnectionInterface::AllowReplacement It's the "attempt to replace it." part of it that I'm not entirely happy with. P

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/#review81489 --- A better option would be to call registerService() with QDBus

Re: Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/#review81486 --- +1 *evil laughing up my sleeve* dataengines/notifications/n

Re: [PATCH] [kcms/phonon] Don't overwrite audio profile entries with same priority

2015-06-15 Thread Sebastian Kügler
Hi Bernie, Thanks for your patch! On Monday, June 15, 2015 04:35:50 Bernie Innocenti wrote: > This is a bug that's been annoying me for ages. My system has 3 HDMI > ports, and HDMI2 would show in pavucontrol, but not show in kcm_phonon. > The reason was that HDMI3 had the same priority of HDMI2 a

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-06-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/#review81485 --- Ship it! I'm still not super convinced we're not just working

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-06-15 Thread William Lieurance
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/ --- (Updated June 15, 2015, 3:52 p.m.) Review request for Plasma. Bugs: 345

Re: Review Request 124072: Refactor the Calendar grid computation a bit

2015-06-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124072/ --- (Updated June 15, 2015, 2:35 p.m.) Status -- This change has been ma

Review Request 124102: Replace other Notifications services when Plasma's notifications are enabled

2015-06-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124102/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Re: Review Request 123991: Select lockscreenpassword not until user can type

2015-06-15 Thread David Kahles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123991/ --- (Updated June 15, 2015, 12:07 p.m.) Status -- This change has been m

Re: Review Request 124093: Bug 345405 - Prevent two wallpaper images showing overlayed when "Scaled, Keep Proportions" is chosen

2015-06-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/#review81477 --- Looks good to me but someone else must approve. wallpapers/i

[PATCH] [kcms/phonon] Don't overwrite audio profile entries with same priority

2015-06-15 Thread Bernie Innocenti
This is a bug that's been annoying me for ages. My system has 3 HDMI ports, and HDMI2 would show in pavucontrol, but not show in kcm_phonon. The reason was that HDMI3 had the same priority of HDMI2 and would be overridden in the cardInfo profiles QMap. --- kcms/phonon/audiosetup.h | 2 +- 1 file c