----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124093/#review81477 -----------------------------------------------------------
Looks good to me but someone else must approve. wallpapers/image/imagepackage/contents/ui/main.qml (line 181) <https://git.reviewboard.kde.org/r/124093/#comment55830> Please use 4 spaces rather than a tab - Kai Uwe Broulik On Juni 15, 2015, 5:47 vorm., William Lieurance wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124093/ > ----------------------------------------------------------- > > (Updated Juni 15, 2015, 5:47 vorm.) > > > Review request for Plasma. > > > Bugs: 345405 > https://bugs.kde.org/show_bug.cgi?id=345405 > > > Repository: plasma-workspace > > > Description > ------- > > Moving the opacity change from a ScriptAction to a parallel OpacityAnimator. > That seems to cause a repaint in whatever weird environment happens to be the > root of this bug. > > > Diffs > ----- > > wallpapers/image/imagepackage/contents/ui/main.qml > 23d23ff7003488d74ece0d70a1c68d129f282c75 > > Diff: https://git.reviewboard.kde.org/r/124093/diff/ > > > Testing > ------- > > See conversation on the bug page > (https://bugs.kde.org/show_bug.cgi?id=345405). This code should work > identically to the current script, but for whatever reason it causes a > repaint to be issued correctly whereas the other does not. > > > Thanks, > > William Lieurance > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
