Re: Review Request 123902: Missing "or" when looking for .cmake and CMakeLists.txt files

2015-05-25 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123902/ --- (Updated May 25, 2015, 4:06 p.m.) Status -- This change has been mar

Re: Review Request 123902: Missing "or" when looking for .cmake and CMakeLists.txt files

2015-05-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123902/#review80811 --- Ship it! Ship It! - Aleix Pol Gonzalez On May 25, 2015, 4:

Review Request 123902: Missing "or" when looking for .cmake and CMakeLists.txt files

2015-05-25 Thread Jarosław Staniek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123902/ --- Review request for KDE Frameworks, Plasma, Kevin Ottens, and Burkhard Lück.

Re: Review Request 123888: [krunner] Bring back history

2015-05-25 Thread Kai Uwe Broulik
> On Mai 25, 2015, 7:55 vorm., Vishesh Handa wrote: > > lookandfeel/contents/runcommand/RunCommand.qml, line 104 > > > > > > We need the cursor position to be updated for runners which change the > > query strin

Re: Review Request 123731: Cleanup handling of notifications closing

2015-05-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123731/ --- (Updated May 25, 2015, 8:23 a.m.) Status -- This change has been mar

Re: Review Request 123888: [krunner] Bring back history

2015-05-25 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123888/#review80790 --- Good work! Let me try it out myself and see how it feels. kr

Re: Review Request 123889: [krunner] Add button to clear history

2015-05-25 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123889/#review80789 --- Ship it! Please only ship this once the other patch is in.