Review Request 123808: Add FindEvdev cmake module BUG:347749

2015-05-15 Thread Yue Liu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123808/ --- Review request for Plasma and David Edmundson. Bugs: 347749 https://b

Review Request 123807: Fix popup menu items getting stray highlighted

2015-05-15 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123807/ --- Review request for Plasma, David Edmundson and Hugo Pereira Da Costa. Bug

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

2015-05-15 Thread David Faure
> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

2015-05-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123781/#review80432 --- Ship it! Ship It! - David Faure On May 13, 2015, 7:38 p.m.

Re: Delete master branch of kde-workspace

2015-05-15 Thread Marco Martin
On Friday 15 May 2015 20:14:49 Martin Gräßlin wrote: > Hi, > > we just have a review request against master of kde-workspace [1] and this > made me wonder: should we delete the content of the master branch and > replace it with a readme pointing to the repositories split out from it? > > Cheers >

Delete master branch of kde-workspace

2015-05-15 Thread Martin Gräßlin
Hi, we just have a review request against master of kde-workspace [1] and this made me wonder: should we delete the content of the master branch and replace it with a readme pointing to the repositories split out from it? Cheers Martin [1] https://git.reviewboard.kde.org/r/123797/ signature.a

No ISO for 20150515

2015-05-15 Thread Harald Sitter
There is no ISO this week because various breakage all over the place delayed integration. Best I can offer is an ISO from wednesday with excitingly broken baloo and plasma ;) HS ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mai

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

2015-05-15 Thread Eike Hein
> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 123799: Use QtRendering for fonts in password fields

2015-05-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123799/ --- (Updated May 15, 2015, 12:31 p.m.) Status -- This change has been ma

Re: Review Request 123799: Use QtRendering for fonts in password fields

2015-05-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123799/#review80395 --- Ship it! I'd suggest commenting the code as well as the git m

Re: Review Request 123799: Use QtRendering for fonts in password fields

2015-05-15 Thread Marco Martin
> On May 15, 2015, 11:31 a.m., Kai Uwe Broulik wrote: > > Here the bullets look perfectly spaced #lowdpiproblems check your privilege :p - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde

Re: Review Request 123799: Use QtRendering for fonts in password fields

2015-05-15 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123799/#review80392 --- Here the bullets look perfectly spaced #lowdpiproblems - Kai

Re: Review Request 123799: Use QtRendering for fonts in password fields

2015-05-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123799/#review80389 --- +1 - Aleix Pol Gonzalez On May 15, 2015, 12:19 p.m., Marco

Re: Review Request 123621: Fix reverse scroll setting in Mouse KCM

2015-05-15 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123621/#review80387 --- kcms/input/mouse.cpp (line 79)

Review Request 123799: Use QtRendering for fonts in password fields

2015-05-15 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123799/ --- Review request for Plasma. Repository: plasma-framework Description ---

Re: Review Request 123783: Adjust showing desktop behavior

2015-05-15 Thread Thomas Lübking
> On Mai 14, 2015, 11:23 nachm., Thomas Pfeiffer wrote: > > > 1) The minimizability of windows is ignored. It's a cornercase, but the > > > former behavior was a side-effect of the implementation. (At least I > > > don't know a reason to keep them) > > > > Could you explain what minimizability

Re: Review Request 123781: Don't mangle UDS_TARGET_URL to UDS_LOCAL_PATH in UDSEntries

2015-05-15 Thread David Faure
> On May 14, 2015, 7:17 p.m., David Faure wrote: > > Right, this code should have been ported to > > > > entry.insert(KIO::UDSEntry::UDS_TARGET_URL, > > QUrl::fromLocalFile(entry.stringValue(KIO::UDSEntry::UDS_LOCAL_PATH))); > > > > This would seem safer to me, because closer to the kde4 behav

Re: Review Request 123682: Plasma-Desktop: Port kcm fonts to QML.

2015-05-15 Thread Marco Martin
> On May 9, 2015, 1:18 p.m., Eike Hein wrote: > > Regressions just going by the screenshot: > > * Doesn't use form layouting (e.g. the font box labels aren't > > right-aligned). > > * The font box height doesn't match the button heights anymore. > > * Missing colons in the text labels. > > * Won