----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123799/#review80395 -----------------------------------------------------------
Ship it! I'd suggest commenting the code as well as the git message. (also you have a lot of typos in your commit message) - David Edmundson On May 15, 2015, 10:19 a.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123799/ > ----------------------------------------------------------- > > (Updated May 15, 2015, 10:19 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > ------- > > we are using the native rendering everywhere for fonts, in order to have a > crisp rendering. > however, does what hinting does, deforms the shapes. > in the case of password fields, where the echo is the big circle character, > the circle gets aclually moved horizontally, having circles grouped two by > two, rendring very bad. > > Since is a circle woithout vertical or horizontal lines, it won't me more or > less blurred with different rendring types. > using Qt rendering, the dots will look more aligned and equally spaced > > > Diffs > ----- > > src/declarativeimports/plasmastyle/TextFieldStyle.qml e80b95c > > Diff: https://git.reviewboard.kde.org/r/123799/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
