Re: Review Request 123653: New Minimize Windows Plasmoid

2015-05-05 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 --- >From experience with the show desktop feature and the problem

[Powerdevil] [Bug 347138] Secondary display never turns off

2015-05-05 Thread Albert Vaca
https://bugs.kde.org/show_bug.cgi?id=347138 Albert Vaca changed: What|Removed |Added Ever confirmed|0 |1 Resolution|WAITINGFORINFO

Review Request 123653: New Minimize Windows Plasmoid

2015-05-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/ --- Review request for Plasma. Bugs: 346837 http://bugs.kde.org/show_bug.

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/ --- (Updated May 6, 2015, 12:04 a.m.) Status -- This change has been mar

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Aleix Pol Gonzalez
> On May 6, 2015, 12:57 a.m., Aleix Pol Gonzalez wrote: > > LGTM, thanks for looking into this. > > > > The alternative David suggests also sounds good, maybe better but not by > > that much. > > Sebastian Kügler wrote: > Agree. I'll let the guard in as well, just to be super-safe that the

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Sebastian Kügler
> On May 5, 2015, 10:57 p.m., Aleix Pol Gonzalez wrote: > > LGTM, thanks for looking into this. > > > > The alternative David suggests also sounds good, maybe better but not by > > that much. Agree. I'll let the guard in as well, just to be super-safe that the crash is gone (and not reintrodu

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/#review79931 --- Ship it! LGTM, thanks for looking into this. The alternative

Re: Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/#review79923 --- Ship it! Good stuff :) shell/shellcorona.cpp (line 189)

Review Request 123648: Guard access to kscreen configuration

2015-05-05 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123648/ --- Review request for Plasma. Bugs: 346590 https://bugs.kde.org/show_bug

Re: Review Request 123645: Force visible scrollbars in ScrollView

2015-05-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123645/ --- (Updated May 5, 2015, 8:14 p.m.) Status -- This change has been mark

Re: Review Request 123645: Force visible scrollbars in ScrollView

2015-05-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123645/#review79915 --- Thinking about it, theoretically we could add a small QML item

Re: Review Request 123645: Force visible scrollbars in ScrollView

2015-05-05 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123645/#review79914 --- Ship it! I think that Qt report might be waiting on us? Espec

Review Request 123645: Force visible scrollbars in ScrollView

2015-05-05 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123645/ --- Review request for Plasma and KDE Usability. Bugs: 347254 http://bugs