----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123653/#review79941 -----------------------------------------------------------
>From experience with the show desktop feature and the problems when minimizing >all windows I highly suggest to only minimize all windows. Don't even try to >restore the minimized state when clicked again. applets/minimizeall/plugin/minimizeall.cpp (line 44) <https://git.reviewboard.kde.org/r/123653/#comment54839> this creates a copy of the list (it calls ::begin() instead of ::constBegin()). If you want a performant variant either create a temp variable: const auto &stackingOrder = KWindowSystem::self()->stackingOrder(); for (auto wid: stackingOrder) or use Qt's foreach macro (which uses const iterators internally), or use a good old iterator based loop. - Martin Gräßlin On May 6, 2015, 2:16 a.m., Sebastian Kügler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123653/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 2:16 a.m.) > > > Review request for Plasma. > > > Bugs: 346837 > http://bugs.kde.org/show_bug.cgi?id=346837 > > > Repository: kdeplasma-addons > > > Description > ------- > > New Minimize Windows Plasmoid > > This plasmoid allows to minimize windows on the current desktop. It does > not mess with the KWindowSystem::showingDesktop flag, just allows to hide > and show windows. > > > Diffs > ----- > > applets/CMakeLists.txt 7ada7acad6796bcb18e0f408f00b3720a8df2393 > applets/minimizeall/CMakeLists.txt PRE-CREATION > applets/minimizeall/Messages.sh PRE-CREATION > applets/minimizeall/package/contents/config/main.xml PRE-CREATION > applets/minimizeall/package/contents/ui/main.qml PRE-CREATION > applets/minimizeall/package/metadata.desktop PRE-CREATION > applets/minimizeall/plugin/minimizeall.h PRE-CREATION > applets/minimizeall/plugin/minimizeall.cpp PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.h PRE-CREATION > applets/minimizeall/plugin/minimizeallplugin.cpp PRE-CREATION > applets/minimizeall/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/123653/diff/ > > > Testing > ------- > > Used it for a while. > > > Thanks, > > Sebastian Kügler > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
