Re: Review Request 123280: Kickoff - Properly register recent applications right after startup

2015-04-06 Thread Anthony Vital
> On avr. 6, 2015, 11:20 après-midi, David Edmundson wrote: > > I don't understand the moving the recently used model startup part. > > > > What's broken about loading it later? When you launch an application right after startup, an internal list is populated by loading the recent application

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78580 --- ship it. applets/timer/package/contents/ui/configAdvanced.qm

Re: Review Request 123280: Kickoff - Properly register recent applications right after startup

2015-04-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/#review78581 --- I don't understand the moving the recently used model startup

Review Request 123280: Kickoff - Properly register recent applications right after startup

2015-04-06 Thread Anthony Vital
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123280/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78577 --- Personally I think this patch makes sense, having the button a

Plasma 5.3 changelog

2015-04-06 Thread Eike Hein
Hiyo, we're freezing this week, so it's time to gather the changes for the promo folks again. I'll start with the noteworthy stuff in my components: * The Desktop and Folder View containment codebases were unified, and have seen performance improvements, code cleanups and porting to newer

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Mathias Kraus
> On April 6, 2015, 5:18 nachm., Mark Gaiser wrote: > > Err, i don't see an error in the vertical before version. The kickoff icon > > simply scales to the new available width, that's how it's supposed to work, > > right? > > > > I'm not 100% sure. A plasma dev will probably jump in and correc

Re: Review Request 122842: Allow selecting notifications position on screen

2015-04-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122842/ --- (Updated April 6, 2015, 6:09 p.m.) Status -- This change has been ma

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78570 --- Err, i don't see an error in the vertical before version. The

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread Bernhard Friedreich
> On April 6, 2015, 2:29 nachm., David Edmundson wrote: > > File Attachment: General Tab - tab_general.png > > > > > > Given this looks like advanced feature, I'd rather we hid it away so it > > wasn't the first thing that comes up in t

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread David Edmundson
> On April 6, 2015, 2:29 p.m., David Edmundson wrote: > > applets/timer/plugin/timer.cpp, line 28 > > > > > > QProcess::stateDetached("touch /tmp/asdf"); > > > > doesn't behave quite as you think it shoul

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 4:05 nachm.) Review request for Plasma. Changes

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 3:55 nachm.) Review request for Plasma. Changes

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread Bernhard Friedreich
> On April 6, 2015, 2:29 nachm., David Edmundson wrote: > > applets/timer/plugin/timer.cpp, line 28 > > > > > > QProcess::stateDetached("touch /tmp/asdf"); > > > > doesn't behave quite as you think it sho

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-06 Thread Ashish Bansal
> On April 6, 2015, 1:12 p.m., Martin Klapetek wrote: > > Just a question - why is the current suggested name wrong? In name "filename-1.6.tar.gz", 1.6 denotes package version and new suggested name changes it to "filename-1 2.6.tar.gz". It should add 1 after the package version and should no

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread Bernhard Friedreich
> On April 6, 2015, 2:29 nachm., David Edmundson wrote: > > File Attachment: General Tab - tab_general.png > > > > > > Given this looks like advanced feature, I'd rather we hid it away so it > > wasn't the first thing that comes up in t

Re: Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.

2015-04-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/#review78561 --- Ship it! Ship It! - David Edmundson On April 6, 2015, 2:07

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- File Attachment: General Tab - tab_general.png

Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.

2015-04-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/ --- Review request for Plasma. Repository: plasma-framework Description ---

Review Request 123275: Image Wallpaper: Restore index after removing a wallpaper

2015-04-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123275/ --- Review request for Plasma. Bugs: 344384 https://bugs.kde.org/show_bug

Re: Review Request 123224: KIO::suggestName suggests wrong name for some filenames

2015-04-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123224/#review78559 --- Just a question - why is the current suggested name wrong? a

Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 nachm.) Review request for Plasma. Reposit

Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution

2015-04-06 Thread Bernhard Friedreich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- Review request for Plasma. Repository: kdeplasma-addons Description ---

Re: Review Request 123273: Image Wallpaper: Don't show duplicates after removing some of the wallpapers

2015-04-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123273/#review78558 --- wallpapers/image/backgroundlistmodel.cpp (line 246)

Review Request 123273: Image Wallpaper: Don't show duplicates after removing some of the wallpapers

2015-04-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123273/ --- Review request for Plasma. Bugs: 345914 https://bugs.kde.org/show_bug

Re: Review Request 123272: improve digital clock representation on vertical panels

2015-04-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123272/#review78557 --- File Attachment: clock-vertical-after2 - clock-vertical-after

Review Request 123272: improve digital clock representation on vertical panels

2015-04-06 Thread Mathias Kraus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123272/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Mathias Kraus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- Review request for Plasma. Repository: plasma-desktop Description -