----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78580 -----------------------------------------------------------
ship it. applets/timer/package/contents/ui/configAdvanced.qml (line 31) <https://git.reviewboard.kde.org/r/123274/#comment53757> sexy optimisation: Make this the top level item. i.e instead of Item { property alias ColumnLayout { GroupBox { } } } become ColumnLayout { property alias .... GroupBox { } } then you should be able to remove the explicit width/height properties too applets/timer/package/contents/ui/configAdvanced.qml (line 47) <https://git.reviewboard.kde.org/r/123274/#comment53756> enabled: runCommand.checked - David Edmundson On April 6, 2015, 4:05 p.m., Bernhard Friedreich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123274/ > ----------------------------------------------------------- > > (Updated April 6, 2015, 4:05 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > Added tab "General" and "Appearance" in the config ui > > General contains the bits about command execution after the timer has > completed > Appearance contains the ability to hide seconds and showing the title > > The configuration option for showing the title is a bit buggy (again) > This bugreport explains the wrong scaling of the title: 304923 > > I've converted this plasmoid from being qml only to c++ and qml because it > looks like KProcess has no qml interface yet (and I didn't find any place > where to start) > > [Edit 1]: updated to use QProcess > [Edit 2]: renamed General to Advanced and moved it down to make "Appearance" > the default tab on opening > > > Diffs > ----- > > applets/timer/plugin/timerplugin.cpp PRE-CREATION > applets/timer/plugin/timer.cpp PRE-CREATION > applets/timer/plugin/timerplugin.h PRE-CREATION > applets/timer/plugin/timer.h PRE-CREATION > applets/timer/plugin/qmldir PRE-CREATION > applets/timer/package/contents/ui/timer.qml > f675b93bda59eb161fe10b5f575eaa2082b822e0 > applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION > applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION > applets/timer/package/contents/config/config.qml PRE-CREATION > applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f > > Diff: https://git.reviewboard.kde.org/r/123274/diff/ > > > Testing > ------- > > Tested using plasmashell directly and using plasmoidviewer > > > File Attachments > ---------------- > > Appearance Tab > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png > Advanced Tab > > https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png > > > Thanks, > > Bernhard Friedreich > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
