Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123190/#review78423 --- CMakeLists.txt (line 122)

Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR

> On März 31, 2015, 6:02 nachm., David Edmundson wrote: > > this is arch independent? > > Aleix Pol Gonzalez wrote: > Wrong question ;). You meant to say "is this platform independent?". And > the answer is: Yes, it's a variable defined within KDEInstallDirs so that > each platform can do

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/#review78416 --- I think it's on the right track, biggest complain is the neami

Re: Review Request 123211: Ask for confirmation before deleting a wallpaper.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123211/ --- (Updated April 2, 2015, 4:24 p.m.) Review request for Plasma. Changes -

Re: Review Request 123227: Consider visualParent rotation in popupPosition

> On April 2, 2015, 2:23 p.m., David Edmundson wrote: > > +1. > > > > I'd suggest not merging until after 5.9 is tagged given how finicky dialog > > tends to be. > > Marco Martin wrote: > ok, will push next week so superseded by gerrit version https://gerrit.vesnicky.cesnet.cz/r/#/c/438/

Re: Review Request 123227: Consider visualParent rotation in popupPosition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/ --- (Updated April 2, 2015, 2:53 p.m.) Status -- This change has been di

Re: Review Request 123227: Consider visualParent rotation in popupPosition

> On April 2, 2015, 2:23 p.m., David Edmundson wrote: > > +1. > > > > I'd suggest not merging until after 5.9 is tagged given how finicky dialog > > tends to be. ok, will push next week so - Marco --- This is an automatically generate

Change in plasma-framework[master]: Consider visualParent rotation in popupPosition

Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/438 Change subject: Consider visualParent rotation in popupPosition .. Consider visualParent rotation in popupPosition if there are transf

Re: Review Request 123227: Consider visualParent rotation in popupPosition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/#review78408 --- +1. I'd suggest not merging until after 5.9 is tagged given h

Re: Review Request 123227: Consider visualParent rotation in popupPosition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/ --- (Updated April 2, 2015, 2 p.m.) Review request for Plasma. Bugs: 345787

Review Request 123227: Consider visualParent rotation in popupPosition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123227/ --- Review request for Plasma. Bugs: 345787 http://bugs.kde.org/show_bug.

Re: Review Request 123222: Fix assert by not calling onto an empty path for setOfflineWebApplicationCachePath()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123222/#review78398 --- Ship it! Ship It! - David Edmundson On April 2, 2015, 11:1

Review Request 123222: Fix assert by not calling onto an empty path for setOfflineWebApplicationCachePath()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123222/ --- Review request for Plasma. Repository: libksysguard Description ---

Re: Review Request 123164: Add new Bluetooth applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/#review78395 --- +1 from me. Maybe wait for another +1 from someone else as it'

Re: Review Request 123164: Add new Bluetooth applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/ --- (Updated April 2, 2015, 10:13 a.m.) Review request for Bluedevil and Plas

Re: Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123220/ --- (Updated April 2, 2015, 9:49 a.m.) Status -- This change has been ma

Re: Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123220/#review78394 --- Ship it! Ship It! - David Edmundson On April 2, 2015, 9:33

Re: Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123220/ --- (Updated April 2, 2015, 11:33 a.m.) Review request for Plasma. Reposito

Review Request 123220: kfontinst: Fix font list view header alignment and item sizehint

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123220/ --- Review request for Plasma. Repository: plasma-desktop Description -