----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123222/ -----------------------------------------------------------
Review request for Plasma. Repository: libksysguard Description ------- If we pass an empty string, we end up asserting here: qt5/qtwebkit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:372 #0 0x00007fffed178512 in WTFCrash () at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WTF/wtf/Assertions.cpp:345 #1 0x00007fffec78e161 in WebCore::ApplicationCacheStorage::setCacheDirectory (this=0xa07a70, cacheDirectory=...) at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:372 #2 0x00007fffeb5085c5 in QWebSettings::setOfflineWebApplicationCachePath (path="") at /home/kde-devel/frameworks/qt5/qtwebkit/Source/WebKit/qt/Api/qwebsettings.cpp:1142 #3 0x00007ffff79087bd in ScriptingHtmlDialog::ScriptingHtmlDialog (this=0x969720, parent=0x744080) at /home/kde-devel/frameworks/libksysguard/processui/scripting.cpp:64 So we just don't set an empty string. Diffs ----- processui/scripting.cpp a0efd69 Diff: https://git.reviewboard.kde.org/r/123222/diff/ Testing ------- Now I don't get a crash anymore. Thanks, Aleix Pol Gonzalez
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
