Re: Review Request 122822: Hide pager when there's only one virtual desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122822/#review77043 --- Ship it! Ship It! - Martin Gräßlin On March 5, 2015, 2:06

Re: plasma-mediacenter in kdereview from extragear

Hello! On Thu, Feb 19, 2015 at 8:22 PM, Bhushan Shah wrote: > We want to move plasma-mediacenter to kde/workspace for releasing it > with Plasma 5.x release cycle, Plasma media center is living room > solution of plasma workspaces, it is integrated as shell package for > PMC. Given the two week

Re: Review Request 122823: Avoid KDE4 lingo in colors kcm

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122823/#review77038 --- Ship it! Ship It! - Jeremy Whiting On March 4, 2015, 6:49

Review Request 122824: [kickoff] Rename Recently Used tab to History and Applications to Apps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122824/ --- Review request for Plasma. Repository: plasma-desktop Description -

Review Request 122823: Avoid KDE4 lingo in colors kcm

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122823/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 122822: Hide pager when there's only one virtual desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122822/#review77035 --- +1 - Aleix Pol Gonzalez On March 5, 2015, 2:06 a.m., Sebast

Review Request 122822: Hide pager when there's only one virtual desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122822/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 122733: Fix path traversal checks in KPackage

> On March 4, 2015, 7:23 p.m., Hrvoje Senjan wrote: > > this has broken wallpaper loading here... > > there's loads of Attempting to read file from invalid package! file type: > > "metadata" file name: "" package path: "/usr/share/wallpapers/Aghi/" ... > > warnings... > > Marco Martin wrote: >

Re: Review Request 122733: Fix path traversal checks in KPackage

> On March 4, 2015, 7:23 p.m., Hrvoje Senjan wrote: > > this has broken wallpaper loading here... > > there's loads of Attempting to read file from invalid package! file type: > > "metadata" file name: "" package path: "/usr/share/wallpapers/Aghi/" ... > > warnings... > > Marco Martin wrote: >

Re: Review Request 122733: Fix path traversal checks in KPackage

> On March 4, 2015, 7:23 p.m., Hrvoje Senjan wrote: > > this has broken wallpaper loading here... > > there's loads of Attempting to read file from invalid package! file type: > > "metadata" file name: "" package path: "/usr/share/wallpapers/Aghi/" ... > > warnings... > > Marco Martin wrote: >

Re: Review Request 122598: Add separate checkbox for automatically lock screen

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/#review77013 --- It does follow the layout guidelines now, but the colon after

Re: Review Request 122733: Fix path traversal checks in KPackage

> On March 4, 2015, 7:23 p.m., Hrvoje Senjan wrote: > > this has broken wallpaper loading here... > > there's loads of Attempting to read file from invalid package! file type: > > "metadata" file name: "" package path: "/usr/share/wallpapers/Aghi/" ... > > warnings... right, now an autotest fai

Re: Review Request 122733: Fix path traversal checks in KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review77011 --- this has broken wallpaper loading here... there's loads of Att

Re: Review Request 121206: Port savesystem to KDevPlatform and qml

> On March 2, 2015, 4:20 p.m., Aleix Pol Gonzalez wrote: > > plasmate/plugins/savesystemview/git.cpp, line 156 > > > > > > This won't scale very much, I'd suggest using a VcsEventModel, but I > > guess this can

Re: Review Request 121206: Port savesystem to KDevPlatform and qml

> On March 2, 2015, 5:20 p.m., Aleix Pol Gonzalez wrote: > > plasmate/plugins/savesystemview/git.cpp, line 156 > > > > > > This won't scale very much, I'd suggest using a VcsEventModel, but I > > guess this can

Re: Review Request 122810: Adjust kdeclarative public deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122810/ --- (Updated March 4, 2015, 3:05 p.m.) Status -- This change has been ma

Help finishing the report from the Plasma sprint

Hi all, We haven't published the Dot story about our recent Plasma sprint yet. It would be good if everybody who attended could go over our draft document and add missing and clarify existing bits, so we can get published soon. The current draft is at https://notes.kde.org/p/plasma-sprint-2015-

Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

> On March 4, 2015, 2:10 p.m., David Edmundson wrote: > > src/plasma/framesvg.cpp, line 807 > > > > > > we need to setDevicePixelRatio on this, otherwise any app that tries to > > paint a FrameSvg::Pixmap() into

Re: Review Request 122810: Adjust kdeclarative public deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122810/#review77004 --- Ship it! Ship It! - Marco Martin On March 4, 2015, 2:38 p.

Review Request 122810: Adjust kdeclarative public deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122810/ --- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: k

Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122673/ --- (Updated March 4, 2015, 2:31 p.m.) Review request for Plasma. Repositor

Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

> On March 4, 2015, 2:10 p.m., David Edmundson wrote: > > src/plasma/svg.cpp, line 762 > > > > > > Returning pixmaps with a doubled size with no devicePixelRatio set is > > going to screw up the client in a QPai

Re: Review Request 122805: Make date and time clock high DPI capable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122805/ --- (Updated March 4, 2015, 2:20 p.m.) Status -- This change has been di

Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122673/#review77000 --- src/plasma/framesvg.cpp

Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122673/ --- (Updated March 4, 2015, 2 p.m.) Review request for Plasma. Repository:

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

> On Feb. 27, 2015, 11:48 a.m., Martin Klapetek wrote: > > Can this be configured? I for sure don't want to be sending all my > > surroundings "somewhere" > > Martin Gräßlin wrote: > Yes it probably even has to be configured. I think we need to present the > "privacy contract" of the servi

Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/ --- (Updated March 4, 2015, 2 p.m.) Review request for Plasma, Jan Grulich an

Re: Review Request 122673: Make Svg, FrameSvg work qith QT_DEVICE_PIXELRATIO

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122673/ --- (Updated March 4, 2015, 12:50 p.m.) Review request for Plasma. Reposito

Review Request 122805: Make date and time clock high DPI capable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122805/ --- Review request for Plasma. Repository: plasma-desktop Description -

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 4, 2015, 10:51 a.m.) Status -- This change has been m

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76991 --- Ship it! Looking good. src/kdeclarative/qmlobject.h

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76989 --- +1 - David Edmundson On March 3, 2015, 7:29 p.m., Marco Mar

Re: Review Request 122799: Simple fix for huge icon sizes on some monitors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122799/ --- (Updated March 4, 2015, 10:26 a.m.) Status -- This change has been m

Re: Review Request 122795: Fix crashes when attempting to load invalid package

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/#review76987 --- Ship it! Ship It! - Sebastian Kügler On March 3, 2015, 7:3

Re: Review Request 122799: Simple fix for huge icon sizes on some monitors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122799/#review76986 --- Ship it! Neat and minimal! - Sebastian Kügler On March 4,

Re: Review Request 122740: set QT_DEVICE_PIXEL_RATIO on startup loaded from a config file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122740/ --- (Updated March 4, 2015, 10 a.m.) Status -- This change has been mark

Re: Review Request 122799: Simple fix for huge icon sizes on some monitors

> On March 4, 2015, 10:25 a.m., Martin Gräßlin wrote: > > Should that fix my issue? Should I give it a try? > > David Edmundson wrote: > I think it will fix it, I can't be sure though. yes, works \o/ - Martin --- This is an automat

Re: Review Request 122800: Add a Wayland implementation for KWindowSystemPrivate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122800/#review76983 --- Ship it! - David Edmundson On March 4, 2015, 9:18 a.m., Mar

Re: Review Request 122799: Simple fix for huge icon sizes on some monitors

> On March 4, 2015, 9:25 a.m., Martin Gräßlin wrote: > > Should that fix my issue? Should I give it a try? I think it will fix it, I can't be sure though. - David --- This is an automatically generated e-mail. To reply, visit: https://g

Re: Review Request 122799: Simple fix for huge icon sizes on some monitors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122799/#review76981 --- Should that fix my issue? Should I give it a try? - Martin Gr

Review Request 122800: Add a Wayland implementation for KWindowSystemPrivate

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122800/ --- Review request for KDE Frameworks and Plasma. Repository: kwindowsystem

Review Request 122799: Simple fix for huge icon sizes on some monitors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122799/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor