----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122799/#review76986 -----------------------------------------------------------
Ship it! Neat and minimal! - Sebastian Kügler On March 4, 2015, 9:18 a.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122799/ > ----------------------------------------------------------- > > (Updated March 4, 2015, 9:18 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > ------- > > Currently units is mostly based on font metrics except icon size and some SVG > parts which use DPI directly. > > Instead of taking the physical DPI we take the logical DPI which is used > for working out font point -> pixel sizes by everything else. This keeps > everything to be loosely based on font sizes. > It can also be overriden by the user in systemsettings -> fonts -> force > fonts DPI or xdpyinfo, whereas the devicePixelRatio cannot. > > We can rely on this being correct as otherwise every other app would > appear broken. > > Change-Id: I22f668ccea7d6d15ff475e1368c82964bdde1e60 > > > Diffs > ----- > > src/declarativeimports/core/units.cpp 148e08c > > Diff: https://git.reviewboard.kde.org/r/122799/diff/ > > > Testing > ------- > > Ran on my normal screen. Everything is the same. > Ran on a ridiculously high DPI screen, everything is better than before. > > Would be good if Martin G could test on his broken screen. > > > Thanks, > > David Edmundson > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
