Re: Review Request 122766: Don't use a possibly non-existent property "animationsEnabled".

2015-03-03 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122766/ --- (Updated March 4, 2015, 7:23 a.m.) Status -- This change has been ma

Re: Review Request 122766: Don't use a possibly non-existent property "animationsEnabled".

2015-03-03 Thread Elias Probst
> On March 1, 2015, 5:47 p.m., Aleix Pol Gonzalez wrote: > > containments/panel/contents/ui/main.qml, line 448 > > > > > > Maybe add a comment specifying when it will work? I've certainly seen > > this warning,

Re: Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-03 Thread Alex Richardson
> On March 3, 2015, 11:39 p.m., Aleix Pol Gonzalez wrote: > > Would it maybe be possible to get a unit test for the applet loading? I think all the crashes I got were due to https://git.reviewboard.kde.org/r/122733/. Now that that is fixed, the mainscript is always found. I'll try and create a

Re: Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/#review76973 --- Would it maybe be possible to get a unit test for the applet l

Review Request 122795: Fix crashes when attempting to load invalid package

2015-03-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122795/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 7:29 p.m.) Review request for KDE Frameworks and

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread Marco Martin
> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 80 > > > > > > we load this, we set the authors then don't do anything with it? > > > > Is it used implicit

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread David Edmundson
> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 80 > > > > > > we load this, we set the authors then don't do anything with it? > > > > Is it used implicit

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread David Edmundson
> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kpackagelauncherqml/main.cpp, line 99 > > > > > > returning here is weird. ah, you do it because otherwise the QQuickWindow would be out of scope. -

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread Marco Martin
> On March 3, 2015, 5:46 p.m., David Edmundson wrote: > > src/kdeclarative/qmlobject.cpp, line 199 > > > > > > question, where does > > > > KPackage/GenericQML come from? it's an internal type in kpack

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 6:10 p.m.) Review request for KDE Frameworks and

Re: Review Request 122733: Fix path traversal checks in KPackage

2015-03-03 Thread Alex Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/ --- (Updated March 3, 2015, 5:53 p.m.) Status -- This change has been ma

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/#review76958 --- src/kdeclarative/qmlobject.h

Re: Review Request 122668: port of comic applet to plasma5

2015-03-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122668/ --- (Updated March 3, 2015, 3:48 p.m.) Status -- This change has been ma

Re: Review Request 122668: port of comic applet to plasma5

2015-03-03 Thread Marco Martin
> On March 3, 2015, 2:36 a.m., Sebastian Kügler wrote: > > dataengines/comic/comicproviderwrapper.h, line 270 > > > > > > doesn't seem to be initialized to 0 in the .cpp file. Potentially > > dangerous later on.

Re: Review Request 122668: port of comic applet to plasma5

2015-03-03 Thread Marco Martin
> On March 3, 2015, 2:36 a.m., Sebastian Kügler wrote: > > CMakeLists.txt, line 26 > > > > > > Can we remove KDELibs4Support? It doesn't seem to be used in the linker. seems to still be used (by showdesktop acces

Re: Review Request 122733: Fix path traversal checks in KPackage

2015-03-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review76941 --- Ship it! Ship It! - Marco Martin On Feb. 26, 2015, 7:34 p.

Re: Review Request 122667: Some tools for easily do qml based apps using KPackage

2015-03-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122667/ --- (Updated March 3, 2015, 10:14 a.m.) Review request for KDE Frameworks and

Re: Review Request 122781: Enable high DPI pixmaps in systemsettings

2015-03-03 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122781/ --- (Updated March 3, 2015, 9:58 a.m.) Status -- This change has been ma