> On March 3, 2015, 2:36 a.m., Sebastian Kügler wrote: > > dataengines/comic/comicproviderwrapper.h, line 270 > > <https://git.reviewboard.kde.org/r/122668/diff/1/?file=351753#file351753line270> > > > > doesn't seem to be initialized to 0 in the .cpp file. Potentially > > dangerous later on.
it is, line 282 - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122668/#review76934 ----------------------------------------------------------- On Feb. 25, 2015, 5 p.m., Marco Martin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122668/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2015, 5 p.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > this ports the comic applet to plasma5 (and the dataengine to kpackage, > dropping the support of c++ comic plugins that don't exist anymore since KDE > 4.3 anyways) > > > Diffs > ----- > > dataengines/comic/comicproviderkross.h d80a686 > dataengines/comic/comicprovider.h db3c3f1 > dataengines/comic/comic.h 38a3cc2 > dataengines/CMakeLists.txt 41288df > applets/comic/plasma-comic-default.desktop 69874bf > applets/comic/package/contents/ui/main.qml 1862475 > applets/comic/package/contents/ui/configGeneral.qml PRE-CREATION > applets/comic/package/contents/ui/configAppearance.qml PRE-CREATION > applets/comic/package/contents/ui/configAdvanced.qml PRE-CREATION > applets/comic/package/contents/ui/ImageWidget.qml e450db6 > applets/comic/package/contents/ui/FullViewWidget.qml f76bd4c > applets/comic/package/contents/ui/ComicCentralView.qml 4204ddc > applets/comic/appearanceSettings.ui 5dc1144 > applets/comic/comicdata.h 696dc8a > applets/comic/comicinfo.cpp c7372ae > applets/comic/comicmodel.h 87b5a0f > applets/comic/comicmodel.cpp 349019d > applets/comic/comicsaver.cpp cf92c76 > applets/comic/comicupdater.h PRE-CREATION > applets/comic/comicupdater.cpp PRE-CREATION > applets/comic/configwidget.h 0bf450f > applets/comic/configwidget.cpp 0d7b149 > applets/comic/package/contents/config/config.qml PRE-CREATION > applets/comic/package/contents/ui/ButtonBar.qml d10b915 > applets/comic/comicarchivedialog.cpp 35902d8 > applets/comic/comicarchivejob.h 2ee1428 > dataengines/comic/comicprovider.cpp 2e5bb16 > dataengines/comic/comic_package.cpp c4d466f > dataengines/comic/comicproviderkross.cpp c2c9ee9 > dataengines/comic/comicproviderwrapper.h 499f338 > dataengines/comic/comicproviderwrapper.cpp f60a4f6 > dataengines/comic/plasma-packagestructure-comic.desktop e05786a > applets/comic/package/contents/ui/ComicBottomInfo.qml f5885b1 > applets/comic/comicdata.cpp f61be2f > applets/comic/comicarchivejob.cpp 68b42d2 > applets/comic/comicarchivedialog.h 2bd6551 > applets/comic/comic.knsrc e9ddbf7 > applets/comic/checknewstrips.cpp 8558c9e > applets/comic/advancedsettings.ui 9fc4d21 > applets/comic/CMakeLists.txt 9b41b99 > CMakeLists.txt 45d05c7 > applets/CMakeLists.txt c65250a > dataengines/comic/comic.cpp 5eab3fc > dataengines/comic/comic_package.h 06b4b52 > dataengines/comic/CMakeLists.txt 28ef44f > applets/comic/stripselector.cpp cd88ea3 > applets/comic/package/metadata.desktop c015137 > applets/comic/comicSettings.ui fd73d47 > applets/comic/comic.h d460b11 > applets/comic/comic.cpp 8352eee > > Diff: https://git.reviewboard.kde.org/r/122668/diff/ > > > Testing > ------- > > > Thanks, > > Marco Martin > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
