Re: Review Request 122781: Enable high DPI pixmaps in systemsettings

2015-03-02 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122781/#review76938 --- Coding all looks fine from my perspective. I don't have a Plas

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review76937 --- Ship it! Ship It! - Sebastian Kügler On Jan. 24, 2015, 11:

Re: Review Request 122598: Add separate checkbox for automatically lock screen

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122598/#review76936 --- Ship it! Looking good as far as I can see. - Sebastian Kügle

Re: Review Request 122668: port of comic applet to plasma5

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122668/#review76934 --- Ship it! A bunch of niggles, nothing really big, but would be

Re: Review Request 122733: Fix path traversal checks in KPackage

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/#review76933 --- Ship it! Very nice. :) - Sebastian Kügler On Feb. 26, 2015

Re: Review Request 122717: Improve tooltip layouting

2015-03-02 Thread Sebastian Kügler
> On Feb. 26, 2015, 10:10 p.m., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

2015-03-02 Thread Sebastian Kügler
> On March 2, 2015, 6:26 p.m., Martin Klapetek wrote: > > File Attachment: screenshot.png - screenshot.png > > > > > > I'd suggest FormLayout/GridLayout so these are aligned I'd suggest the same. Perhaps we can even move the message abo

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Aleix Pol Gonzalez
> On March 2, 2015, 10:30 p.m., Kai Uwe Broulik wrote: > > That sounds like a bug in the qml engine to me: "The QML engine provides > > automatic type conversion between QVariantList and JavaScript arrays[…]" > > and I haven't seen any issues with the conversion. Did you try QStringList? I did

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/#review76927 --- That sounds like a bug in the qml engine to me: "The QML engin

Review Request 122781: Enable high DPI pixmaps in systemsettings

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122781/ --- Review request for Plasma and Ben Cooksley. Repository: systemsettings

Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

2015-03-02 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76917 --- File Attachment: screenshot.png - screenshot.png

Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

2015-03-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/ --- (Updated March 2, 2015, 6:16 p.m.) Review request for Plasma. Changes -

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/ --- (Updated March 2, 2015, 6:14 p.m.) Status -- This change has been ma

Re: Review Request 122741: Prefer exposing lists to QML with QJsonArray

2015-03-02 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122741/#review76914 --- Ship it! Ship It! - Eike Hein On Feb. 27, 2015, 3:14 p.m.,

Jenkins build is back to normal : plasma-desktop_master_qt5 #1053

2015-03-02 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Build failed in Jenkins: plasma-desktop_master_qt5 #1052

2015-03-02 Thread KDE CI System
See Changes: [hein] Move SystemSettings to the Desktop plugin. -- [...truncated 243 lines...] -- Looking for XRRGetScreenResourcesCurrent -- Looking for XRRGetScreenResourcesCurrent - found

Re: Review Request 122717: Improve tooltip layouting

2015-03-02 Thread Martin Klapetek
> On Feb. 26, 2015, 11:10 p.m., Kai Uwe Broulik wrote: > > I'm now getting most of my headlines elided or wrapped: > > "K-\n Menü" > > "99%. Wird\n geladen" (battery) > > "Aktualisierung..." (updater) > > "KM..." (rather than KMail) > > "Volume at\n 45%" (kmix) > > "Donnerst..." (rather than Donn

Re: Minutes Monday Plasma Hangout

2015-03-02 Thread Ivan Čukić
Ivan: In Moscow, spreading C++ and KDE love. Will be back this Thursday. Cheerio, Ivan On 2 March 2015 at 13:48, Sebastian Kügler wrote: > Hey there! > > Today's minutes from our weekly hangout session ahead! > > Present: Harald, Kai, Martin G., Sebastian, David, Vishesh, Jonathan > > 2nd March

Re: Review Request 121206: Port savesystem to KDevPlatform and qml

2015-03-02 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/#review76899 --- plasmate/plugins/savesystemview/git.cpp

Re: Review Request 121206: Port savesystem to KDevPlatform and qml

2015-03-02 Thread Giorgos Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/ --- (Updated March 2, 2015, 4:30 p.m.) Review request for Plasma. Changes -

Minutes Monday Plasma Hangout

2015-03-02 Thread Sebastian Kügler
Hey there! Today's minutes from our weekly hangout session ahead! Present: Harald, Kai, Martin G., Sebastian, David, Vishesh, Jonathan 2nd March, 2015 David * Merged timedated patches into systemsettings * worked on highdpi stuff, has test hardware now * Fixed ksnapshot hidpi * has Qt patches f

Re: Review Request 122740: set QT_DEVICE_PIXEL_RATIO on startup loaded from a config file

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122740/#review76887 --- Ship it! Ship It! - Sebastian Kügler On Feb. 27, 2015, 2:1

Re: Review Request 122742: Add a combo box to select QT_DEVICE_PIXEL_RATIO

2015-03-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122742/#review76885 --- Code-wise, it looks fine to me. Could you add a screenshot, si

Re: [plasma-desktop] applets/icontasks: make icontasks work with new sycocaless explorer

2015-03-02 Thread Bhushan Shah
On Sat, Feb 28, 2015 at 11:54 PM, Marco Martin wrote: > so it gets listed but can't load? > ookay (should still install the desktop file in services for now i think) Fixed in http://commits.kde.org/plasma-desktop/bbb8741d19d8a4cb68bb0e1d6f6c3c0e73707912 -- Bhushan Shah http://bhush9.github.io

Re: Review Request 122766: Don't use a possibly non-existent property "animationsEnabled".

2015-03-02 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122766/#review76872 --- Ship it! Ship It! - Marco Martin On Feb. 28, 2015, 10:47 p

Re: Review Request 122506: Fix crash due to unsafe access to ShellCorona::m_screenConfiguration

2015-03-02 Thread Sandro Mani
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122506/ --- (Updated March 2, 2015, 8:48 a.m.) Status -- This change has been di

[kio-extras] [Bug 344355] Commit a5d223221e802b057833e780cdca7cca65c06b52 broke thumbnails generation

2015-03-02 Thread Lukáš Tinkl
https://bugs.kde.org/show_bug.cgi?id=344355 Lukáš Tinkl changed: What|Removed |Added Resolution|--- |FIXED Latest Commit|