----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/#review76899 -----------------------------------------------------------
plasmate/plugins/savesystemview/git.cpp <https://git.reviewboard.kde.org/r/121206/#comment52901> This won't scale very much, I'd suggest using a VcsEventModel, but I guess this can be done further in the future. Other than that looks good to me. +1 - Aleix Pol Gonzalez On March 2, 2015, 3:30 p.m., Giorgos Tsiapaliokas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121206/ > ----------------------------------------------------------- > > (Updated March 2, 2015, 3:30 p.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > ------- > > This patch is a port of the savesystem to KDevPlatform and qml. > > > Savesystem is using KDevPlatform's code for handling the git and > the ui is rewritten in qml. > > I have attached an image of the new savesystem > > > Diffs > ----- > > plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake > PRE-CREATION > plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION > plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION > > plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml > PRE-CREATION > > plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml > PRE-CREATION > > plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml > PRE-CREATION > > plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml > PRE-CREATION > > plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml > PRE-CREATION > > plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml > PRE-CREATION > plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION > plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml > PRE-CREATION > plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml > PRE-CREATION > plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml > PRE-CREATION > plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml > PRE-CREATION > plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION > plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION > plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION > plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION > plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION > plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION > plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION > plasmate/plugins/savesystemview/Messages.sh PRE-CREATION > plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION > plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION > plasmate/plugins/savesystemview/git.h PRE-CREATION > plasmate/plugins/savesystemview/git.cpp PRE-CREATION > plasmate/plugins/CMakeLists.txt 410080b > plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121206/diff/ > > > Testing > ------- > > > File Attachments > ---------------- > > savesystem in kdevelop > > https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png > > > Thanks, > > Giorgos Tsiapaliokas > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
