Re: Review Request 122065: Fix activity start and stop.

2015-01-25 Thread Martin Gräßlin
> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

2015-01-25 Thread Ivan Čukić
> On Jan. 23, 2015, 7:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Re: Review Request 122065: Fix activity start and stop.

2015-01-25 Thread Martin Gräßlin
> On Jan. 23, 2015, 8:40 a.m., Martin Gräßlin wrote: > > This looks still wrong to me. The service is still called "org.kde.kwin" > > while it should be "org.kde.KWin". Ideally this gets changed to a generated > > adaptor from the DBus interface KWin installs. > > > > To make things worse: the

Review Request 122257: Fix maximized window menu button position.

2015-01-25 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122257/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

Re: Review Request 122256: Turn pin into ToolButton

2015-01-25 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122256/#review74731 --- Definitely an improvement! I'm not really sure of the pin's us

Re: Review Request 122256: Turn pin into ToolButton

2015-01-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122256/#review74730 --- Ship it! +1 TBH, maybe we can just drop the pin... I can't t

Review Request 122256: Turn pin into ToolButton

2015-01-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122256/ --- Review request for Plasma and KDE Usability. Repository: plasma-workspace

[Powerdevil] [Bug 189456] powerdevil should not suspend when computer is being shutdown

2015-01-25 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=189456 Bug 189456 depends on bug 318461, which changed state. Bug 318461 Summary: tell powerdevil when to jump, let it decide how high https://bugs.kde.org/show_bug.cgi?id=318461 What|Removed |Added --

[Powerdevil] [Bug 315438] Solid inhibit fails the next suspend if inhibit outlasts suspend countdown while application is still open

2015-01-25 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=315438 Bug 315438 depends on bug 318461, which changed state. Bug 318461 Summary: tell powerdevil when to jump, let it decide how high https://bugs.kde.org/show_bug.cgi?id=318461 What|Removed |Added --

[Powerdevil] [Bug 189456] powerdevil should not suspend when computer is being shutdown

2015-01-25 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=189456 Kai Uwe Broulik changed: What|Removed |Added Assignee|d...@kde.org |plasma-devel@kde.org CC|

[Powerdevil] [Bug 315438] Solid inhibit fails the next suspend if inhibit outlasts suspend countdown while application is still open

2015-01-25 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=315438 Kai Uwe Broulik changed: What|Removed |Added Platform|openSUSE RPMs |unspecified Component|powermanagemen

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-25 Thread David Edmundson
On Jan. 25, 2015, 4:09 p.m., Kai Uwe Broulik wrote: > > Shouldn't we be using KService here? Crazy alternative to consider Expose http://api.kde.org/frameworks-api/frameworks5-apidocs/kcmutils/html/classKSettings_1_1Dialog.html directly to QML, making sure AddModule in invokable. - David

Re: Review Request 122239: Add KCMShell.open() to kquickcontrolsaddons

2015-01-25 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122239/#review74709 --- +1 to the idea src/qmlcontrols/kquickcontrolsaddons/kcmshell

www/sites/www/announcements

2015-01-25 Thread Albert Astals Cid
SVN commit 1412914 by aacid: Make more stuff translatble CCMAIL: plasma-devel@kde.org M +33 -33plasma-5.2.0.php --- trunk/www/sites/www/announcements/plasma-5.2.0.php #1412913:1412914 @@ -33,90 +33,90 @@ " /> -KScreen dual monitor setup + -This release of Plasma comes with so

Re: Remove KQuickControls TextArea/TextField again

2015-01-25 Thread David Edmundson
On Sun, Jan 25, 2015 at 12:21 PM, Kai Uwe Broulik wrote: > Hi everyone, > > a couple of weeks ago I added proper widget-like context menus to TextArea > and > TextField and put them into KDeclarative [1]. I have now upstreamed these > changes and they will be in 5.5 (dev atm is 5.5 right?). > > O

Review Request 122246: Add addSample(qreal value) overload

2015-01-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122246/ --- Review request for Plasma. Repository: kdeclarative Description ---

Re: Remove KQuickControls TextArea/TextField again

2015-01-25 Thread Kai Uwe Broulik
Hi, yes, it's a regular Menu that is behind the "menu" property of TextArea and TextField. Qt has a default menu with Cut/Copy/Paste (5.4) or Undo/Redo/Cut/Copy/Paste/Delete/Clear/Select All (5.5). Unfortunately the default menu itself is not accessible so you cannot override it in a declarati

Re: Remove KQuickControls TextArea/TextField again

2015-01-25 Thread Eike Hein
On 01/25/2015 12:21 PM, Kai Uwe Broulik wrote: Opinions? Is the upstream context menu extensible? Is it possible to get things like Jovie in there to achieve feature parity and consistency between KTextWidgets and QQC? Cheers, Kai Uwe Cheers, Eike ___

Remove KQuickControls TextArea/TextField again

2015-01-25 Thread Kai Uwe Broulik
Hi everyone, a couple of weeks ago I added proper widget-like context menus to TextArea and TextField and put them into KDeclarative [1]. I have now upstreamed these changes and they will be in 5.5 (dev atm is 5.5 right?). Given the other context menu entries (5.4 already ships with Copy/Cut/Pa