Re: Review Request 121761: Fix build on FreeBSD

2014-12-31 Thread Pino Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121761/#review72846 --- ksmserver/screenlocker/greeter/autotests/killtest.cpp

Re: Review Request 121772: Fade panels when dashboard is shown

2014-12-31 Thread Aleix Pol Gonzalez
> On Dec. 31, 2014, 11:29 a.m., Thomas Pfeiffer wrote: > > The more we (the VDG) think and learn about this, the more we realize that > > we haven't really thought it through yet. > > It looks like it's "back to the drawing board" here, as we don't want to > > make a change that makes as many u

Re: Review Request 121772: Fade panels when dashboard is shown

2014-12-31 Thread Thomas Pfeiffer
> On Dez. 31, 2014, 11:29 vorm., Thomas Pfeiffer wrote: > > The more we (the VDG) think and learn about this, the more we realize that > > we haven't really thought it through yet. > > It looks like it's "back to the drawing board" here, as we don't want to > > make a change that makes as many

Re: Review Request 121772: Fade panels when dashboard is shown

2014-12-31 Thread Aleix Pol Gonzalez
> On Dec. 31, 2014, 11:29 a.m., Thomas Pfeiffer wrote: > > The more we (the VDG) think and learn about this, the more we realize that > > we haven't really thought it through yet. > > It looks like it's "back to the drawing board" here, as we don't want to > > make a change that makes as many u

Re: Review Request 121772: Fade panels when dashboard is shown

2014-12-31 Thread Thomas Pfeiffer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121772/#review72832 --- The more we (the VDG) think and learn about this, the more we

Re: Review Request 121710: Avoid risk of starting two kscreen_launchers at the same having race conditions

2014-12-31 Thread David Edmundson
> On Dec. 30, 2014, 2:06 p.m., Daniel Vrátil wrote: > > I guess the code is note perfect and there are still race conditions, but > > this is a good step in the right direction, so let's ship it. I'll think > > about the lockfile solution, or some other and try to implement it (once > > I'm ba

Re: Review Request 121763: Fix build on FreeBSD

2014-12-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/#review72830 --- Ship it! Ship It! - David Edmundson On Dec. 30, 2014, 6:48

Re: Review Request 121763: Fix build on FreeBSD

2014-12-31 Thread David Edmundson
> On Dec. 30, 2014, 6:50 p.m., Raphael Kubo da Costa wrote: > > Looks fine to me, not sure if someone else needs to approve. >not sure if someone else needs to approve. You know your stuff, if you're happy with a patch and it's obviously not going to be controversial feel free to click "ship i

Re: Review Request 121771: Notify panels when dashboard is shown

2014-12-31 Thread David Edmundson
> On Dec. 31, 2014, 10:33 a.m., David Edmundson wrote: > > IMHO, it's a bit too applicaiton specific. > > > > Given kwin does most the dashboard work, and it knows what a panel is it > > could do the fading. > > Kai Uwe Broulik wrote: > It perhaps is but the desktop containment knows it,

Re: Review Request 121771: Notify panels when dashboard is shown

2014-12-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121771/#review72828 --- Ship it! - David Edmundson On Dec. 31, 2014, 10:01 a.m., Ka

Re: Review Request 121761: Fix build on FreeBSD

2014-12-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121761/#review72825 --- Ship it! with the ordering suggestions Raphael suggests - Da

Review Request 121774: Let month menu navigate in current year

2014-12-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121774/ --- Review request for Plasma and Martin Klapetek. Bugs: 342327 http://bu

Re: Review Request 121771: Notify panels when dashboard is shown

2014-12-31 Thread Kai Uwe Broulik
> On Dez. 31, 2014, 10:33 vorm., David Edmundson wrote: > > IMHO, it's a bit too applicaiton specific. > > > > Given kwin does most the dashboard work, and it knows what a panel is it > > could do the fading. It perhaps is but the desktop containment knows it, too. And it is up to the shellp

Re: Review Request 121771: Notify panels when dashboard is shown

2014-12-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121771/#review72823 --- IMHO, it's a bit too applicaiton specific. Given kwin does m

Re: Review Request 121772: Fade panels when dashboard is shown

2014-12-31 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121772/#review72822 --- Ship it! Ship It! - David Edmundson On Dec. 31, 2014, 10:0

Review Request 121771: Notify panels when dashboard is shown

2014-12-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121771/ --- Review request for Plasma. Bugs: 342123 https://bugs.kde.org/show_bug

Review Request 121772: Fade panels when dashboard is shown

2014-12-31 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121772/ --- Review request for Plasma and KDE Usability. Bugs: 342123 https://bug

Jenkins build is back to normal : plasma-desktop_master_qt5 #889

2014-12-31 Thread KDE CI System
See ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel