> On Dez. 31, 2014, 10:33 vorm., David Edmundson wrote: > > IMHO, it's a bit too applicaiton specific. > > > > Given kwin does most the dashboard work, and it knows what a panel is it > > could do the fading.
It perhaps is but the desktop containment knows it, too. And it is up to the shellpackage to decide what to do, I don't know whether we always want to fade panels in any form factor and whether we can load kwin effects based on that - which is why I chose to let the panel qml file itself decide what to do. - Kai Uwe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121771/#review72823 ----------------------------------------------------------- On Dez. 31, 2014, 10:01 vorm., Kai Uwe Broulik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121771/ > ----------------------------------------------------------- > > (Updated Dez. 31, 2014, 10:01 vorm.) > > > Review request for Plasma. > > > Bugs: 342123 > https://bugs.kde.org/show_bug.cgi?id=342123 > > > Repository: plasma-workspace > > > Description > ------- > > This exposes a panel.dashboardShown property similar to the desktop view > which allows the panels to react on it being shown. > It leaves the actual reaction (hide, dim, whatever) to the desktoppackage > since a diferent formfactor might want to handle this differently. > > > Diffs > ----- > > shell/panelview.h d1ef282 > shell/panelview.cpp b7f043d > shell/shellcorona.cpp c26efe5 > > Diff: https://git.reviewboard.kde.org/r/121771/diff/ > > > Testing > ------- > > Panel can now react on it. > > > Thanks, > > Kai Uwe Broulik > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
