Re: Review Request 121563: Fix build with Qt 5.5/dev branch in release mode

2014-12-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121563/#review72162 --- but that will now create a unused variable warning in release

Re: Review Request 121429: Use out-of-band communication between ksld and greeter

2014-12-16 Thread Àlex Fiestas
> On des. 15, 2014, 10:45 p.m., Àlex Fiestas wrote: > > Code looks good. > > > > Could you perhaps add an integration test for this? Since we are > > "abstracted" by the socket it should be possible. If it is too much work > > feel free to push it. > > Martin Gräßlin wrote: > what do you

[Powerdevil] [Bug 340964] System misreporting battery status and won't hibernate at 5% default battery value

2014-12-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=340964 Kai Uwe Broulik changed: What|Removed |Added Resolution|--- |WAITINGFORINFO CC|

[Powerdevil] [Bug 339427] Screen goes off when watching video using VLC or YouTube.

2014-12-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=339427 Kai Uwe Broulik changed: What|Removed |Added Status|CONFIRMED |NEEDSINFO CC|

[Powerdevil] [Bug 340206] do not use Version from org.freedesktop.systemd1.Manager in checkSystemdVersion

2014-12-16 Thread Kai Uwe Broulik
https://bugs.kde.org/show_bug.cgi?id=340206 Kai Uwe Broulik changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED CC|

Review Request 121563: Fix build with Qt 5.5/dev branch in release mode

2014-12-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121563/ --- Review request for Plasma. Repository: libksysguard Description ---

Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite

2014-12-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/#review72121 --- Ship it! Ship It! - Sebastian Kügler On Dec. 16, 2014, 1:3

Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite

2014-12-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/ --- (Updated Dec. 16, 2014, 1:39 p.m.) Review request for Plasma. Repositor

Re: Review Request 121554: Simple network systemmonitor plasmoid rewrite

2014-12-16 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/#review72120 --- The usual nitpick, I'm missing Messages.sh and the catalog loa

Review Request 121554: Simple network systemmonitor plasmoid rewrite

2014-12-16 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121554/ --- Review request for Plasma. Repository: plasma-workspace Description ---

Change in plasma-framework[master]: Add a plotter component

2014-12-16 Thread Marco Martin (Code Review)
Marco Martin has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/244 Change subject: Add a plotter component .. Add a plotter component a Plotter can draw a graph of values arriving from an arbitrary num

Re: Review Request 121466: Oxygen QStyle: Add an option to enable/disable drawing darker frames round the selection highlight

2014-12-16 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121466/#review72111 --- First this should be up to Nuno: he has always been advocating

Re: Feedback on xdg-shell from Plasma crew

2014-12-16 Thread Marco Martin
On Monday 15 December 2014, Jasper St. Pierre wrote: > [0] We all remember terrible WinAmp skins, and Chrome's use of the titlebar > on Windows got some angry, but MS is starting to use the titlebar space > more effectively on their own apps. Office and Visual Studio now have their > own style, ign

Re: Feedback on xdg-shell from Plasma crew

2014-12-16 Thread Jason Ekstrand
Hi Martin! First off, thanks for looking at it and giving your thoughs. I'm going to reply to a few things below from a sort-of "general wayland perspective" I'll leave the hashing out of details to the people who actually work on real compositors. Hopefully, the rest of the list shows similar re

Re: Feedback on xdg-shell from Plasma crew

2014-12-16 Thread Jasper St. Pierre
On Mon, Dec 15, 2014 at 5:30 AM, Martin Gräßlin wrote: > > Hi all, > > I had a look at the xdg-shell proposal in weston (see [1]) and want to > provide > some feedback from a Plasma/KWin point of view. > > First of all: thanks for the work so far on the xdg-shell. The work looks > quite good and p